Closed Bug 415958 Opened 13 years ago Closed 10 years ago

remove the background and border of the Search engine button on Linux

Categories

(Firefox :: Theme, defect)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 4.0b7

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(2 files, 4 obsolete files)

Attached image current look (obsolete) —
It looks like it imitates the Location Bar's dropmarker, to no avail. I propose we remove the background and the border.
Attached image proposal (obsolete) —
What do you think?
Blocks: 405210
Blocks: 398020
I'd be in favour of this if we can make the dropdown arrow more than just a piddly dot, which is what it looks like without the background.

Dao, Linux has a -moz-appearance: toolbarbutton-dropdown rule that draws a native GTK arrow that points down, which is what we use to draw the arrows of the unified dropdown and any folders on the bookmark toolbar. Can you see if you can use that?

I wonder if a GTK arrow can go down to a space that small though. Maybe you could slightly remove some of the left padding of the search engine icon to give the arrow slightly more room.
Why remove the background here and keep it for the identity area? Both are "buttons"... I don't really see why the arrow is needed at all, many GTK search entries have a "button" on the left side which lets you change search options (see Evolution, see Banshee...)

More interesting is the question what to do with search engine discovery. The "glow" does not really work here because the arrows of various GTK themes differ in size and shape...
Ah, btw, I still think the discovery I explained in bug 405443 would make most sense...

But, if it is as simple as Reed said, bug 412322 would solve this all (real button look, no arrow, change of background color for discovered search engine).
(In reply to comment #2)
> I'd be in favour of this if we can make the dropdown arrow more than just a
> piddly dot, which is what it looks like without the background.

How's that related to the background?

> Dao, Linux has a -moz-appearance: toolbarbutton-dropdown rule that draws a
> native GTK arrow that points down, which is what we use to draw the arrows of
> the unified dropdown and any folders on the bookmark toolbar. Can you see if
> you can use that?

As Michael Monreal mentions, you'd need to rework the "glow" for this.

(In reply to comment #3)
> Why remove the background here and keep it for the identity area?

The identity button can have a label that must not look editable. Also, it doesn't have to problem of being right next to the Location bar's dropdown button.
(In reply to comment #5)
> (In reply to comment #2)
> > I'd be in favour of this if we can make the dropdown arrow more than just a
> > piddly dot, which is what it looks like without the background.
> 
> How's that related to the background?

Maybe its just me, but I find it harder to recognize as a shape when you have so much more surface area of the same colour.
Attached image Two other proposals (obsolete) —
For reference: the proposed look with a native arrow, and the look as requested by bug 412322. I have been doing some work on that bug and it requires a lot of tweaking/hacking to get that right.

So code wise I would prefer the solution proposed here, but I also prefer it because I think the button has a very heavy look to it (next to the location bar dropdown), which I personally don't like very much. 

And FWIW I agree that a native arrow would be a big plus, if the discovery could be solved.
Maybe the entire background of the button could be turned a bright blue on discovery? Like in bug 412322 but blue instead of yellow.
(In reply to comment #8)
> Maybe the entire background of the button could be turned a bright blue on
> discovery? Like in bug 412322 but blue instead of yellow.
> 

That can be done, if we choose to use a button.
It doesn't have to be a button, just the area could be turned blue.
I would like us to maintain the same appearance for the search engine button and the identity button.  I agree that the drop marker makes the toolbar looks unbalanced, but I think this is best solved by de-emphasizing the drop marker to only show a button appearance on hover.  Dao implemented this on Windows:

https://bugzilla.mozilla.org/attachment.cgi?id=297257

I know this doesn't technically mesh well with the normal appearance of gtk drop down fields, but it gives the theme a very clean and minimalist look.  Also, this field is already more complicated than a traditional drop down, so making some visual modifications feels warranted.  

Outside of OS visual integration, we've been trying to establish that controls inside of the field act on the contents of the field itself (bookmark it, send to a search engine) while button like caps on the left side of the field involve the context of the information in the field (third party identity verification, what search engine you are going to use).  Since the location bar drop down acts on the contents (replacing it with something else), under this distinction it should be inside instead of a button capped on the end.  But again, we came up with this distinction totally outside of OS visual integration.

I'm all for native drop down arrows.

> Maybe the entire background of the button could be turned a bright blue on
> discovery?

Yeah, I would like us to do this for all themes.
There isn't really an interface guideline clause about this on Linux. In that case the best course of action is cross-platform adherence, which involves keeping the button background. But I have more plans for it in a bug I am about to file.
I filed bug 416061 for the glow to become a complete background change, and to use a native arrow.
Summary: Search engine button makes the Navigation toolbar look unbalanced on Linux → remove the background and border of the Search engine button on Linux
Attached patch possible patch (obsolete) — Splinter Review
Attachment #301698 - Attachment is obsolete: true
Attachment #301699 - Attachment is obsolete: true
(In reply to comment #14)
> Created an attachment (id=302419) [details]
> possible patch
> 

I tried this patch, and on my system at least (fedora core 6 with Clearlooks theme), I do not see the border that this seems to be trying to add for the addengines="true" case.
Doesn't work for me either, though I see nothing wrong about it. It looks like somehow the CSS selector does not apply to the searchbar-dropmarker-image element(?)
Assignee: nobody → dao
Depends on: 482229
No longer depends on: 482229
Attached patch patchSplinter Review
This depends on bug 430627.
Attachment #301743 - Attachment is obsolete: true
Attachment #302419 - Attachment is obsolete: true
Depends on: 430627
Attached image screenshot
Attachment #475042 - Flags: review?(ventnor.bugzilla)
Attachment #475042 - Flags: review?(ventnor.bugzilla) → review+
Comment on attachment 475042 [details] [diff] [review]
patch

Trivial patch, brings gnomestripe in line with win- and pinstripe.
Attachment #475042 - Flags: approval2.0?
Attachment #475042 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/8757a527d7f5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b7
Blocks: 572482
Blocks: 580509
You need to log in before you can comment on or make changes to this bug.