417259 - Bottom row of status bar is clipped if an addon sets overflow-x: hidden and if it has borders (e.g., in Windows Classic)

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Adria Stembridge]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Beta 3 is removing underscores from URLs shown in the toolbar.  "http://test_site.com" becomes "http://test site.com".  

Reproducible: Always

Steps to Reproduce:
1. Mouse over any link for a site containing an underscore in the domain or page name.  
2. View toolbar.
Actual Results:  
Mouse over any link containing a underscore in the domain or page name.  Beta 3 removes this underscore in the toolbar, which is misleading and poses security concerns.

Expected Results:  
URLs shown in the toolbar should always reflect the exact URL, not a "cleaned up" version.

Comment 1

[Adria Stembridge]

I've noticed that google.com's address appears to have the bottom of both g's cut off.  So, thankfully the underscores aren't being purposefully removed.  

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Can you post a screenshot? I don't see cut off text in my status bar, using a Windows trunk nightly.

Comment 3

[Adria Stembridge]

Attachment: Screenshot of toolbar area with missing underscore

Comment 4

[Johnathan Nightingale [:johnath]]

I can't confirm this, but if it is valid, it doesn't need to be a hidden bug.  Updating the summary to reflect the subject of the complaint.

I see normal behaviour on Mac trunk and Vista nightly, but don't have an XP box to confirm. CC'ng tomcat because he has everything.

Comment 5

[Adria Stembridge]

Attachment: Second screenshot of problem

Comment 6

[Adria Stembridge]

Attachment: Trash showing in status bar along the bottom

Comment 7

[Marcia Knous [:marcia]]

Adria: Your screenshot shows a number of extensions installed - does the same thing happen when you start in safe mode with those extensions disabled? http://kb.mozillazine.org/Safe_mode#Windows.

A quick test of Beta 3 using http://region3_sandbox.genetics.emory.edu/data_collection/ does not seem to show the issue on XP.

Comment 8

[Daniel Veditz [:dveditz]]

fwiw I don't see the problem on windows either. I wonder if it could be related to the default system font, or "large fonts" or something along those lines? If safe-mode doesn't eliminate the problem that's what I'd try next.

Comment 9

[Lucas Madar]

This appears to be a problem with FF3b3 and Forecastfox. I was having the same problem and it went away when I disabled and came back when I enabled.

Comment 10

[Aaron]

I'm a Forecastfox developer and I don't have a Windows box here to test this out on, but I'm just wondering, assuming this is actually caused by Forecastfox, is FF3 at enough of a finalized stage in terms of theme that this is worth our trying to track down? I've been using Forecastfox on FF3 nightlies for months now and occasionally it does break on an FF update, but they always seem to fix themselves, so I'm just wondering if this issue is likely to be solved on the FF end.

By the way, I'm running an FF3 nightly on Linux right now with Forecastfox installed and I do not see this bug, so if it does exist it is Windows theme specific (and possibly Mac also).

Comment 11

[Lucas Madar]

(In reply to comment #10)

I can confirm that this is not present on Mac, only the Windows theme.

Comment 12

[Carsten Book [:Tomcat]]

Attachment: screenshot with Forecast Fox installed

(In reply to comment #4)
> I can't confirm this, but if it is valid, it doesn't need to be a hidden bug. 
> Updating the summary to reflect the subject of the complaint.
> 
> I see normal behaviour on Mac trunk and Vista nightly, but don't have an XP box
> to confirm. CC'ng tomcat because he has everything.
> 

i can't confirm this Bug with Forecast Fox installed on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre, the underscores are displayed as expected.

Comment 16

[Kai Liu]

As noted in bug 431092 comment 2, this looks a lot like the problem in bug 412646, except that, unlike the find bar bug, the appearance of this bug seems to be much more isolated (I've never seen it).

Comment 17

[Michael Köhler [:Coce]]

I have the same problem, I'm using Firefox 3.0pre (Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9pre) Gecko/2008052707 Minefield/3.0pre) and Forecastbar Enhanced 0.9.6.

It seems, as if some pieces of the text remain, after hovering a link with the cursor.

The problem also appears in a new Firefox 3.0pre profile with only the Forecastbar Enhanced installed.

Screenshot: <http://i25.tinypic.com/t9bdx1.png>

Comment 18

[Kai Liu]

The following line in Forecastbar Enhanced (presumably, something similar is in ForecastFox too) is the culprit:
statusbar#status-bar { overflow-x: hidden !important; }

overflow-x: hidden on an element with borders will cause this problem.  See bug 412646.  The best solution is to remove the rule from the CSS.  Workarounds for this bug are not exactly feasible for extensions, as the would involve creating new elements in the hierarchy (one workaround is to clip the overflow by setting the vertical center alignment on a child container box, which was the workaround finally adopted by bug 412646, and the other workaround is to remove the borders from the element to which the overflow rule is being applied and move those borders to a child or parent element).

So this is indeed something caused by Forecastfox (or any extension that sets such an overflow rule on the status bar), and IIRC, the Mac status bar has no borders, which may be why it doesn't affect that platform.

Aaron, I guess it's up to you which vial of poison is worse: the overextended status bar pushing out the content window or the problem with painting the bottom row of pixels.  Personally, I'd go with the long status bar, as I don't think too many people will have their windows shrunk small enough that the status bar size problem starts to bite them.

Comment 19

[Kai Liu]

(In reply to comment #18)
> So this is indeed something caused by Forecastfox (or any extension that sets
> such an overflow rule on the status bar)
> 

I should clarify that: the underlying cause is indeed a Gecko bug, but the default Firefox status bar styles are such that this bug would not normally manifest itself, and all that Forecastfox is doing is changing the status bar style such that this underlying bug is activated.

Comment 22

[u304681]

Attachment: Sometimes text is right

Sometimes text is shown right. For instance when you load a page and status text is "wating something".

Comment 23

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Status bar missing underscore and white dropshadow

bottom row is also clipped without addons but with following line in userChrome.css:
statusbar#status-bar { overflow-x: hidden !important; }

White dropshadow of status bar is missing and underscores from urls too.

Comment 24

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Normal status bar with add-ons enabled and userChrome.css: statusbar#status-bar { overflow-x: visible !important; }

Comment 25

[moz]

Attachment: #status-bar: Not without problems

statusbar#status-bar { overflow-x: visible !important; } - that is not really a solution. I have placed Forecastfox not in the statusbar but on the right side of my bookmark-bar. Without the code in the userchrome the statusbar show the described problem but the bookmark-bar is working well. On the left side of Forecastfox the double-headed arrow is shown, where the redundant bookmarks are placed. (see attachment pic. 1 + 2)

With "statusbar#status-bar { overflow-x: visible !important; }" the statusbar is working well but in the bookmark-bar the double-headed arrow does not longer appears. (see attachment Pic. 3)

Comment 26

[Onno Ekker [:nONoNonO UTC+1]]

Changing statusbar overflow (to always visible or hidden) wasn't meant as a workaround for using forecastfox, but to demonstrate this bug also happens without forecastfox or other extensions.

Comment 27

[moz]

Comment on attachment 326663 [details]
#status-bar: Not without problems

><HTML><BODY><IMG height="384" width="250" src="https://bugzilla.mozilla.org/attachment.cgi?id=326663" alt="https://bugzilla.mozilla.org/attachment.cgi?id=326663" style="cursor: -moz-zoom-in;"/></BODY></HTML>

Comment 28

[Gareth]

Attachment: Moz FF 3.0 Status bar cropped text. (Forecast Fox Enhanced, IE tab both on)

Comment 29

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 5 duplicates.
:jstutte, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 30

[Jens Stutte [:jstutte]]

Hi :nONoNonO, as one of the few recently active and involved here - is this still an issue?

Comment 31

[Onno Ekker [:nONoNonO UTC+1]]

Hi Jens,
I've tried to fiddle a bit with the userChrome settings, but am unable to reproduce the error, so it looks like this is fixed wfm...
Onno

Comment 32

[Onno Ekker [:nONoNonO UTC+1]]

Small addition: I didn't try to verify it on Windows XP.... I don't think Windows Classic theme is supported anymore?

Comment 33

[Jens Stutte [:jstutte]]

Thanks for verifying! I don't think we should spend effort on Windows XP here.