417512 - A lot of bugs in popup options/preferences menu

Status: RESOLVED FIXED

(Mozilla Localizations :: fa / Persian, defect)

Description

[Behnam Esfahbod [:zwnj]]

Attachment: Screenshot.png

Translated string is "اجازه دادن به واشوها برای %S", but there are parenthesis and a "P" in the menu!

Also needs some LRM/RLM marking.

Can be fixed for both Fx2.0 and Fx3.0.

Comment 1

[(no longer active)]

The "(P)" is the access key for this menu item.  I'll try to handle this for Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa l10n has not yet branched, so we can't work on Fx3.0 issues yet.

Comment 2

[Behnam Esfahbod [:zwnj]]

(In reply to comment #1)
> The "(P)" is the access key for this menu item.

Oops.

> I'll try to handle this for
> Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa
> l10n has not yet branched, so we can't work on Fx3.0 issues yet.

The reason it's not branched yet is to get these fixes in one place.  So you are going to fix it for Fx3.0 too. ;)

Comment 3

[(no longer active)]

Attachment: Patch (v1)

I'll be attaching a screenshot with the fix applied.

Comment 4

[(no longer active)]

Attachment: Screenshot of the fix

Comment 5

[Behnam Esfahbod [:zwnj]]

Comment on attachment 303314 [details] [diff] [review]
Patch (v1)

Thanks Ehsan.  Would you commit it yourself?

Comment 6

[(no longer active)]

Sure, as soon as I get CVS access.  I'll keep this on track.

Comment 7

[(no longer active)]

Checking in browser/chrome/browser/browser.dtd;
/l10n/l10n/fa/browser/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in browser/chrome/browser/browser.properties;
/l10n/l10n/fa/browser/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.3; previous revision: 1.2
done