Closed Bug 417512 Opened 12 years ago Closed 11 years ago

A lot of bugs in popup options/preferences menu

Categories

(Mozilla Localizations :: fa / Persian, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zwnj, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image Screenshot.png
Translated string is "اجازه دادن به واشوها برای %S", but there are parenthesis and a "P" in the menu!

Also needs some LRM/RLM marking.

Can be fixed for both Fx2.0 and Fx3.0.
The "(P)" is the access key for this menu item.  I'll try to handle this for Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa l10n has not yet branched, so we can't work on Fx3.0 issues yet.
OS: Linux → All
Hardware: PC → All
Assignee: bugs+behnam → ehsan.akhgari
Status: NEW → ASSIGNED
(In reply to comment #1)
> The "(P)" is the access key for this menu item.

Oops.

> I'll try to handle this for
> Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa
> l10n has not yet branched, so we can't work on Fx3.0 issues yet.

The reason it's not branched yet is to get these fixes in one place.  So you are going to fix it for Fx3.0 too. ;)
Attached patch Patch (v1)Splinter Review
I'll be attaching a screenshot with the fix applied.
Attachment #303314 - Flags: review?(bugs+behnam)
Attached image Screenshot of the fix
Comment on attachment 303314 [details] [diff] [review]
Patch (v1)

Thanks Ehsan.  Would you commit it yourself?
Attachment #303314 - Flags: review?(bugs+behnam) → review+
Sure, as soon as I get CVS access.  I'll keep this on track.
Blocks: fx35-l10n-fa
No longer blocks: Persian-Fx3.5
Checking in browser/chrome/browser/browser.dtd;
/l10n/l10n/fa/browser/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in browser/chrome/browser/browser.properties;
/l10n/l10n/fa/browser/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
No longer blocks: fx35-l10n-fa
Blocks: Persian
You need to log in before you can comment on or make changes to this bug.