A lot of bugs in popup options/preferences menu

RESOLVED FIXED

Status

Mozilla Localizations
fa / Persian
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: zwnj, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
Created attachment 303290 [details]
Screenshot.png

Translated string is "اجازه دادن به واشوها برای %S", but there are parenthesis and a "P" in the menu!

Also needs some LRM/RLM marking.

Can be fixed for both Fx2.0 and Fx3.0.
(Assignee)

Comment 1

11 years ago
The "(P)" is the access key for this menu item.  I'll try to handle this for Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa l10n has not yet branched, so we can't work on Fx3.0 issues yet.
OS: Linux → All
Hardware: PC → All
(Assignee)

Updated

11 years ago
Assignee: bugs+behnam → ehsan.akhgari
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

11 years ago
(In reply to comment #1)
> The "(P)" is the access key for this menu item.

Oops.

> I'll try to handle this for
> Fx2.0.  I'm not sure about the status of the Persian l10n on Fx3.0, as the fa
> l10n has not yet branched, so we can't work on Fx3.0 issues yet.

The reason it's not branched yet is to get these fixes in one place.  So you are going to fix it for Fx3.0 too. ;)
(Assignee)

Comment 3

11 years ago
Created attachment 303314 [details] [diff] [review]
Patch (v1)

I'll be attaching a screenshot with the fix applied.
Attachment #303314 - Flags: review?(bugs+behnam)
(Assignee)

Comment 4

11 years ago
Created attachment 303315 [details]
Screenshot of the fix
(Reporter)

Comment 5

11 years ago
Comment on attachment 303314 [details] [diff] [review]
Patch (v1)

Thanks Ehsan.  Would you commit it yourself?
Attachment #303314 - Flags: review?(bugs+behnam) → review+
(Assignee)

Comment 6

11 years ago
Sure, as soon as I get CVS access.  I'll keep this on track.
(Assignee)

Updated

10 years ago
Blocks: 415597
(Assignee)

Updated

10 years ago
No longer blocks: 412273
(Reporter)

Updated

10 years ago
Blocks: 412273
(Assignee)

Comment 7

10 years ago
Checking in browser/chrome/browser/browser.dtd;
/l10n/l10n/fa/browser/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in browser/chrome/browser/browser.properties;
/l10n/l10n/fa/browser/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
No longer blocks: 415597
(Assignee)

Updated

10 years ago
Blocks: 285718
You need to log in before you can comment on or make changes to this bug.