Closed
Bug 417543
Opened 17 years ago
Closed 17 years ago
bottom & left dashed/dotted outlines/borders are drawn solid
Categories
(Core :: Graphics, defect, P1)
Tracking
()
VERIFIED
FIXED
People
(Reporter: ryukbk, Assigned: vlad)
References
Details
(Keywords: regression, testcase)
Attachments
(5 files)
Screenshot on tab bar
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021409 Minefield/3.0b4pre ID:2008021409
In this test case, FF shows a different behavior from that of IE7 i.e. the underline of the hyperlink is always solid.
<html>
<head>
<style type="text/css">
<!--
a {
text-decoration: none;
}
a:link, a:visited {
border-bottom:1px black dotted;
}
a:hover, a:active {
border-bottom:1px black solid;
}
-->
</style>
</head>
<body>
<p>
This is a <a href="http://www.gnu.org/">test</a>.
</p>
</body>
</html>
|
||
Comment 1•17 years ago
|
||
I was still using yesterday's nightly and it worked. After updating to today's build it fails. So it just regressed.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-13+04%3A00%3A00&maxdate=2008-02-14+04%3A00%3A00&cvsroot=%2Fcvsroot
perhaps bug 416018
Keywords: regression
|
||
Comment 2•17 years ago
|
||
Works fine for me with a Mac build (updated 20 minutes ago).
Is this a CSS rule-matching issue or a border-drawing issue? You can find out by removing the :hover/:active rule, or by using colors instead of borders in both rules.
@RyuK
like this ?
http://forums.mozillazine.org/viewtopic.php?p=3255754#3255754
|
|
||
Comment 4•17 years ago
|
||
Yeah this looks like a border/focus drawing issue. Any bottom and left borders that are supposed to be dashed are drawn solid.
|
|
||
Comment 5•17 years ago
|
||
Outlines too.
|
|
||
Updated•17 years ago
|
Component: Style System (CSS) → GFX: Thebes
QA Contact: style-system → thebes
Summary: a:visited is interpreted as a:hover/a:active in CSS → bottom & left dashed outlines/borders are drawn solid
|
||
Comment 6•17 years ago
|
||
Both the outline and the border test case work correctly on my Mac build.
Component: GFX: Thebes → Style System (CSS)
|
|
||
Comment 7•17 years ago
|
||
Dotted borders are affected too.
Component: Style System (CSS) → GFX: Thebes
Summary: bottom & left dashed outlines/borders are drawn solid → bottom & left dashed/dotted outlines/borders are drawn solid
|
|
||
Comment 8•17 years ago
|
||
I confirmed pal-moz's regression range from mozillazine:
20080213_2221 ok
20080213_2256 broken
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1202970060&maxdate=1202972159
Blocks: 416018
|
|
||
Updated•17 years ago
|
Flags: blocking1.9?
|
Assignee | |
Comment 9•17 years ago
|
||
mmm. there was an optimization in there for dashed lines as part of the cairo upgrade, that may be it. I'll look/fix tomorrow.
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → vladimir
Flags: blocking1.9? → blocking1.9+
Priority: -- → P1
|
||
Comment 11•17 years ago
|
||
Screenshot of what I am seeing with Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9b4pre) Gecko/2008021504 Minefield/3.0b4pre ID:2008021504
|
|
||
Updated•17 years ago
|
OS: Windows XP → All
|
|
||
Updated•17 years ago
|
OS: All → Windows XP
|
||
Updated•17 years ago
|
OS: Windows XP → All
|
||
Comment 13•17 years ago
|
||
Check also attachment 303034 [details] of the bug 379303.
|
||
Comment 14•17 years ago
|
||
This bug is probably also the cause that the <acronym> tag is using a solid line instead of a dotted line.
|
||
Comment 15•17 years ago
|
||
I noticed that the line is painted using the dash pattern only if ctx->LineTo move the point from left to right or top to bottom. So I get the dash when switching the start/end for the bottom and left sides.
Next step would be to create a reduced cairo testcase. I'm using system-cairo with trunk version of today.
By the way, the "length" local variable in DrawDashedSide() seems to be unused.
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
|
||
Comment 16•17 years ago
|
||
I just tried with the in-tree cairo, and that's the same situation.
|
|
Assignee | |
Comment 17•17 years ago
|
||
Should be fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 18•17 years ago
|
||
verified Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9b4pre) Gecko/2008022005 Minefield/3.0b4pre ID:2008022005
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•