Closed Bug 419057 Opened 16 years ago Closed 16 years ago

Add support for querying by os and app version to search

Categories

(addons.mozilla.org Graveyard :: API, defect)

Product:
addons.mozilla.org Graveyard
Component:
API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: laura, Assigned: laura)

References

Details

Attachments

(2 files)

Adds support for passing these as optional parameters.
2.98 KB, patch
Details | Diff | Splinter Review
Adds support for version and platform to search
3.21 KB, patch
cpollett
: review+
Details | Diff | Splinter Review 
Allow users to search or query only for addons that match their OS and version criteria.
We don't do anything with them yet, but you can pass them in.
Patch committed to trunk in r10634.
Blocks: 417606
(In reply to comment #3)
> Is this a dupe? https://bugzilla.mozilla.org/show_bug.cgi?id=347202
> 

No, this is an API issue, nothing to do with the UI
Depends on: 430733
Target Milestone: 3.3 → 3.4.3

        Attachment #323458 -
        Flags: review?(cpollett)

    
    

    
  
Comment on attachment 323458 [details] [diff] [review]
Adds support for version and platform to search

Looks good.

        Attachment #323458 -
        Flags: review?(cpollett) → review+

    
    

    
  
Search part committed in r14505.

    
    

    
  
Opening a separate bug for recommended call.

Note: the search stuff depends on the code in  Advanced Search, bug 372841
Depends on: 372841
Summary: Add support for querying by os and app version to search and recommended calls → Add support for querying by os and app version to search

    
    

    
  
Needs to be backed out of 3.4.3.
Target Milestone: 3.4.3 → 3.4.4

    
  
Target Milestone: 3.4.4 → 3.4.5

    
    

    
  
Re-fixed in r16316.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

    
    

    
  
Laura - are there API queries via/with returned XML I can use to verify this bug?  Thanks!

    
    

    
  
Regression fixed in r16394.  Order of parameters to the underlying search function changed.

Sample URLs for verification:
/en-US/firefox/api/1.1/search/IETab/all/10/Linux/3.0
/en-US/firefox/api/1.1/search/IETab/all/10/WINNT/3.0



    
    

    
  
Verified FIXED:

https://services.addons.mozilla.org/en-US/firefox/api/1.1/search/piclens/all/10/Linux/3.0 erroneously returns PicLens (it's not available for Linux), when:

https://preview.addons.mozilla.org/en-US/firefox/api/1.1/search/piclens/all/10/Linux/3.0 only returns Cooliris Previews, which is.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: