Add support for querying by os and app version to search

VERIFIED FIXED in 3.4.5

Status

VERIFIED FIXED
11 years ago
3 years ago

People

(Reporter: laura, Assigned: laura)

Tracking

unspecified
3.4.5
Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Allow users to search or query only for addons that match their OS and version criteria.
(Assignee)

Comment 1

11 years ago
Created attachment 305022 [details] [diff] [review]
Adds support for passing these as optional parameters.

We don't do anything with them yet, but you can pass them in.
(Assignee)

Comment 2

11 years ago
Patch committed to trunk in r10634.

Comment 3

11 years ago
Is this a dupe? https://bugzilla.mozilla.org/show_bug.cgi?id=347202
(In reply to comment #3)
> Is this a dupe? https://bugzilla.mozilla.org/show_bug.cgi?id=347202
> 

No, this is an API issue, nothing to do with the UI
(Assignee)

Updated

11 years ago
Depends on: 430733
Target Milestone: 3.3 → 3.4.3
(Assignee)

Comment 5

11 years ago
Created attachment 323458 [details] [diff] [review]
Adds support for version and platform to search
Attachment #323458 - Flags: review?(cpollett)

Comment 6

11 years ago
Comment on attachment 323458 [details] [diff] [review]
Adds support for version and platform to search

Looks good.
Attachment #323458 - Flags: review?(cpollett) → review+
(Assignee)

Comment 7

11 years ago
Search part committed in r14505.
(Assignee)

Comment 8

11 years ago
Opening a separate bug for recommended call.

Note: the search stuff depends on the code in  Advanced Search, bug 372841
Depends on: 372841
Summary: Add support for querying by os and app version to search and recommended calls → Add support for querying by os and app version to search
(Assignee)

Comment 9

11 years ago
Needs to be backed out of 3.4.3.
Target Milestone: 3.4.3 → 3.4.4

Updated

11 years ago
Target Milestone: 3.4.4 → 3.4.5
(Assignee)

Comment 10

11 years ago
Re-fixed in r16316.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Laura - are there API queries via/with returned XML I can use to verify this bug?  Thanks!
(Assignee)

Comment 12

11 years ago
Regression fixed in r16394.  Order of parameters to the underlying search function changed.

Sample URLs for verification:
/en-US/firefox/api/1.1/search/IETab/all/10/Linux/3.0
/en-US/firefox/api/1.1/search/IETab/all/10/WINNT/3.0

Verified FIXED:

https://services.addons.mozilla.org/en-US/firefox/api/1.1/search/piclens/all/10/Linux/3.0 erroneously returns PicLens (it's not available for Linux), when:

https://preview.addons.mozilla.org/en-US/firefox/api/1.1/search/piclens/all/10/Linux/3.0 only returns Cooliris Previews, which is.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.