Closed Bug 419463 Opened 18 years ago Closed 16 years ago

unresponsive script warning dialog has reversed icons

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- .7-fixed

People

(Reporter: mcepl, Assigned: sylvain.pasche)

References

(
URL
)

Details

Attachments

(2 files)

FF2 screenshot of the dialog
16.63 KB, image/png
Details
patch
1.31 KB, patch
jst
: review+
jst
: superreview+
dveditz
: approval1.9.2.7+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; cs; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; cs; rv:1.9b3) Gecko/2008020513 Firefox/3.0b3 Originally from the Red Hat Bugzilla: In the "Unresponsive script" dialog, "continue" should be labelled as the "arrow" and "stop script" be the "x" (currently, "stop script" is labelled with arrow, and "continue" has nothing). Reproducible: Always Steps to Reproduce: 1. see above 2. 3. Actual Results: see the image attached to this bug Expected Results: Continue should be labelled with arrow, and Stop script with Cross or something.
Firefox 3 screenshot: see attachment 323426 [details]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
Component: General → Theme
QA Contact: general → theme
Component: Theme → DOM
Product: Firefox → Core
QA Contact: theme → general
Summary: firefox script warning dialog has icons reversed → unresponsive script warning dialog has reversed icons
Ubuntu Bug: https://bugs.launchpad.net/bugs/127960 Still a problem in Firefox 3.5 and 3.7 (trunk)
Component: DOM → Themes
Product: Core → Toolkit
QA Contact: general → themes
Component: Themes → DOM
Product: Toolkit → Core
QA Contact: themes → general
Attached patch patch — — Splinter Review
nsIPrompt assumes that the button at position 0 has an ok/yes icon and the one at position 1 cancel/no. That's only meaningful for Linux as other OSes don't show icons there.
Assignee: nobody → sylvain.pasche
Status: NEW → ASSIGNED
Attachment #395217 - Flags: review?(jst)
Attachment #395217 - Flags: superreview+
Attachment #395217 - Flags: review?(jst)
Attachment #395217 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ba9cb47432a6
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Verified fixed on trunk with build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091026 Minefield/3.7a1pre on Linux Ubuntu 9.04 32bit.
Status: RESOLVED → VERIFIED
Attachment #395217 - Flags: approval1.9.2.2?
Attachment #395217 - Flags: approval1.9.2.2? → approval1.9.2.3?
Comment on attachment 395217 [details] [diff] [review] patch a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we are still working on 1.9.2.4 on the relbranch
Attachment #395217 - Flags: approval1.9.2.4? → approval1.9.2.5+
If someone could land it on branch for me, that would be terrific.
Keywords: checkin-needed
Attachment #395217 - Flags: approval1.9.2.5+ → approval1.9.2.6+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: