419772 - [proto] Land Proto 0.12 changes

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Kevin Gerich]

Proto theme 0.12 update includes UI polish, focus rings, new icons, keyhole shape back and forward buttons.

Update addresses bug 413411, bug 414425, bug 414445, bug 414496, bug 414502, bug 414665, bug 415000, bug 415957, bug 417844

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Kevin, I know you said you were still dropping images, any ETA? We're freezing tonight at 11:59 EST, but I'd take this during the baking period since you guys have proven rock solid at testing, etc.

Comment 2

[Kevin Gerich]

Attachment: Omnibus theme update patch

The patch is available as a stand alone theme here https://addons.mozilla.org/en-US/firefox/addon/6050

Comment 3

[Kevin Gerich]

(In reply to comment #1)
> Kevin, I know you said you were still dropping images, any ETA? We're freezing
> tonight at 11:59 EST, but I'd take this during the baking period since you guys
> have proven rock solid at testing, etc.

Mike, I wanted to get the code changes reviewed sooner rather than later. I'm also working on purely image updates which I should be able to land with this patch. I'll post a new version of Proto once I have all the images integrated .. that should happen in about an hour or so.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 305910 [details] [diff] [review]
Omnibus theme update patch

>Index: browser/themes/pinstripe/browser/browser.css
> .tabbrowser-tab[selected="true"]:focus > .tab-image-middle > .tab-text-stack > .tab-text {
>-  outline: 1px solid -moz-mac-focusring;
>+  outline: 2px solid #4F8EC9;

>-#identity-box:focus {
>-  outline: 1.4pt solid -moz-mac-focusring;
>+#identity-box:focus > hbox > #page-proxy-deck {
>+  outline: 2px solid #4F8EC9;
I really wish we didn't have to put the focus effect in the images :(

>+#urlbar[focused="true"] #identity-box {
child selector here and on the similar selectors that follow
 
>+#urlbar[focused="true"] #identity-icon-label {
>+    background-image: url("chrome://browser/skin/urlbar/startcap-secure-end-focused.png");
#urlbar[focused="true"] > #identity-box.verifiedDomain > hbox > #identity-icon-label

>Index: browser/themes/pinstripe/browser/searchbar.css
>+.searchbar-textbox[focused="true"] .searchbar-engine-button {
child selector

>+.searchbar-textbox[focused="true"] .search-go-container {
ditto

>Index: toolkit/themes/pinstripe/global/jar.mn
>++  skin/classic/global/icons/button-gradient.png                	  (icons/button-gradient.png)
nit: got some tabs mixed in here

Looks good, r=me.

Comment 5

[Kevin Gerich]

Comment on attachment 305910 [details] [diff] [review]
Omnibus theme update patch

Proto has been updated to 0.12.2 with Stephen's latest batch of icons.

Comment 6

[Reed Loden [:reed]]

Comment on attachment 305910 [details] [diff] [review]
Omnibus theme update patch

This is a blocker. No approval is needed, as long as it is landed before the freeze.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305910 [details] [diff] [review]
Omnibus theme update patch

ui-r=beltzner

Comment 8

[Kevin Gerich]

Landed. Thanks for the reviews!

Checking in browser/themes/pinstripe/browser/Secure-statusbar-broken.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/Secure-statusbar-broken.png,v  <--  Secure-statusbar-broken.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/Secure-statusbar.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/Secure-statusbar.png,v  <--  Secure-statusbar.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/Toolbar.png,v  <--  Toolbar.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.129; previous revision: 1.128
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/contextDialogBackground.png,v
done
Checking in browser/themes/pinstripe/browser/contextDialogBackground.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/contextDialogBackground.png,v  <--  contextDialogBackground.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/expander-round.png,v
done
Checking in browser/themes/pinstripe/browser/expander-round.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/expander-round.png,v  <--  expander-round.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/home.png,v
done
Checking in browser/themes/pinstripe/browser/home.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/home.png,v  <--  home.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/identity.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/identity.png,v  <--  identity.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.75; previous revision: 1.74
done
Checking in browser/themes/pinstripe/browser/searchbar.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/searchbar.css,v  <--  searchbar.css
new revision: 1.20; previous revision: 1.19
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/places/back-forward.png,v
done
Checking in browser/themes/pinstripe/browser/places/back-forward.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/back-forward.png,v  <--  back-forward.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/places/organizer.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/organizer.css,v  <--  organizer.css
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/pinstripe/browser/places/pageStarred.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/pageStarred.png,v  <--  pageStarred.png
new revision: 1.3; previous revision: 1.2
done
Checking in browser/themes/pinstripe/browser/places/query.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/query.png,v  <--  query.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/pinstripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.4; previous revision: 1.3
done
Checking in browser/themes/pinstripe/browser/places/tag.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/tag.png,v  <--  tag.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/endcap-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/endcap-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/endcap-focused.png,v  <--  endcap-focused.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/endcap.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/endcap.png,v  <--  endcap.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-active.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-active.png,v  <--  startcap-active.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-focused.png,v  <--  startcap-focused.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-active.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-active.png,v  <--  startcap-secure-active.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-end-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end-focused.png,v  <--  startcap-secure-end-focused.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-end.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end.png,v  <--  startcap-secure-end.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-mid-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid-focused.png,v  <--  startcap-secure-mid-focused.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-mid.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid.png,v  <--  startcap-secure-mid.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-start-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start-focused.png,v  <--  startcap-secure-start-focused.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure-start.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start.png,v  <--  startcap-secure-start.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-secure.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure.png,v  <--  startcap-secure.png
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-focused.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-verified-end-focused.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-focused.png,v  <--  startcap-verified-end-focused.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-invalid.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-verified-end-invalid.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-invalid.png,v  <--  startcap-verified-end-invalid.png
initial revision: 1.1
done
Checking in browser/themes/pinstripe/browser/urlbar/startcap-verified-end.png;
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/textfield-mid-secure.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/textfield-mid-secure.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/textfield-mid-secure.png,v  <--  textfield-mid-secure.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/textfield-mid.png,v
done
Checking in browser/themes/pinstripe/browser/urlbar/textfield-mid.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/urlbar/textfield-mid.png,v  <--  textfield-mid.png
initial revision: 1.1
done
Checking in toolkit/themes/pinstripe/global/findBar.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/findBar.css,v  <--  findBar.css
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/themes/pinstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.39; previous revision: 1.38
done
Checking in toolkit/themes/pinstripe/global/textbox.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/textbox.css,v  <--  textbox.css
new revision: 1.9; previous revision: 1.8
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/button-gradient-active.png,v
done
Checking in toolkit/themes/pinstripe/global/icons/button-gradient-active.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/button-gradient-active.png,v  <--  button-gradient-active.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/button-gradient.png,v
done
Checking in toolkit/themes/pinstripe/global/icons/button-gradient.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/button-gradient.png,v  <--  button-gradient.png
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/menulist-dropmarker.png,v
done
Checking in toolkit/themes/pinstripe/global/icons/menulist-dropmarker.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/icons/menulist-dropmarker.png,v  <--  menulist-dropmarker.png
initial revision: 1.1
done
Checking in toolkit/themes/pinstripe/mozapps/downloads/buttons.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/buttons.png,v  <--  buttons.png
new revision: 1.5; previous revision: 1.4
done
Checking in toolkit/themes/pinstripe/mozapps/places/tagContainerIcon.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/places/tagContainerIcon.png,v  <--  tagContainerIcon.png
new revision: 1.3; previous revision: 1.2
done

Comment 9

[Myk Melez [:myk] [@mykmelez]]

This was checked in on a tree that has been closed for half an hour.

Comment 10

[Kevin Gerich]

damn. so, do I back it out?

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Normally I would say yes, but in this case I'll let it slide, considering it's a b4 blocker, and we'd just turn around and take it again after reopening the tree anyway.

Just make sure next time you check tinderbox right before checking in to make sure no boxes are burning or orange (unless the orange is noted in the comments and checkins are explicitly allowed on it) and the tree is open.  Also, please be available on IRC after the checkin until the builds that incorporate your changes cycle green, so we can chat about and resolve any issues that come up.

Comment 12

[Kevin Gerich]

Thanks. Next time I'll be more careful. Sorry if this caused anyone problems.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Are you going to mark the relevant bugs from comment 0 fixed, given that this has landed?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4 ID:2008030317.

Comment 15

[Boris Zbarsky [:bzbarsky]]

This checkin breaks copying from the url bar in some cases.  See bug 419772.

Comment 16

[Johnathan Nightingale [:johnath]]

(In reply to comment #15)
> This checkin breaks copying from the url bar in some cases.  See bug 419772.

I bet he meant bug 486395