420529 - using a murrine engine gtk control theme under gnome/linux will break rendering of several drop down menus (preferences, bookmark panel, place organizer)

Status: RESOLVED INACTIVE

(Core :: Widget: Gtk, defect, P5)

Description

[Mathieu Pellerin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008030114 Minefield/3.0b4pre
Build Identifier: 

Firefox doesn't seem to handle popups/menus which have non-default padding and/or added visual borders defined by certain gtk theme under gnome. For example, murrine based themes have a nice left side decorative border to popup but that ain't playing nice with the fox.

Since Ubuntu art team have decided to go on and switch their default theme using the murrine engine, that visual glitch will become part of many users' everyday experience.

A lot of work has been done in the past months to raise the bar of firefox's visual integration with linux platform and it really paid off. In terms of big in-your-face visual problems, this menu misalignment seems to be the last one.

Reproducible: Always

Steps to Reproduce:
1. Switch to a murrine based theme under gnome
2. Launch the fox
3. Open a popup menu
Actual Results:  
Icons are partly overlapping decorative border setup by theme, item highlights are also misaligned

Expected Results:  
Menus are identical to other applications under gnome

Comment 1

[Reed Loden [:reed]]

I know the author of the Murrine engine has a Bugzilla account, but I can't remember it. Can somebody CC him?

Comment 2

[Michael Ventnor]

Can you please attach a screenshot?

Comment 3

[Andrea Cimitan]

Hi guys, I'm in.

Screeenshot pls. =)

Comment 4

[Ian Spence]

Before attacking a screenshot, could you update to today's build?  You reported a visual bug on the day of the great theme disaster, so it might not even be a problem.  I've tested it with every murrine theme I have, and even updated to the trunk for the engine to see this, but I can't reproduce.

Comment 5

[Mathieu Pellerin]

can't make a screenshot, somehow it seems print screen button ain't working will a popup menu open is open in firefox.

that being said, you can see the 1px overlap between border and site favicon if you bookmark boingboing. it seems the overlap will happen if the favicon is 32px width.

/me must admit reporting bug while using broken build due to areo change and now that I'm back on a fixed build, issue doesn't seem that bad :o) 

Comment 6

[Benjamin Berg]

You can use 'gnome-screenshot --delay 5' to make a screenshot of the entire screen. "print screen" does not work because the menu has a grab on all input.

Comment 7

[Julien "_FrnchFrgg_" RIVAUD]

Isn't this bug a dupe of bug 420066 ?

Comment 8

[Ian Spence]

We need to wait for a screenshot to see.  bug 420066 is about padding in the menu. This bug is _apparently_ about padding of the menu items inside the menu

Comment 9

[Julien "_FrnchFrgg_" RIVAUD]

Ian: then this bug is a dupe of the "gtk doesn't obey vertical menu item padding" bug (and that one should be morphed to not only be about vertical padding).

As a side note, how a screenshot will make you able to tell if the missing left padding is on the menu (more probable) or on each menu item (and separator) ?

Comment 10

[Julien "_FrnchFrgg_" RIVAUD]

The vertical menuitem padding is Bug 407069

Comment 11

[Ian Spence]

Assuming we had a hovered item, if the icon _and_ menuitem background overlapped the left, then it's a menu issue. If the icon overlap extends out of the menuitem background (which I've seen before), then it's a menuitem issue.

Bug 407069 should be marked as a dupe of bug 420066

Comment 12

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Screenshot

The way the screenshot is, it's certainly a menuitem issue. That is the left bar seems to be drawn piecewise by each menuitem.

Comment 13

[Julien "_FrnchFrgg_" RIVAUD]

Ian, I thought that bug 407069 was about menuitem vertical padding, and bug 420066 about the whole menu padding ?

Comment 14

[Mathieu Pellerin]

Attachment: favicon touches menu highlight border

Comment 15

[Mathieu Pellerin]

Attachment: broken menus under murrine with place organizer, bookmark panel and option window

so it appears firefox still has _real_ "broken" menus (i.e. not respecting padding defined by gnome themes) in several places using the murrine engine:

* all drop down options in the preference window
* drop downs from search panel in place organizer
* the brand new bookmark panel also has broken drop down menus

with most menus now rendering correctly, these remaining issues are doubly visible :o)

Comment 16

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 17

[Sylvestre Ledru [:Sylvestre]]

no activity for years, closing.
Feel free to reopen if this is still occurring