420669 - [10.5] Command+Delete does not delete to the line beginning (deletes all text instead)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Louise]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008030204 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008030204 Minefield/3.0b4pre

Command+Delete should delete from the cursor to the beginning of the line.

Reproducible: Always

Steps to Reproduce:
1.write anything in text area, search box, location bar
2.hit Command+delete
3.
Actual Results:  
nothing happens

Expected Results:  
characters between the cursor and the beginning of the line should be deleted.

Comment 1

[Wes Campaigne]

Why? I'm not saying this is a bad idea -- it's a logical shortcut, and it's definitely present in a number of OS X apps -- but it's not a default shortcut. Command + delete/backspace does NOT do this (or anything, afaict) in Firefox 2, or Safari, or most Cocoa apps. (On Tiger, at least. Has this changed in Leopard?)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming; this is a feature of the NSText*, at least on Mac OS X 10.5 (try Safari, Stickies, TextEdit).  I'm not sure if it was added in 10.4 or 10.5, but we may as well support it.

I thought this was just a missing binding in platformHTMLBindings.xml, but after adding the appropriate binding (next to the binding for opt-delete, wherever the latter occurs; see bug 285529 for that fix), I still didn't have this working :-(

Something else must be interfering here.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Smokey, this was definitely added in 10.5. I'm not able to get this shortcut working under 10.4 in each of the Apple applications. It only works for the Finder where it deletes the selected file(s). Updating summary accordingly.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: patch to platformHTMLBindings.xml (not working)

Just so this is out of my tree and not lost, here's the non-working patch to content/xbl/builtin/mac/platformHTMLBindings.xml that should have fixed this.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Note that a new bug's (bug 468022) been opened about problems (Google-specific) with Option-Delete ... though it's probably not related.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix

I happened to think of this bug today by accident; this is really stupid, and I wish I'd realized it nearly three years ago: Delete is VK_BACK, not VK_DELETE.

This patch fixes this bug--but, really, someone should just fix bug 282097 and eliminate the need to keep patching in these things haphazardly, one-by-one :P

Comment 10

[Matt B]

This is still an issue in 17.0.6 on 10.8.3.

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Welcome to the world of monbento, the brainchild of the French entrepreneur Emilie 

         •Our story
         Launched in 2009 & booming ever since, what are the reasons behind our modern success story?

         •Our brand
         Relaxed, practical, innovative and chic, express yourself & accessorize your bento.
         Take monbento where you want when you want - it's as simple as style, choice and pleasure!bobbobbobbob

         •Our nomad cutlery
          A Western take on the bento box experience, monbento nomad cutlery will revolutionize your take-away meals!

                   Made of dishwasher-safe stainless steel, the 3-piece set can be easily stowed between the intermediary and upper lids of monbento boxes.
                   Suitable for use with MB Original, these sturdy cutlery sets are a convenient addition for all monbento users.

Now available from our creative minds to your home - Come & experience our food revolution!

Cutlery sold - 1 set grey

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Ignore the comment above...  That's the last time I test editing commands in a bug comment box.  The dependency change is correct at least!

Comment 13

[Erik Rose [:erik][:erikrose]]

In 2015-01-05 Nightly, command-delete now empties the whole field, regardless of where the caret is. For example, if you type this into the search box, with the caret positioned as indicated...

    hello there| world

...and hit command-delete, all 3 words go away. Only "hello there" should.

Comment 14

[Nickolay_Ponomarev]

To clarify: when bug 282097 was fixed in Firefox 25 (sometime in 2013), the Command+Delete shortcut got mapped to |cmd_deleteToBeginningOfLine|: http://hg.mozilla.org/mozilla-central/rev/4bb128a0bcef#l3.69

Before this change it had no effect, after the change it started clearing the whole text field, as cmd_deleteToBeginningOfLine had this bug for a long time (bug 426246). Fixing the binding to delete to the beginning of the line instead of clearing the whole textbox must happen in bug 426246.

Changing the summary to reflect the current status.

Comment 18

[basnijholt]

Is there a workaround? Some extension or something?

I can understand why people don't see this as a priority. If you have been working with this bug present (for ten years now) then I am sure you don't depend on the usage of `command + delete`, however, as a Chrome user that tries to switch, this is highly annoying and one of the reasons I keep going back to Chrome.

Comment 19

[Markus Stange [:mstange]]

I've attached a fix to bug 426246, which, as far as I can tell, is the only part of this bug that remains.
Here's a try build with that fix included: https://taskcluster-artifacts.net/SRA-ZO3QTyO9DXirZlGjEQ/0/public/build/target.dmg

Can you test that build and report whether it works the way you expect?

Comment 20

[basnijholt]

Wow, this is what I love about open-source!

I write on a 10-year-old issue that kept bugging me for years, 8 hours later it's fixed!

I can confirm that it works the way I expect. 

Thanks a lot for the quick fix 

Comment 21

[Markus Stange [:mstange]]

Bug 426246 has landed, so this should be fixed on Nightly now.

Comment 22

[Phil Freo]

Thank you!!!

Comment 23

[Ken Harris]

I just saw the notification email about this, so I tried it. Not sure if it's in scope, but I see two ways it still doesn't act quite the same as other Mac text areas:

• After undo, Firefox leaves the cursor at the end of the re-added text. Other Mac applications leave the re-added text selected.

• Command-delete on an empty line in Firefox does nothing. In other Mac applications, it deletes the previous (newline) character.

Comment 24

[Firefox Bug Husbandry Bot]

Reverting spam.