420770 - File | Open saved message doesn't work anymore

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

File | Open saved message doesn't work anymore on trunk, when you try it nothing at all happens. No errors in the error console either.

Comment 1

[Phil Ringnalda (:philor)]

Not that it helps my understanding, but there's an error in my (2008030303/Win) console:

Error: uncaught exception: [Exception... "Cannot modify properties of a WrappedNative"  nsresult: "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame :: chrome://messenger/content/mailWindowOverlay.js :: MsgOpenFromFile :: line 1676"  data: no]

Comment 2

[Phil Ringnalda (:philor)]

2008022603 works, 2008022703 fails. Wonder whether I can blame timeless' filepicker patch...

Comment 3

[[e-mail]]

Attachment: Suite patch

Comment 4

[Phil Ringnalda (:philor)]

Attachment: Tbird patch [checked in]

Oh, sure, make me look like the patch copycat, just because I was trying to fix you too and my suite build died and I didn't want to stay up while it built again ;)

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 307268 [details] [diff] [review]
Tbird patch [checked in]

Works fine, thx! r=me

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 307268 [details] [diff] [review]
Tbird patch [checked in]

mail/base/content/mailWindowOverlay.js 1.188

Comment 7

[Phil Ringnalda (:philor)]

ha Ha! I got mine in first, though, so now you have to own the bug!

Comment 8

[Karsten Düsterloh]

Comment on attachment 307200 [details] [diff] [review]
Suite patch

>-  var uri = fp.fileURL;
>+  var uri = fp.fileURL.QueryInterface(Components.interfaces.nsIURL);

Actually, I find this rather worrisome.
So, if fp.fileURL returns an nsIURL (like it even claims in <http://mxr.mozilla.org/seamonkey/source/widget/public/nsIFilePicker.idl#136>!), then why doesn't the IDL define it as such? nsIURL is even derived from nsIURI!
Why don't we just change the interface to return the right type?

Comment 9

[[e-mail]]

Fix checked in.