42080 - DND for multiple selection not working in bookmarks

Status: VERIFIED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[hirata masakazu]

1)Selected items can not be moved by drag and drop. I do not know if there is 
any way to move them. 
2)The scroll bar disappears when item is selected.
2000060708

Comment 1

[hirata masakazu]

Well, the errors seem to occur when memory is tight.  It is not 100% reproducible 
in every launch.  Maybe Inv.

Comment 2

[Blake Ross]

these need to be split; they're entirely different

Comment 3

[hirata masakazu]

OK.  Please let me make this one as;
Multiple selection not being moved by drag and drop.
Multiple selection in the Manage Bookmarks are not moved by drag and drop.  Only 
the item where mouse click took place gets moved.  This is very reproducible in 
2000060908-M17.  I will file another one for the scroll bar disappearance.

Comment 4

[Henri Sivonen (:hsivonen)]

Confirmed in build 2000060908. Simplifying summary.

Comment 5

[Henri Sivonen (:hsivonen)]

Confirmed in build 2000060908. Simplifying summary.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Confirmed in Linux 2000-06-30-08.  Changing OS to "all".  The following steps
reproduce this bug:

1. Open Mozilla with a new profile, and select Bookmarks -> Edit Bookmarks...
2. Click the "Search" folder to select it.  Hold down the shift key and click
"Computers and Internet" underneath it so that both of them are selected.
3. While still holding down the shift key (probably not necessary to reproduce
the bug), drag and drop the two folders to a different location in the bookmarks
tree.

Actual results: only one bookmark folder moves
Expected results: both bookmark folders move
Builds tested on: Linux 2000-06-30-08, Linux M16

Additional Information:

This doesn't just happen in the bookmarks window; it also happens in mail-news
when dragging and dropping multiple mail messages to a different folder.

If I try this test case with my own profile (with tons of unfiled bookmarks)
instead of a new profile, 2000-06-30-08 consistently crashes, but M16 just moves
individual bookmarks as with a new profile.

My guess is this is a problem with the new tree code built on top of the grid
widget, so I suggest transferring it to the "XP Toolkit/Widgets: Trees" component.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Sorry for the spam.  I forgot to add myself to the CC: list.  And, while I am at
it, correcting the "Platform" field as well.

Comment 8

[Claudius Gayle]

adding jrgm to cc, maybe he is already aware of an existing toolkit bug about multiple selection in trees ot working w/ D&D.

Comment 9

[Chris McAfee]

m20, slamm will be back soon.

Comment 10

[xiitone]

Also, when managing bookmarks, multiple selections are not deleted, only the
last bookmark selected.

Comment 11

[kris]

That multiple delete bug is probably the same as #43891.

Comment 12

[Claudius Gayle]

an impromptu chat with pinkerton has led me to believe that the tree widget supports this functionality and it's now up to 
individual component owners to tweak their D&D code - so this bug stays with Slamm. (pink also says this isn't going to work on 
Linux).
...hours later...
I tried to test this with the mail tree and all I ever got was the International Symbol for 'No' if I tried to drag to a different folder, 
that doesn't seem right

Comment 13

[Mike Pinkerton (not reading bugmail)]

claudius, that mail bug is 48250.

Comment 14

[Jesse Ruderman]

*** Bug 53407 has been marked as a duplicate of this bug. ***

Comment 15

[Adam]

*** Bug 55768 has been marked as a duplicate of this bug. ***

Comment 16

[Koike Kazuhiko]

Crash in xpcom.dll.

Select multiple bookmarks and drag them to the bottom of bookmark
manager window. Bookmark list begins to scroll and crash happens.

My build is 2000101220/Win32.

Comment 17

[Karl Ove Hufthammer]

Comment 18

[Andriy Palamarchuk]

Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001108
For me drag-and-drop does not work at all for "Manage Bookmarks" window.
Bookmarks in root folder can be "dragged", cursor is changed while the operation,
but drop does not work.
I can't even "pick up" a bookmark in a folder (not in the root).

Comment 19

[R.K.Aa.]

*** Bug 60288 has been marked as a duplicate of this bug. ***

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 64762 has been marked as a duplicate of this bug. ***

Comment 21

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is not a Netscape beta stopper.

Comment 22

[Marcia Knous [:marcia]]

Netscape Nav Triage Team *correction* - sorry, this was supposed to be nsbeta1. 
ben, can you please comment on this?

Comment 23

[David Hyatt]

fix checked in. 

Comment 24

[Koike Kazuhiko]

Drag and drop of multiple bookmarks doesn't work
in sidebar bookmarks. Not completely fixed.

Build: 2001020520/Win98

Comment 25

[Ben Goodger (use ben at mozilla dot org for email)]

Bookmarks sidebar panel is .9 work. 

Comment 26

[hirata masakazu]

This is broken again in 2001021204 Mac build.
Actually, even a single item can not be moved by DnD.

Comment 27

[Paul Chen]

Can people test a more recent build? This looks like it works for manage
bookmarks window under win2k using 2001-02-27-05 build.

Comment 28

[Paul Chen]

Also works under a mac build from today (01-02-28) although it doesn't exactly
LOOK pretty.

Comment 29

[Stephen Rasku]

Tested on Linux build 2001022808

In the "Manage bookmarks" window I can move multiple bookmarks at a time.  In
the sidebar, I can't.

Comment 30

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 31

[Ben Goodger (use ben at mozilla dot org for email)]

My latest checkin should make this should work, but the bug is WONTFIX now 
because the bookmark sidebar panel uses a single click model instead of a double 
click one so multiple selection is out. 

Comment 32

[Claudius Gayle]

hrmpf. VERIFIED Wontfix.

Comment 33

[Claudius Gayle]

sigh. drag selection(create a rectangular box around selected items) is the obvious complement
in the one-click model but I guess we'll never have that as long as selecting an item in a tree selects
the whole damn row i.e. there is no whitespace within which to draw the box.

Comment 34

[hirata masakazu]

"drag-based multiple selection in trees" bug 48912.
removing the target milestone 0.8.1.
So, we should make this dependent on 48912?

Comment 35

[Mike Pinkerton (not reading bugmail)]

outliner should fix that eventually!!! hyatt and i want to do it.

Comment 36

[hirata masakazu]

Reopening as the original proble with bookmarks manager.
see the description of 2000-06-09 21:16

Comment 37

[Jon Granrose]

SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building.  please
update the target milestone so we can get a good idea of what's left for 0.9.1.

Comment 38

[Andrew Thompson]

This definately doesn't work in build 20001050915.

To be precise, because it looks like this bug has some "history" if I do

Bookmarks->Manage Bookmarks
Select 2 or more bookmarks
Drag them to another folder in the Bookmark Manager Window
The first is moved, the rest are not.

Ben asked us to help him triage on IRC last night therefore -> 0.9.2

Comment 39

[Paul Chen]

Ben, this is the your looping over the selection length which is dynamic. Taking 
this for 0.9.2

Comment 40

[Paul Chen]

Hmmm, using a linux build from a pull started about 1:30pm today (05/15/01),
multilple selection DND is working. Odd.

Can anyone else reproduce this with a current build?

Comment 41

[Stephen Rasku]

Multiple DND is working for me on Linux build 2001051708.

Comment 42

[Koike Kazuhiko]

worksforme on Linux and Win32 builds.

Comment 43

[hirata masakazu]

WFM on 2001052508 build for Mac, too. Together with W2k and Linux, I think I
should resolve this as WFM.

Comment 44

[Claudius Gayle]

VERIFIED WFM with 2001053108 builds on all platforms