421187 - add quick search for attachment file name

Status: NEW

(Thunderbird :: Search, enhancement)

Description

[Khanban]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.12) Gecko/20080203 SUSE/2.0.0.12-0.1 Firefox/2.0.0.12
Build Identifier: 

There are situations when you want to search for email with specific recipient or with specific attachments. It is good to add these two search items to the search field on the toolbar.


Reproducible: Always

Comment 1

[Magnus Melin [:mkmelin]]

You can do that kind of searches from Edit | Find | Search messages... 
But not from the quick search bar. 

Comment 2

[Wayne Mery (:wsmwk)]

do you mean by attachment *name*?
(recipient is already works.)

Comment 3

[Khanban]

Yes, attachment name would do.

Comment 4

[Wayne Mery (:wsmwk)]

attachment search is not a dupe as far as I can tell

recipient search is bug 376108

Comment 5

[Ashok]

Will be great if the new gloda based search can search based on attachment Name.

Comment 6

[Thomas D. (:thomas8)]

Certainly, searching for parts of attachment file names that we remember makes a lot of sense. And Wayne's comment 4 says it's not a dupe. So it's a valid RFE.
Albeit it needs visions for the UI -> uiwanted

I imagine this might be implemented as an optional button available through toolbar customization of secondary quick filter bar (which isn't customizable yet...). Similarly, there should be an optional Tags button to include tags into quickfiltering (via typing, not clicking).

Comment 7

[Thomas D. (:thomas8)]

There are several related bugs, but no dupes as far as I can see.

Most of them are about Tools > Message Filters, so be on your guard not to confuse them with quick filtering in the message pane.

Bug 83969 - Ability to search for "Has Attachments" (which I just moved to SeaMonkey, as TB can do this everywhere except in advanced "search messages" of newserver accounts)
Bug 105169 - Filter for Attachments
Bug 224392 - Add ability to filter by attachment name (extension)
(can't tell the difference between the last two)
Bug 224183 - Attachment email message headers not searchable

Comment 9

[Joerg Starkmuth]

It should be rather easy to add "Attachment name is/contains" to the selectable search criteria under Edit | Find | Search messages. That would require no GUI change. I think it's less important to add this function to the toolbar (or that could be a subsequent step).

Comment 11

[Jorg K (CEST = GMT+2)]

For attached messages it would also make sense to search their headers.

BTW, bug 439143 had a better description: mpossibility to research using as criteria mail's attachment name or type/extension.

Comment 13

[chrizilla]

(In reply to comment #11)

For attached messages it would also make sense to search their headers.

This would be bug 1464769: "Can't search headers of attached messages with body search any more"

Comment 14

[ISHIKAWA, Chiaki]

(In reply to Thomas D. (:thomas8) from comment #7)

There are several related bugs, but no dupes as far as I can see.

Most of them are about Tools > Message Filters, so be on your guard not to
confuse them with quick filtering in the message pane.

Bug 83969 - Ability to search for "Has Attachments" (which I just moved to
SeaMonkey, as TB can do this everywhere except in advanced "search messages"
of newserver accounts)
Bug 105169 - Filter for Attachments
Bug 224392 - Add ability to filter by attachment name (extension)
(can't tell the difference between the last two)
Bug 224183 - Attachment email message headers not searchable

This is 15 years old?!

I wish I can search for the name of the attachment as in "the name contains a string "xyz", etc.
If we can do regular expression search with ignoring case, that would be wonderful, but that can wait.
Just having this feature will be very nice (the filename contains a string).
Anyone?
Where do I start to modify the search code?
(Yes, we need to decode the mime-encoded filename or something, but that would be doable.)

Comment 15

[Magnus Melin [:mkmelin]]

I think you'd be looking at handling it around https://searchfox.org/comm-central/rev/9416f10bc39a7eb7ce47be497579b1d28e612a9a/mailnews/search/src/nsMsgBodyHandler.cpp#178
Handling ascii cases might be not too hard with a bit of work but for encoded cases...

Comment 16

[ISHIKAWA, Chiaki]

(In reply to Magnus Melin [:mkmelin] from comment #15)

I think you'd be looking at handling it around https://searchfox.org/comm-central/rev/9416f10bc39a7eb7ce47be497579b1d28e612a9a/mailnews/search/src/nsMsgBodyHandler.cpp#178
Handling ascii cases might be not too hard with a bit of work but for encoded cases...

Thank you, Magnus.
I will take a look and see how far I can go.

The above code is at the lowest level to grok attachment header lines, etc.

Where do the search invoked from the JS side.
I mean where I would add, say, "attachment filename conttains" (and specify a string) from the search messages menu.

I hope I can get a crude first prototype that works with ASCII only this summer.

Stay tuned, but don't hold your breath. The heat this year is really consuming people including myself.