Closed Bug 422638 Opened 18 years ago Closed 17 years ago

Favicon conversion issues

Categories

(Mozilla Labs :: Prism, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: matthew.gertner)

References

Details

Attachments

(1 file)

I'm using the Prism extension, and when I use "convert website to application", and then select a .ico file as the icon using "Choose Image...", the dialog doesn't do anything when I click ok. Apparently hitting enter gives me this error in the console: Error: uncaught exception: [Exception... "Component returned failure code: 0x80540006 [imgITools.decodeImageData]" nsresult: "0x80540006 (<unknown>)" location: "JS frame :: file:///c:/profiles/trunk/extensions/refractor@developer.mozilla.org/modules/ImageUtils.jsm :: anonymous :: line 49" data: no]
Assignee: nobody → matthew
That nsresult is NS_IMAGELIB_ERROR_NO_ENCODER, which means the MIME type returned by the ImageUtils.getMimeTypeFromExtension call in useFile (install-shortcut.js) is wacky. I had that problem on Linux just now, because the /etc/mime.types entry for .ico files was image/x-ico which is wrong. But since this bug's for Windows, I can't really say. I don't have a dev setup on Windows, but I figured this note might be of some use. Ted, if you could check your registry under HKEY_CLASSES_ROOT; if you have key for .ico what's the "Content Type" value for it?
OS: Windows XP → All
OS: All → Windows XP
image/x-icon
Hm, yeah, then "it's supposed to work". Don't think I can do much more from my Linux dungeon, unfortunately, so Matt or Mark or someone else will have to dig further. Is that a trunk Firefox?
Yep. Broken in: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre However, it works in my self-built Firefox: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008031107 Minefield/3.0b5pre (I'm not sure that that Build ID is authoritative, might have pulled a while before that.) I'll update my tree and rebuild and see if I can reproduce there.
Weird. I can't really see any check-ins for image-tools or the Windows nsOSHelperAppService that would affect this during that time frame. So I'm officially stumped...
Ah, it has something to do with my profile! I tried my nightly with a different profile and it worked.
Maybe something's wacky with compreg.dat or xpti.dat in the profile where it doesn't work...
I am getting a similar error on Mac. Error: [Exception... "Component returned failure code: 0x80540006 [imgITools.decodeImageData]" nsresult: "0x80540006 (<unknown>)" location: "JS frame :: file:///Users/apeck/Library/Application%20Support/Firefox/Profiles/hl9xmzut.default/extensions/refractor@developer.mozilla.org/modules/ImageUtils.jsm :: anonymous :: line 49" data: no] Source File: file:///Users/apeck/Library/Application%20Support/Firefox/Profiles/hl9xmzut.default/extensions/refractor@developer.mozilla.org/modules/ImageUtils.jsm Line: 49 FF 3.0.1 / Mac OSX 10.5.4 Prism 0.2 Extension
Summary: convert website to application fails when I select a .ico file as my icon → Favicon conversion issues
Flags: blocking1.0?(mark.finkle)
Flags: blocking1.0?(mark.finkle) → blocking1.0+
This is essentially a workaround. There are simply too many reasons why an icon might fail to convert (unknown mime type, bad mime config, bad image data, etc.). We can try to nail these one by one, and hopefully some sort of icon repository will help as well as improving the quality of icons for sites that are supported. In the meantime, I am proposing that we inform the user that the default icon will be used in this case, which is still a big improvement over silently failing to convert, which is the current behavior.
Attachment #357349 - Flags: review?(mark.finkle)
Attachment #357349 - Flags: review?(mark.finkle) → review+
Sending newapp/chrome/content/install-shortcut.js Sending newapp/chrome/locale/en-US/install-shortcut.properties Sending newapp/modules/FaviconDownloader.jsm Sending newapp/modules/ImageUtils.jsm Transmitting file data .... Committed revision 21616.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Makes sense.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: