422992 - can't create new folder/subfolder anymore - error Error: NewFolder is not defined Source File: chrome://messenger/content/messenger.xul Line: 1

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Since at least a couple of days, create folder (or subfolder) for all types of servers fail. No dialog asking for name is put up, simply does nothing. 

Error: NewFolder is not defined
Source File: chrome://messenger/content/messenger.xul
Line: 1

Comment 1

[Joey Minta]

This is me.  Patch coming shortly.

Comment 2

[Joey Minta]

Attachment: patch

This is fallout from bug 421382, where my searches didn't pick up the way the NewFolder function was being used.  Since GetCompositeDatasource and DoRDFCommand are gone, this is a reworked version of the function that was removed there.

Comment 3

[Magnus Melin [:mkmelin]]

Since "" is falsy, that could be simplified to |if (!uri || !name)|

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 309506 [details] [diff] [review]
patch

r=mkmelin, with previous comment fixed

Comment 5

[Joey Minta]

Fixed comment #3 and landed.
Checking in mail/base/content/mailCommands.js;
/cvsroot/mozilla/mail/base/content/mailCommands.js,v  <--  mailCommands.js
new revision: 1.40; previous revision: 1.39
done