421382 - Remove dordfcommand, getcompositedatasource

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Joey Minta]

Attachment: patch v1

The front end currently sends calls into the rdf-datasources via these functions, when it has perfectly good ways of making these calls on its own.  Removing these functions will make it easier to eventually remove those sources.

This patch slightly conflicts with the js-tree patch, but actually makes that patch easier in the long run.

You'll also notice the removal of some additional uncalled functions.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 307811 [details] [diff] [review]
patch v1

r=philringnalda, thanks for removing the spectre of what I misread as Dorf Command, which would probably be a movie about a WWII submarine commanded by Tim Conway on his knees.

And you thought *you* hated it!

Comment 2

[Joey Minta]

Checking in mail/base/content/mailCommands.js;
/cvsroot/mozilla/mail/base/content/mailCommands.js,v  <--  mailCommands.js
new revision: 1.39; previous revision: 1.38
done
Checking in mail/base/content/mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <--  mailWindowOverlay.js
new revision: 1.189; previous revision: 1.188
done
Checking in mail/base/content/messageWindow.js;
/cvsroot/mozilla/mail/base/content/messageWindow.js,v  <--  messageWindow.js
new revision: 1.61; previous revision: 1.60
done
Checking in mail/base/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v  <--  msgMail3PaneWindow.js
new revision: 1.144; previous revision: 1.143
done

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=ThunderbirdTinderbox&sortby=Date&hours=2&date=explicit&mindate=2008-03-10+08%3A25&maxdate=2008-03-10+08%3A25