424809 - nsCocoaWindow.mm causes build errors with GCC 4.2 on OS X

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Sean Fleming]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031515 Firefox/3.0b5pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031515 Firefox/3.0b5pre

A recent checkin to nsCocoaWindow.mm isn't liked by GCC 4.2 (included with the iPhone SDK). See patch for working fix.

Reproducible: Always

Comment 1

[Sean Fleming]

Attachment: Patch for nsCocoaWindow.mm

Comment 2

[Håkan Waara]

Sean, what's the compiler error?

Comment 3

[Sean Fleming]

Attachment: Build errors in nsCocoaWindow.mm

Comment 4

[Sean Fleming]

Comment on attachment 311407 [details]
Build errors in nsCocoaWindow.mm

Sorry, I meant to add the errors to the main bug, but forgot.

Comment 5

[Håkan Waara]

Comment on attachment 311398 [details] [diff] [review]
Patch for nsCocoaWindow.mm

Vlad, wanna sr this? It's trivial.

Comment 6

[Håkan Waara]

Just for the record, at least one other fix (for example bug 421689) would need to land on the branch in order for it to be compilable under iPhone SDK. 

There might potentially be other similar patches to this one that'd need to be coordinated...

Comment 7

[Sean Fleming]

Yep, https://bugzilla.mozilla.org/show_bug.cgi?id=423405 would be needed too.

Just for future reference, how do you create the nicer bug links?

Comment 8

[Håkan Waara]

(In reply to comment #7)
> Yep, https://bugzilla.mozilla.org/show_bug.cgi?id=423405 would be needed too.
> 
> Just for future reference, how do you create the nicer bug links?

If you write "bug X" (without the quotes), it is automatically converted to a link. Same with "attachment Y" for referring to attachments of a bug.

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 311398 [details] [diff] [review]
Patch for nsCocoaWindow.mm

indent the 'break;'s correctly after the default: ?

Comment 10

[Sean Fleming]

Attachment: Patch for nsCocoaWindow.mm - rev 1

Comment 11

[Sean Fleming]

Given that this is my first patch, I'm not sure of what to do now.
The new patch has been uploaded, and I have + on r and sr, is there something else I need to do?

Comment 12

[Håkan Waara]

Comment on attachment 311422 [details] [diff] [review]
Patch for nsCocoaWindow.mm - rev 1

Next step is to ask for approval, since the tree is semi-closed down.

Drivers: Trivial patch to make trunk compilable with latest GCC and iPhone SDK.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> Just for the record, at least one other fix (for example bug 421689) would need
> to land on the branch in order for it to be compilable under iPhone SDK. 
> 
> There might potentially be other similar patches to this one that'd need to be
> coordinated...

Håkan, if you're tracking these for a possible branch landings, bug 423405 and bug 407535 (at the very least, the Camino hunk will still be relevant, too).  Luckily this version of Xcode doesn't seem to have been released yet outside of the beta iPhone SDK.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311422 [details] [diff] [review]
Patch for nsCocoaWindow.mm - rev 1

a1.9b5=beltzner; would that it were this easy to patch the iPhone SDK terms of use!

Comment 15

[Reed Loden [:reed]]

Checking in widget/src/cocoa/nsCocoaWindow.mm;
/cvsroot/mozilla/widget/src/cocoa/nsCocoaWindow.mm,v  <--  nsCocoaWindow.mm
new revision: 1.140; previous revision: 1.139
done

Comment 16

[Håkan Waara]

Thanks for the patch, Sean!

[I'm wondering if we should set up a meta-bug tracking all of these fixes, until we start landing them on the branch.]

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #16)
> [I'm wondering if we should set up a meta-bug tracking all of these fixes,
> until we start landing them on the branch.]

Håkan had asked me a while ago if I would do that, and I finally worked through my queue, so we now have bug 433203.