425015 - Customize Toolbar Menu doesn't work anymore

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Nomis101]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_5_2; de-de) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
Build Identifier: Mozilla/5.0, Version 3.0a1pre, en-US and de, 2008032503

Since 2008032203 my Customize Toolbar Menu doesn't work anymore. If I right-click on the main window or on the compose window to show "Customize..." and than choose "Customize...", the opening menu is empty.  
If I go back to an older version (in my case 2008031414), I don't have this problem anymore.




Reproducible: Always

Steps to Reproduce:
1. Open Thunderbird
2. Right-click on the toolbar to show "Customize..."
3. Select "Customize..."
Actual Results:  
The appearing Customize Toolbar Menu is empty


I have this bug since 2008032203, I don't use any additional extensions.

Comment 1

[Magnus Melin [:mkmelin]]

WFM on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032503 Thunderbird/3.0a1pre ID:2008032503

Still broken for you with a few days newer build?

Comment 2

[Phil Ringnalda (:philor)]

Yeah, seems to be Mac-only. At least according to what makes it through to the error console, when customizeToolbar.js tries |var stringBundle = document.getElementById("stringBundle");| it doesn't find one, so we blow up with "Error: stringBundle.getString is not a function." Odd, since I don't think we changed anything, but it's not affecting Fx, where we stole most of the code. I'll chase a slightly smaller regression window later, if nobody beats me to it.

Comment 3

[Phil Ringnalda (:philor)]

Range is 2008032103 - 2008032203, confirmed by local backout that it was caused by bug 395609, though so far I don't see why we fail and Fx doesn't.

Smaug: no, you don't need to buy a Mac; Mozilla needs to buy you a Mac.

Comment 4

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Oh, okay, got it (I think). Though it would help if someone would buy me a mail/ reviewer with a Mac.

Failing that, Smaug, could you please review my assumption that it was an actual intentional change that <iframe src="foo" hidden="true"/> now won't load when it's created, and won't load when it's unhidden, but only when you set the src while it's unhidden? And dmose, could you please make sure I actually fixed it?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #4)
> Failing that, Smaug, could you please review my assumption that it was an
> actual intentional change that <iframe src="foo" hidden="true"/> now won't load
> when it's created,
The change is that now <iframe> loads immediately when the element is bound to
document, earlier it was loaded when element was set visible.

> and won't load when it's unhidden,
Right, visibility doesn't have anything to do with loading and unloading 
anymore.
In other words - XUL iframe/browser/editor loading works now like HTML iframe.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 311743 [details] [diff] [review]
Fix v.1

This looks like similar change that what was done to FF.

Comment 7

[Jay Moran (jaym/lazvon)]

Came here via Bug 424976 ... the patch for this also fixes Bug 424976, different symptoms and problem though.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Thunderbird will probably also want whatever patch we end up taking to fix bug 426380.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 311743 [details] [diff] [review]
Fix v.1

Sigh.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Phil: just tested your patch, and it does fix this problem for me.

Comment 11

[Phil Ringnalda (:philor)]

Cool. Fresh patch when I get home tonight, with bug 426380 included, and then I think I'll go ahead and land it - I'm starting to get nervous about what else we might mask, being unable to customize toolbars or see most of the compose window for too long.

Comment 12

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

Rains ⇒ pours. Fairly hard to test right now, unless you either back out the patch from bug 420499 or work around bug 426392 some other way (maybe using a pre-20080325 build to remove all menu-button toolbarbuttons from the toolbar would work).

Comment 13

[Phil Ringnalda (:philor)]

Checked in, carrying over Smaug's review from the Firefox patch ("and boy, are my arms tired!").

mail/base/content/mailCore.js 1.38
mail/base/content/messageWindow.xul 1.37
mail/base/content/messenger.xul 1.87
mail/components/addrbook/content/addressbook.xul 1.76
mail/components/compose/content/messengercompose.xul 1.117

Comment 14

[Jay Moran (jaym/lazvon)]

Latest checkout and build works great!