426050 - Regression in download manager policies, false positives

Status: VERIFIED DUPLICATE of bug 430566

(Toolkit :: Downloads API, defect)

Description

[Paul-Kenji Cahier]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032904 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008032904 Minefield/3.0pre

When trying to download some files, regardless of content, and purely based on filename, some will fail currently.
Regression range found to be: http://hourly-archive.localgho.st/win32/20080321_1839_checkins.html
Before that commit everything downloaded properly.

Reproducible: Always

Steps to Reproduce:
1.Go to http://saber.kawaii-shoujo.net/Various/tests/
2.Try to save on disk the file from there

Actual Results:  
Instant error message in the download manager: "Blocked: Download may contain a virus or spyware", file does not get downloaded.

Expected Results:  
File should have downloaded and no error message should have been triggered.

This seems to be a consequence of the fix on https://bugzilla.mozilla.org/show_bug.cgi?id=416683 and the error message given being inappropriate is probably related to https://bugzilla.mozilla.org/show_bug.cgi?id=424547
Regardless of the message likely to be the wrong text, the error should not be triggered.

Comment 1

[Shawn Wilsher :sdwilsh]

This is the intended behavior as those downloads would have been removed after the download was completed before bug 416683.

Comment 2

[Paul-Kenji Cahier]

I cant see how this is intended behaviour?
Forbidding a download based on a filename policy that can not be disabled/seen anywhere?

Comment 3

[Shawn Wilsher :sdwilsh]

It's in the windows control panel.  It's a system setting that we actually obey now.

Comment 4

[Paul-Kenji Cahier]

Except that ff is being overzealous here. That file was never deleted here with ie or any of the ff versions prior to that bugfix.(I checked it)
This is a false positive in some way as windows is *not* doing anything to them here.(downloaded with ie6/ie7 and multiple email clients that do respect the windows settings for files downloaded)

Comment 5

[Matthias Versen [:Matti]]

reopening based on the last comment, if it works in IE7 then it must work in Firefox

Comment 6

[Paul-Kenji Cahier]

If there's anything in particular I should be checking/reporting, please tell, so I can do the testing.

Comment 7

[Jim Mathies [:jimm]]

Hmm, I can't reproduce. This avi saves out just fine on Vista and XPSP2 for me. Paul-Kenji, can you offer any insight as to what might be different between our machines? Also do you run any anti-virus software?

Comment 8

[Paul-Kenji Cahier]

On 2 of the test computers no anti virus.
On mine there's an AVG but I have manually disabled the IOfficeAV interface so it doesn't bother checking anything. Otherwise no anti-spyware/av/anything that could interfere.

After some checking, I've found it seems to be path related.
Saving in D:\test1\test2\test3 works but not in D:\test1\test2\test3\test4 for example.
Some more investigation shows it's purely path length related.
If the path is more than 20 characters or so, it fails.
ie d:\12345678901234567890 works but not d:\123456789012345678901

Comment 9

[Paul-Kenji Cahier]

Additional comment, the path I gave were for directories to save the file in, not a new name for the files, didn't put trailing backslashes so thought I should add up this.

Comment 10

[Marc Schumann [:Wurblzap]]

Oh, so that's probably why I'm not allowed to download Pidgin. The message of comment 0 matches, at least (it is well hidden inside the downloads list, btw). Next up for me: finding out where the setting may be which rejects the download, so that I can change it. Probably somewhere in the registry. Google will probably help.

Comment 12

[Paul-Kenji Cahier]

Just as a new comment after some testing:
Saving any file(regardless of location or type or size or av) named like this:
Ｓｏｎｉｃ Ｓｏｌｄｉｅｒｓ Ｂｏｒｇｍａｎ - 夜をぶっ飛ばせ
in any location, causes the error.

Comment 13

[Paul-Kenji Cahier]

And some more testing with a simpler case:
try downloading any file and saving it as
せせせせせせせせせせせせせせせせせせせせせせせせせせせせ
(27 times the せ character)
(which on a side note makes 27 chars + 3 of drive root=31, awfully close to 32-1)

Comment 14

[Damian Shaw [Quan]]

I confirm using the test case from comment #13

I downloaded a file I've downloaded many times before, but renamed it to:

せせせせせせせせせせせせせせせせせせせせせせせせせせせせ

And saved it to C:\, I got the error message: This download has been blocked by your Security Zone Policy"

Using build:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre ID:2008040504

Comment 15

[Nico Jehle]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040504 Minefield/3.0pre ID:2008040504

I confirm that saving any file as せせせせせせせせせせせせせせせせせせせせせせせせせせせせ fails.

Comment 16

[Damian Shaw [Quan]]

Just tested this again using the comment #13 test case, and it now appears to be WFM.

Comment 17

[Shawn Wilsher :sdwilsh]

resolving as WORKSFORME, but please re-open if you see it.

Comment 19

[Paul-Kenji Cahier]

Fixed here too, and on a side note... Great to see that it was ignored and had to get another dupe to get solved.

Comment 20

[Shawn Wilsher :sdwilsh]

verified dupe