42692 - drag and drop to personal toolbar fails (JS error)

Status: VERIFIED DUPLICATE of bug 46456

(SeaMonkey :: UI Design, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  If I drag from the icon in the URL bar to the personal toolbar, it
doesn't do anything, except give a JS error in navigatorDD.js, line 104, that
gDragDropEnabled is not defined.

STEPS TO REPRODUCE:
 1) drag the little document icon in the URL bar to the personal toolbar
 2) go to Tasks | Tools | Javascript Console

ACTUAL RESULTS:
 1) nothing
 2) JS error as described above

EXPECTED RESULTS:
 1) icon on personal toolbar
 2) no JS error

BUGGY ON:
 * Win98 2000-06-15-08-M17

Comment 1

[Peter Trudelle]

I don't think that has ever worked, and as far as I know, it has been cut from 
the product. In any case, it is an XPApps issue, reassigning.

Comment 2

[Cyril Bortolato]

Looks like bug #42589

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 42589 has been marked as a duplicate of this bug. ***

Comment 4

[Claudius Gayle]

this is probably a dupe...

Comment 5

[Eli Goldberg]

This feature is listed in the Netscape beta 2 PRD, marking as NS beta 2 for fix, 
or for Netscape to update their PRD.

[changing platforms to 'all'.]

Comment 6

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2, this feature was cut from 
the product.

Comment 7

[Eli Goldberg]

E-mailed John Gable to request PRD update.

Comment 8

[don]

This feature was cut from the procuct?!?  I don't think so. :-)  Nominating for
nsbeta3.  Time to argue with the PDT ...

Comment 9

[don]

Nominating for nsbeta3, setting priority, etc. ... again!  (This dogfood is
gettin' a might hard to swallow.)

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the JS error (as it currently exists) was caused by ben's checkin r1.14
of navigator.js (May 31).  Before that point, gDragDropEnabled was set based on
a pref.  He removed it, and changed one of the tests for it to act as if it was
**not** enabled, but didn't change the others.

Comment 11

[Blake Ross]

Ben said he has personal toolbar d&d working on his laptop but he's waiting til 
it snows in miami for checkin...

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

that's right, I have a "working" implementation. I'll check it in later today, 
but disabled by default because Mike "The code is all there, I'm just waiting 
for someone from XPApps to hook it up" Pinkerton was going to cry if I made it 
enabled by default and caused him to get three hundred new menu/d&d bugs ;)

My checkin will also fix this js error. 

To enable d&d on your personal toolbar, go to Preferences->Debug and choose 
"Personal Toolbar Drag & Drop (buggy)"

Comment 13

[Robert John Churchill]

*** Bug 44027 has been marked as a duplicate of this bug. ***

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

checked in. 

Comment 15

[av (gone)]

*** Bug 42696 has been marked as a duplicate of this bug. ***

Comment 16

[Daniel Veditz [:dveditz]]

Adding keyword to bugs which already show a nsbeta2 triage value in the status 
whiteboard so the queries don't get screwed up.

Comment 17

[Jeffrey Baker]

FYI, this doesn't actually seem to work in Linux 2000-08-17-13:

JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://navigator/content/navigatorDD.js :: anonymous :: line 164"  data: no]

Comment 18

[sairuh (rarely reading bugmail)]

d'n'd qa -> terri

Comment 19

[Terri Preston]

Still get javascript error and no icon on personal toolbar 
Windows 2001030904, Linux 2001030608, Mac 2001030808

Comment 20

[Peter Lairo]

This is a basic feature and is (would be) most used/most visible by normal
users. It still doesn't work - but should!

This bug and tooltips for cut-off text are most relevant from a user standpoint
- they should receive TOP priority.

moz 2001-03-16, win98

Comment 21

[Alec Flett]

this isn't a dependancy, it's a dupe. 

*** This bug has been marked as a duplicate of 46456 ***

Comment 22

[Terri Preston]

Verified Duplicate