427200 - rightclick on bookmarks on the bookmarks toolbar is broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040420 Minefield/3.0pre ID:2008040420

regression:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1207329000&maxdate=1207334579

Comment 1

[Marco Bonardo [:mak]]

so it's bug 384968

Comment 2

[Asaf Romano (gone)]

Attachment: obvious fix

I'm going to land that with post-facto r+a.

Comment 3

[Asaf Romano (gone)]

Attachment: obvious fix++

also fix the context menu for the empty area of the toolbar, which I broke earlier.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 313794 [details] [diff] [review]
obvious fix++

r=me

Comment 7

[Asaf Romano (gone)]

mozilla/browser/components/places/content/toolbar.xml 1.149
mozilla/browser/components/places/content/menu.xml 1.127

Comment 10

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040623 Minefield/3.0pre ID:2008040623

verified/fixed

Comment 13

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040704 Minefield/3.0pre, as well as the Windows XP nightly.

Comment 14

[Ben]

I verify too that its fixed on my mac os x 10.5.2 . I am curious why this action also doesn't work from within the Bookmarks Menu? Instead, when Control + Click on any item, it just opens the page. Is this a bug or design problem? If its an existing bug, can anybody point me to the correct one?

Comment 15

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5239 added to Litmus for this test case since I did not see an existing test case.

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv