Closed
Bug 428339
Opened 18 years ago
Closed 18 years ago
Print Selection output is limited to one page in trunk
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug, )
Details
(Keywords: regression)
In FF2, Print-Selection could print multiple pages.
In trunk, it's limited to one page. This was discussed in bug 402264 comment 44 through bug 402264 comment 49.
Attachment 314869 [details] shows that this is indeed a regression -- it's a two-page PDF printed in Firefox 2, using Print-Selection.
| Assignee | ||
Comment 2•18 years ago
|
||
attachment 316008 [details] is a handy testcase for this bug.
Steps to reproduce (based on Bug 429330 comment 0), using that testcase:
1. Select from the first row to the 80th one
2. Click on File->Print and then select "Selection" radio button
3. Click on ok
Expected results:
Multiple pages printed, showing all 80 rows
Actual results:
Just one page is printed, with only the rows that fit on it. (up to row 45 on my machine)
Bug 429330 comment 2 indicates that Firefox 2 shows expected results.
| Assignee | ||
Comment 3•18 years ago
|
||
(In reply to bug 429330 comment #6)
> I think that those bugs (428339 and 429337) should block final release of
> firefox 3.
I disagree for this bug -- I'd lean towards not having this bug block, pending some investigation.
Basically, my position is this:
- If it's a tiny fix, then it'd be great to get it in, but we could also also easily include it in 1.9.0.x. (i.e. FF3.0.x)
- On the other hand, if this ends up being a major patch, then it may be too risky to tweak current behavior at this point in the release cycle.
And I'm not convinced that *multi-page* print-selection is a crucial-enough feature to block the release on.
In particular, I'm a little scared by this comment (which I referred to in bug 402264 comment 45):
1934 // XXX - Hack Alert
1935 // OK, so there is a selection, we will print the entire selection
1936 // on one page and then crop the page.
1937 // This means you can never print any selection that is longer than
1938 // one page put it keeps it from page breaking in the middle of your
1939 // print of the selection (see also nsSimplePageSequence.cpp)
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/printing/nsPrintEngine.cpp&rev=1.174#1934
Updated•18 years ago
|
Flags: blocking1.9?
Comment 4•18 years ago
|
||
I've tested the bug here http://www.stpauls.it/domenica/0829do/0829dohp.htm#PAR
If I try to print from the paragraph named "LITURGIA DEL GIORNO" to the end of the page Firefox prints only a part of the paragraph.
If I try to print it by File->Print and then print only the third page, Firefox prints it correctly.
| Assignee | ||
Comment 5•18 years ago
|
||
That sounds more like bug 428975. I posted about it there: bug 428975 comment 12.
Comment 6•18 years ago
|
||
I think this is something we can fix in a dot release. Please re-nom if you disagree.
Flags: blocking1.9? → blocking1.9-
| Assignee | ||
Comment 7•18 years ago
|
||
(In reply to comment #6)
> I think this is something we can fix in a dot release
K -- nominating for 1.9.0.x
Flags: wanted1.9.0.x?
| Assignee | ||
Comment 8•18 years ago
|
||
This code from nsPrintEngine.cpp may be of interest in this bug.
(it looks like it calculates # of pages that we'll need for the selection)
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/printing/nsPrintEngine.cpp&mark=&rev=1.176#2212
This section of nsSimplePageSequence.cpp may also be interesting, given the comment "XXX This is temporary fix for printing more than one page of a selection"
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/generic/nsSimplePageSequence.cpp&mark=&rev=3.168#584
| Assignee | ||
Comment 9•18 years ago
|
||
Note: When this bug is fixed, make sure to check if it works as expected with scaled print output, too.
See this comment added in bug 430150's patch:
// XXXdholbert does this num-pages calculation need to take
// aPO->mZoomRatio into consideration?
which is at
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/printing/nsPrintEngine.cpp&rev=1.180&mark=2212-2215#2212
Comment 10•18 years ago
|
||
Now this bug seems to be fixed after the last nighlty (2008042207)
Comment 11•18 years ago
|
||
But all the printed pages are vertically unaligned.
| Assignee | ||
Comment 12•18 years ago
|
||
(In reply to comment #11)
> But all the printed pages are vertically unaligned.
Mrtb and I discussed this via IRC a bit. He says that when he does print-selection to a physical printer (following steps in comment 2), the page contents are shifted upwards so that bottom margin is too big, and the upper margin is too small.
Mrtb tried printing to a PDF to demonstrate this -- attachment 317080 [details] -- though that turned out to show different issues:
- Printed content flows off of the first page
- Duplicated content at the bottom of the first page & at the top of the second page.
(Interestingly, the page contents *aren't* shifted upwards in the PDF as they are on his physical printer)
I think the differences are because his physical printer has print-margins set, and the PDF printer does not.
| Assignee | ||
Updated•18 years ago
|
Assignee: nobody → dholbert
| Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 13•18 years ago
|
||
Per comment 10, this bug's core issue ("Print Selection output is limited to one page in trunk") was fixed by the checkin of bug 429337.
--> Marking Fixed.
(Mrtb, I think the issues you're seeing in comment 11 and 12 are probably related to bug 430357, which I just filed & am investigating. Let's move the discussion on margins / vertical alignment to there.)
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 14•18 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=5279 added to Litmus.
Flags: in-litmus+
Comment 17•16 years ago
|
||
The duplicate rows issue from comment 12 is still open and continued in bug 431293
You need to log in
before you can comment on or make changes to this bug.
Description
•