428887 - accounts not listed in account order under the Get Mail button

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

The accounts are no longer listed in account order under Get Mail. They now seem to be in some random order instead. (Also some non-existent news accounts are listed.)

Regression window 2008-04-10 03 -> 2008-04-10 03, so I suspect bug 413781.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Blocking-thunderbird3 since this is a regression, and it'd a fine thing to have this not regress in 3.0a1 as well.

Comment 2

[Joe Sabash [:JoeS1]]

(In reply to comment #0)
> The accounts are no longer listed in account order under Get Mail. They now
> seem to be in some random order instead. (Also some non-existent news accounts
> are listed.)
> 
> Regression window 2008-04-10 03 -> 2008-04-10 03, so I suspect bug 413781.
> 
Seeing this in Winxp also, including the extra News accounts.

Comment 3

[Joey Minta]

Can people clarify about "non-existent news accounts"?  Are these accounts that you have deleted or accounts that never were created? Or duplicates of accounts that still exist?

Comment 4

[Joe Sabash [:JoeS1]]

In my case , these must have been "artifacts" in my profile.
I had an account named "news" which showed up twice in the drop-down.
Had to delete the "single" news account that I saw there twice, then restart TB.
Now the list is accurate, just out of order.

Comment 5

[Magnus Melin [:mkmelin]]

For me too "non-existent" news accounts meant some accounts not seen in the account manager. They are named "news" - i think there is some old bug that generates such accounts when clicking news:// urls under some circumstances - I have never set them up manually. (I'll have to check later if there was other things in the list too.)

Comment 6

[Magnus Melin [:mkmelin]]

The "news" accounts are likely there due to bug 41133. For me it lists three of them, and also an extra RSS account. (Possibly an old deleted one, can't recall.)

Comment 7

[Joey Minta]

(In reply to comment #6)
That makes sense.  I also wouldn't be surprised if these "news" accounts are the ones with null incomingServers, leading to these other bugs.  Magnus, do you know of some easy way to check whether an account is this weird semi-account? Does it have some property (or lack some property normal accounts would have)?

Comment 8

[Magnus Melin [:mkmelin]]

Not that I can think of, though is looks like the hostname is always "news" e.g. mail.server.server16.hostname;news

Comment 9

[Magnus Melin [:mkmelin]]

On second thought, it should be the ones *not* listed in mail.accountmanager.accounts. And that should also be the order the Get Mail button lists the accounts.

Comment 10

[Joey Minta]

Attachment: patch

This patch will sort accounts, rather than the root folders for those accounts.  It also includes some bullet-proofing for bug 41133.

Comment 11

[David Ascher (:davida)]

Marking as blocking-tb3a1 as it will fix 429032 which is already blocking.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 316701 [details] [diff] [review]
patch

Looks good; r=dmose.


Please add a brief english description and/or ascii art description of the sort order in a comment so that it's possible to tell that the intended semantics are what's actually implemented.  This only occurred to me because it took me a bit to realize that intra-type, accounts are returned in their natural order and not sorted.

Comment 13

[Joey Minta]

Comment added.

Checking in mail/base/content/mail-folder-bindings.xml;
/cvsroot/mozilla/mail/base/content/mail-folder-bindings.xml,v  <--  mail-folder-bindings.xml
new revision: 1.2; previous revision: 1.1
done

Comment 14

[Joe Sabash [:JoeS1]]

Seems to work fine here:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042317 Thunderbird/3.0a1pre ID:2008042317

Comment 15

[Magnus Melin [:mkmelin]]

Yes, the accounts are now sorted like they used to, but the list includes the odd "news" accounts (and some removed rss account).

Comment 16

[[e-mail]]

Comment on attachment 316701 [details] [diff] [review]
patch

>+            // Sadly, the accountMgr doesn't provide us we a sorted list of
>+            // accounts.  We have to get them in the right order on our own.
Sounds like you really need nsIMsgAccountManager.subFolders() ;-)

>               var acct = acctMgr.accounts.GetElementAt(i).QueryInterface(Ci.nsIMsgAccount);
Ooh, I missed this last time.
var acct = acctManager.accounts.QueryElementAt(i, Ci.nsIMsgAccount);
Or is that queryElementAt these days?

>+            // Our actual sorting function for accounts
>+            function accountCompare(a, b) {

>+              return 0;
You're lucky JS sort is stable these days (new for 1.9).

>+            // Now generate our folder-list.  Note that we'll special case this
>+            // situation below, to avoid destroying the sort order we just made
Perhaps sort (filter?) subfolders in this method's else block?

Comment 17

[Geert-Emo]

I suspect Thinderbird 13.0.1 regressed to this bug.
Since 13.0.1 the order in the Get Mail list is different from the order of the mail accounts (in the folder pane & the folderpane extension has no impact on the Get Mail order anymore).