429258 - Restore a "Themes" link for all other applications

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Restore a "Themes" link for Thunderbird-application users

We borked Thunderbird theme-seeking users when we fixed bug 423619, which removed the "I am looking for..." box.

Themes are still searchable by category type (many are under Miscallaneous) and by directly searching by name, but this is a pretty bad experience.

Comment 1

[Michael Morgan [:morgamic]]

We need to make sure users of any app can easily get to themes.

In bug 423619 there was a patch to remove the pitch element for certain apps.  Instead have those apps (that don't have a hybrid category) point to the simple theme listing that was available in 3.1.

Example:
/en-US/thunderbird/browse/type:2/cat:all?sort=name
/en-US/sunbird/browse/type:2/cat:all?sort=name

There isn't a hybrid category for these but we can't take the pitch element away without providing an alternate click path for users to get to themes.  Dictionaries and Search plugins could be brought back with similar links...

Comment 2

[Fred Wenzel [:wenzel]]

I think this was a result of a misunderstanding during the meeting, where we incorrectly decided that non-browser apps don't have anything but extensions so we just removed the box.

So are we adding the pitch element back and just fixing the links then? And do I get comment 1 right in that it's saying: all apps have 
a) themes
b) dictionaries
c) search engines?

Thunderbird with search engines? Unlikely. But I think adding the pitch element back, containing a), b), c) for browser apps, and a)+b) for non-browser apps, should do the trick.

And for all of these, we need to fix the link/adjust the code so they don't "expect to be hybrid", for ex. by just linking to the listing pages.

I will provide a patch so that we can get it in shortly. And, if my assessment above is wrong, please speak up.

Comment 3

[Michael Morgan [:morgamic]]

That's correct - let's get abc for browser apps and just ab for others.  Also correct regarding the link code.  Thanks Fred.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Fixing "pitch" element for non-browser apps.

This re-adds the "pitch" element for non-browser apps and changes the links for them as mentioned above.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Sending themes to listing, not landing page also

This patch differs in that it also sends the "themes" link on the browser pages to the listing, not landing pages because that's what the user likely wants when clicking the link, instead of going to the hybrid "appearance" page.

Mike, please review. Thanks!

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 316019 [details] [diff] [review]
Sending themes to listing, not landing page also

Looks good - ship it.

Comment 7

[Fred Wenzel [:wenzel]]

It's committed to r12310, can you have that pushed?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Tested that:

1) Firefox has all three (themes, dictionaries, search engines)
2) Thunderbird has two (themes, dictionaries)
3) SeaMonkey has all three (themes, dictionaries, search engines)
4) Sunbird has two (themes, and (1) dictionary?)

Verified FIXED on http://remora-trunk.php5stage.mozilla.com/en-US/firefox/ and the other applications' pages...