430128 - Search button not displayed with JavaScript enabled

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[VanillaMozilla]

If JavaScript is enabled, the Search button appears briefly but quickly disappears behind the "within all add-ons" box.  This is essentially the opposite of bug 422586, "Neither IE 6 nor IE 7 display the "Search" button when JavaScript is disabled".

Comment 1

[VanillaMozilla]

In combination with bug 430130 the severity borders on MAJOR.

Unlike bug 422586, this bug occurs with Firefox 2 or 3 (as well as Opera), and therefore directly affects Firefox users.

Comment 2

[steviex]

I see this with Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9b5) Gecko/2008041514 Firefox/3.0b5 ID:2008040514

With Javascript ON, I do not see the Search Button
With Javascript OFF, the button appears with a shorter catergory box.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Show search button with JS enabled

This shows the search button even with JS enabled; I added some padding to its CSS style but I didn't change anything else, because that would remove the button's native look and feel.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Screenshot with button shown, JS enabled

This is what the search button looks like now, in Firefox 3 nightly on OSX.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 317329 [details] [diff] [review]
Show search button with JS enabled

(In reply to comment #4)
> Created an attachment (id=317331) [details]
> Screenshot with button shown, JS enabled
> 
> This is what the search button looks like now, in Firefox 3 nightly on OSX.
> 

Mostly works, but for this line:

+#search-form #my-submit { margin-left: 10px; }

can you make one for rtl languages too?  Otherwise the button butts up against the dropdown.

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Patch with CSS for LTR vs. RTL languages

Good catch, Wil. I changed the styles to distinguish between rtl and ltr, looks good for me in both en-US and Hebrew.

Comment 7

[Fred Wenzel [:wenzel]]

Committed to r12533.

stephend, when you verify this, could you please take a look at it on Windows to make sure it doesn't look ugly? It should probably be good, but I only checked on OSX. Thanks!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Committed to r12533.
> 
> stephend, when you verify this, could you please take a look at it on Windows
> to make sure it doesn't look ugly? It should probably be good, but I only
> checked on OSX. Thanks!

Verified FIXED; ran IE 6/7, Safari 3.1.1, Opera 9.27, and of course Firefox 2/3, and found no layout issues (default screen res on each OS).