Closed Bug 430254 Opened 15 years ago Closed 15 years ago
Add interfaces to GData for UI code
GData needs interfaces to allow access from outside of the component (i.e ui code)
Attachment #316996 - Flags: review?(daniel.boelzle)
Having a rough look, the changes look good to me, but I am asking myself why you want to expose those interfaces: If we are lacking general API or overlaying facilities that extensions could use, why don't you go that way? We certainly want to get rid of the last wcap specifics: <http://mxr.mozilla.org/mozilla1.8/search?string=calIWcapCalendar&find=calendar&findi=&filter=&tree=mozilla1.8> and replace those with a general API/concept, too.
Even if we do create a general API, I think its a good idea to expose gdata interfaces first. As you see there are a bunch of code changes needed. If we want to generalize interfaces afterwards, the step will be much easier and code changes much smaller. There are some gdata-specific things that should be exposed, that don't apply to other calendars (i.e selected/hidden state, server color,...). Alone for this reason, an extra interface for gdata needs to be created. I think its a good idea to create a general interface that both wcap and gdata (maybe others) could implement.
Comment on attachment 316996 [details] [diff] [review] Add interfaces - v7 r=dbo
Attachment #316996 - Flags: review?(daniel.boelzle) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
The checkin busted all Lightning and Sunbird tinderboxen: ** (process:20569): WARNING **: Parse of /builds/tinderbox/Lightning-Trunk/Linux_2.6.18-8.el5_Depend/mozilla/calendar/providers/gdata/public/calIGoogleSession.idl failed
A fix was checked in shortly after, will post the patch soon. Tinderboxen are green again.
Whiteboard: [gdata-cvs] → [gdata-0.5]
You need to log in before you can comment on or make changes to this bug.