Closed Bug 430499 Opened 16 years ago Closed 16 years ago

[10.5] Can't switch tabs with CTRL + Tab

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9

People

(Reporter: bsterne, Assigned: masayuki)

References

Details

(Keywords: regression, Whiteboard: [key hell])

Attachments

(1 file, 1 obsolete file)

Patch v1.1
2.67 KB, patch
jaas
: review+
vlad
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review 
 
In the latest nightly build I'm unable to switch tabs using CTRL + Tab (or CTRL + Shift + Tab).  Using Option + Command + Arrow does work.
Summary: Can't switch tabs with CTRL + Tab (ro → Can't switch tabs with CTRL + Tab
Flags: blocking1.9?
This needs to be in Widget:Cocoa.
Assignee: nobody → joshmoz
Component: Tabbed Browser → Widget: Cocoa
Keywords: regression
QA Contact: tabbed-browser → cocoa
I wonder if this is related to bug 429510 ?

+'ing this until we know.  Dammit.
Flags: blocking1.9? → blocking1.9+
(In reply to comment #3)
> I wonder if this is related to bug 429510 ?

I don't think so.

Brandon, do you know in which nightly this last worked?
20080422_2022 works
20080422_2051 fails
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1208920920&maxdate=1208922659
regression from Bug 423814.

I can't understand Cocoa key handling...
(In reply to comment #5)
> regression from Bug 423814.

It's strange. keyDown is not called??

CTRL + Tab (and CTRL + Shift + Tab) work in the 2008042204 nightly but don't work in the 2008042304 nightly.
I cannot reproduce this bug on 10.4 (like bug 423814!).

It seems that when we return NO in pKE at *some* key combination, that doesn't fire keyDown.
Josh:

Do you have idea for this bug?
(In reply to comment #8)
> I cannot reproduce this bug on 10.4 (like bug 423814!).
> 
> It seems that when we return NO in pKE at *some* key combination, that doesn't
> fire keyDown.

I can reproduce on 10.5.2.
When I press Ctrl+(normal key), keyDown is called.
But when I press Ctrl+Tab or Ctrl+Esc, keyDown is not called.
Summary: Can't switch tabs with CTRL + Tab → [10.5] Can't switch tabs with CTRL + Tab
Attached patch Patch v1.0 (obsolete) — — Splinter Review 
Maybe, this fixes this bug (and bug 431080)....
Attachment #318412 - Flags: review?(joshmoz)
Whiteboard: [key hell][needs review]
we need to add a keyboard navigation litmus suite for these kind of tests
Flags: in-litmus?
Masayuki: we have 10.5 here in the lab.  Can you provide us a tryserver build with your patch?  We can test it then.
Tomcat has built the fix on his tryserver build.   Will be testing today, and report back here when completed.
(In reply to comment #14)
> Tomcat has built the fix on his tryserver build.   Will be testing today, and
> report back here when completed.
> 
The tryserver build can be found here: https://build.mozilla.org/tryserver-builds/2008-04-29_16:07-cbook@mozilla.com-1209510375/
Masayuki, i tested your patch with the Tryserver Build 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008043000 Firefox/3.0pre -> normal debug build fail without the patch, as reported in comment #1 from Brandon.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042916 Minefield/3.0pre the tryserver build with your patch works fine and Tab Switching via CTRL + Tab / CTRL + Shift + Tab is working as expected :) 

For Bug 431080 we maybe should ask the reporter to try out the tryserver build, if this patch fix his reporter bug.
Attached patch Patch v1.1 — — Splinter Review 
oops, sorry. the previous patch has wrong condition.
Assignee: joshmoz → masayuki
Attachment #318412 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #318548 - Flags: review?(joshmoz)
Attachment #318412 - Flags: review?(joshmoz)
Comment on attachment 318548 [details] [diff] [review]
Patch v1.1

I think we should take this patch, it is the best we can do in a reasonable time frame. I'm going to continue looking into this key behavior though.
Attachment #318548 - Flags: superreview?(roc)
Attachment #318548 - Flags: review?(joshmoz)
Attachment #318548 - Flags: review+
Attachment #318548 - Flags: superreview?(roc) → superreview?(vladimir)
Attachment #318548 - Flags: superreview?(vladimir) → superreview+
Attachment #318548 - Flags: approval1.9?
Comment on attachment 318548 [details] [diff] [review]
Patch v1.1

a1.9+=damons
Attachment #318548 - Flags: approval1.9? → approval1.9+
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [key hell][needs review] → [key hell]
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre
Status: RESOLVED → VERIFIED
Hardware: PC → All
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: