Keyboard shortcuts for page zoom are not working using cmd and number pad

VERIFIED FIXED in mozilla1.9

Status

()

Core
Widget: Cocoa
--
major
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: flod, Assigned: masayuki)

Tracking

({regression})

Trunk
mozilla1.9
All
Mac OS X
regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [key hell])

Attachments

(1 obsolete attachment)

(Reporter)

Description

10 years ago
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre

Mac OS X is in Italian, keyboard has Italian layout.

Combinations cmd+'+', cmd+'-' and cmd+'0' don't work on trunk using number pad keys: you can see the menu "View" flashing, but the zoom doesn't change (on the same machine Firefox 2 is working fine). 

The same combinations made with the standard keyboard keys work fine.
Assignee: nobody → joshmoz
Component: Menus → Widget: Cocoa
Product: Firefox → Core
QA Contact: menus → cocoa
Created attachment 318094 [details] [diff] [review]
Patch v1.0

This is same bug as bug 423814. If Cmd key is pressed, the keyDown event is not fired after return NO from pKE.
Assignee: joshmoz → masayuki
Status: NEW → ASSIGNED
Attachment #318094 - Flags: review?(joshmoz)
(Assignee)

Updated

10 years ago
Blocks: 398514
Flags: blocking1.9?
Keywords: regression
Target Milestone: --- → mozilla1.9

Updated

10 years ago
Flags: blocking1.9? → blocking1.9+
Comment on attachment 318094 [details] [diff] [review]
Patch v1.0

check the patch of bug 430499 instead of this.
Attachment #318094 - Flags: review?(joshmoz)
(Assignee)

Updated

10 years ago
Attachment #318094 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Depends on: 430499
Whiteboard: [key hell]

Comment 3

10 years ago
we need to add a keyboard navigation litmus suite for these kind of tests
Flags: in-litmus?
Do we need to do anything here?  Do we need to split up the patch in bug 430499 ?
(In reply to comment #4)
> Do we need to do anything here?  Do we need to split up the patch in bug 430499
> ?

No, see the new patch. We don't need to split the patch.

When keyDown will not be called after performKeyEquivalent cases, we should not return without calling processKeyDown.
fixed by bug 430499.

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre
Status: RESOLVED → VERIFIED
Hardware: Macintosh → All
I added a set to cover these three keyboard options in the Mac 3.1 Keyboard test suite back when I created the Keyboard test suite. If we need them in another area in Litmus then I can add them there as well. I doubt many end users are actively running the Keyboard test suite so I think we should probably integrate a few of them into the FFT.

testgroup: 3.1 Mac Keyboard Test Suite | subgroup: FX 3.1 - Page Viewing Shortcuts
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.