431080 - Keyboard shortcuts for page zoom are not working using cmd and number pad

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Francesco Lodolo [:flod]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre

Mac OS X is in Italian, keyboard has Italian layout.

Combinations cmd+'+', cmd+'-' and cmd+'0' don't work on trunk using number pad keys: you can see the menu "View" flashing, but the zoom doesn't change (on the same machine Firefox 2 is working fine). 

The same combinations made with the standard keyboard keys work fine.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Patch v1.0

This is same bug as bug 423814. If Cmd key is pressed, the keyDown event is not fired after return NO from pKE.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Comment on attachment 318094 [details] [diff] [review]
Patch v1.0

check the patch of bug 430499 instead of this.

Comment 3

[Tony Chung [:tchung]]

we need to add a keyboard navigation litmus suite for these kind of tests

Comment 4

[Damon Sicore (:damons)]

Do we need to do anything here?  Do we need to split up the patch in bug 430499 ?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

(In reply to comment #4)
> Do we need to do anything here?  Do we need to split up the patch in bug 430499
> ?

No, see the new patch. We don't need to split the patch.

When keyDown will not be called after performKeyEquivalent cases, we should not return without calling processKeyDown.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

fixed by bug 430499.

-> FIXED

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre

Comment 8

[Marcia Knous [:marcia]]

I added a set to cover these three keyboard options in the Mac 3.1 Keyboard test suite back when I created the Keyboard test suite. If we need them in another area in Litmus then I can add them there as well. I doubt many end users are actively running the Keyboard test suite so I think we should probably integrate a few of them into the FFT.

testgroup: 3.1 Mac Keyboard Test Suite | subgroup: FX 3.1 - Page Viewing Shortcuts