432182 - Unfocusing Gecko view doesn't hide focus ring until mouse-over

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is probably a Cocoa Widgets bug, but I haven't even had a chance to check Firefox yet, or find a regression range, etc.

STR:

1. Click in a text field somewhere (e.g., a bug)
2. Click in the location bar

ER: Focus ring disappears from the text field when the location bar gains focus.
AR: Focus ring remains on text field

Comment 1

[philippe (part-time)]

One tidbit: after steps 1 and 2, move cursor over the focussed textfield the focus ring disappears (tested with the URL field on this page).

I can't repro this with Minefield (Gecko/2008050420 Minefield/3.0pre).

Comment 2

[philippe (part-time)]

This has been the case since the 2.0a1pre (1.9b4pre 2008020800) build. Before that, we didn't have focus rings around those form controls (2008020701 and older builds).

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-07+01%3A00%3A00&maxdate=2008-02-08+00%3A00%3A00&cvsroot=%2Fcvsroot

bug 415466, but also bug 416113.

Comment 3

[Stuart Morgan]

Moving to core; the widget should be unfocused and redrawn when Gecko loses focus, which would need to happen in the widget layer. Minefield won't have this problem because it's not possible to focus something in the window that isn't Gecko.

I'm not sure if the fact that the focus ring stays active in background windows is the same underlying issue, or something separate.

Comment 4

[Stuart Morgan]

Clarifying the summary now that this is in Widget (note that the STR are for Camino). Also, removing the regression keyword since it turns out that we have this bug in Camino branch as well on all focus-ring-drawing controls--it was just much less noticeable since we didn't have the bigger and more commonly present text-field focus ring.

Note the very similar bug 355098.

Comment 5

[Stuart Morgan]

I was pleased to find that this was fixed with the landing of bug 54488 (as was the background issue I mentioned in comment 3). There's a slight lag in the removal of the ring, but that's certainly livable.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Reopening since bug 54488 was backed out.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This WFM in our experimental 1.9.2 builds; probably the relanding of the improved bug 54488 fixed it.