432188 - Swap Thunderbird to use www.mozillamessaging.com for in-product pages

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

Currently, Thunderbird still uses ab-CD.www.mozilla.com for in-product pages. Now that there is mozillamessaging.com, it should use it. This patch swaps out ab-CD.www.mozilla.com for www.mozillamessaging.com in the places that count (I believe).

Questions:
* Should browser.safebrowsing.warning.infoURL point to a Thunderbird-specific page on www.mozillamessaging.com?
* Should UTTypeReferenceURL in mail/components/search/mdimporter/Info.plist be changed to something on www.mozillamessaging.com even though it's one of those URIs-that-look-like-URLs-etc.?

If this patch is approved, I'll file the appropriate bugs against the www.mozillamessaging.com component to make sure all these pages exist.

Comment 1

[Magnus Melin [:mkmelin]]

I think spellchecker.dictionaries.download.url should still hard code "thunderbird" - considering Icedove (and possibly others). xref bug 415890.

Comment 2

[Reed Loden [:reed]]

(In reply to comment #1)
> I think spellchecker.dictionaries.download.url should still hard code
> "thunderbird" - considering Icedove (and possibly others). xref bug 415890.

Well, it doesn't make sense to have some use %APP% and some not. Seems better to move them all to the same one and then change later (if needed). I personally consider that an Icedove bug and not a Thunderbird bug.

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 319331 [details] [diff] [review]
patch - v1

These are more product management and website management decisions than code (which is part of why I told you that we didn't need another bug, that davida could just put a patch in his relnote bug when he was ready to have one, since we didn't have it off in webmonkey land, shortly before you ignored me and moved it off into webmonkey land.)

Happy to do a code review, once he has decided what he wants to have where, though.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I'm going to leave this for David to make a call on tomorrow.

Comment 5

[David Ascher (:davida)]

Release notes should live on mozillamessaging.com, so +1 on the concept.

App updates aren't ready to be made from mozillamessaging.com, though.

I'm not sure about the answers to the other two questions:

> Should browser.safebrowsing.warning.infoURL point to a Thunderbird-specific
page on www.mozillamessaging.com?

When does that URL show up in Tb?  In general, I suspect the answer to this question is no, but I need to know more.

> Should UTTypeReferenceURL in mail/components/search/mdimporter/Info.plist be
changed to something on www.mozillamessaging.com even though it's one of those
URIs-that-look-like-URLs-etc.?

I'd also like more info on what that URL is about.



On timing: it'd be good to get it in a1, but if it gets hung up for whatever reason we can do a redirect from mozilla.com, but that's likely to involve more people, be messier, etc.

Comment 6

[David Ascher (:davida)]

Slight change in plans: I've told Rick to go ahead and build 3.0a1 w/ the old URLs in product.  I'll file a bug on the release notes URL for mozilla.com to redirect to mozillamessaging.com, as I suspect that's the only really important one for a1.

Each of those URLs looks like a new bug which should be filed against mozillamessaging.com, though.

Comment 7

[David Ascher (:davida)]

filed bug 432509 to deal with the redirect.

Comment 8

[David Ascher (:davida)]

Didn't mean to reassign

Comment 9

[Magnus Melin [:mkmelin]]

(In reply to comment #5)
> > Should browser.safebrowsing.warning.infoURL point to a Thunderbird-specific
> page on www.mozillamessaging.com?
> 
> When does that URL show up in Tb?  In general, I suspect the answer to this
> question is no, but I need to know more.

Currently the url is never used in thunderbird.

Comment 10

[Reed Loden [:reed]]

Reminder: Need to change other-licenses/branding/thunderbird/branding.nsi, too.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

This bug itself is not blocking; marking 3.0a1-.

Comment 12

[David Ascher (:davida)]

Comment on attachment 319331 [details] [diff] [review]
patch - v1

I'm doing random comments, not as a formal review, but to close various loops:

>Index: mail/app/profile/all-thunderbird.js
>-pref("app.update.url.manual", "http://%LOCALE%.www.mozilla.com/%LOCALE%/%APP%/");
>+pref("app.update.url.manual", "http://www.mozillamessaging.com/%LOCALE%/%APP%/");

Update URLs shouldn't point to mozillamessaging.com, or at least not without first a redirect back from mozillamessaging back to mozilla.com (which we could do, but i'm not sure it's that

>-pref("app.update.url.details", "http://%LOCALE%.www.mozilla.com/%LOCALE%/%APP%/releases/");
>+pref("app.update.url.details", "http://www.mozillamessaging.com/%LOCALE%/%APP%/releases/");

This, I suppose, is ok, except that the /releases URL isn't setup -- I switched to early_releases in 3.0a1, but that may have been a mistake.

> // Release notes URL
>-pref("app.releaseNotesURL", "http://%LOCALE%.www.mozilla.com/%LOCALE%/%APP%/%VERSION%/releasenotes/");
>+pref("app.releaseNotesURL", "http://www.mozillamessaging.com/%LOCALE%/%APP%/%VERSION%/releasenotes/");

That we're ready for.

>-pref("extensions.blocklist.detailsURL", "http://%LOCALE%.www.mozilla.com/%LOCALE%/blocklist/");
>+pref("extensions.blocklist.detailsURL", "http://www.mozillamessaging.com/%LOCALE%/blocklist/");

I can't think of a reason to maintain a separate blocklist from moco.  can anyone?

>-pref("spellchecker.dictionaries.download.url", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/thunderbird/%VERSION%/dictionaries/");
>+pref("spellchecker.dictionaries.download.url", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/%VERSION%/dictionaries/");

Seems right or wrong depending on whether %APP% is thunderbird even for shredder.

Comment 13

[Reed Loden [:reed]]

(In reply to comment #12)
> >Index: mail/app/profile/all-thunderbird.js
> >-pref("app.update.url.manual", "http://%LOCALE%.www.mozilla.com/%LOCALE%/%APP%/");
> >+pref("app.update.url.manual", "http://www.mozillamessaging.com/%LOCALE%/%APP%/");
> 
> Update URLs shouldn't point to mozillamessaging.com, or at least not without
> first a redirect back from mozillamessaging back to mozilla.com (which we could
> do, but i'm not sure it's that

That pref is used for pointing the user to a page where he/she can manually download an updated version of Thunderbird in case an AUS update failed. That seems like it should definitely be on mozillamessaging.com and not mozilla.com.

> >-pref("extensions.blocklist.detailsURL", "http://%LOCALE%.www.mozilla.com/%LOCALE%/blocklist/");
> >+pref("extensions.blocklist.detailsURL", "http://www.mozillamessaging.com/%LOCALE%/blocklist/");
> 
> I can't think of a reason to maintain a separate blocklist from moco.  can
> anyone?

That's not a separate blocklist. That's just the details page users are pointed to when one of their add-ons is blocklisted. Since Firefox and Thunderbird have mostly separate add-ons, it seems like it would make more sense to have separate blocklist details pages. However, as long as Thunderbird blocklisted add-ons can be added to the www.mozilla.com page, that same page could be used.

> >-pref("spellchecker.dictionaries.download.url", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/thunderbird/%VERSION%/dictionaries/");
> >+pref("spellchecker.dictionaries.download.url", "https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/%VERSION%/dictionaries/");
> 
> Seems right or wrong depending on whether %APP% is thunderbird even for
> shredder.

%APP% is always "thunderbird", no matter the branding.

Comment 14

[David Ascher (:davida)]

reed, do you think you'll be able to get this done soonish?  I'd like to get it in by a2.

Comment 15

[David Ascher (:davida)]

Comment on attachment 319331 [details] [diff] [review]
patch - v1

this patch at least seems fine to me.

Comment 16

[Reed Loden [:reed]]

Attachment: patch - v2

This update removes the change to extensions.blocklist.detailsURL and changes other-licenses/branding/thunderbird/branding.nsi to use Mozilla Messaging instead of mozilla.org stuff (use other-licenses/branding/firefox/branding.nsi as a comparison).

Sorry for the long delay!

Comment 17

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> * Should UTTypeReferenceURL in mail/components/search/mdimporter/Info.plist be
> changed to something on www.mozillamessaging.com even though it's one of those
> URIs-that-look-like-URLs-etc.?

Nope, because it isn't. A UTTypeReferenceURL is what you load in your browser when you run across a com.mozilla.thunderbird.mozeml file, and wonder just what it is and how it's structured, like the documentation example of using http://www.w3.org/Graphics/JPEG/ for public.jpeg. So it should point to a hypothetical devmo page explaining our indexable file format, once a hypothetical person hypothetically writes one.

Comment 18

[Phil Ringnalda (:philor)]

Comment on attachment 327349 [details] [diff] [review]
patch - v2

Seems reasonable, thanks.

Comment 19

[David Ascher (:davida)]

Comment on attachment 327349 [details] [diff] [review]
patch - v2

looks ok.  we should file bugs on mozillamessaging.com for each of the pages that we need to have happen there.

Comment 20

[Mark Banner (:standard8)]

If we're shipping Alpha 2 with unofficial (Shredder) branding then I think we need to change the unofficial branding for the installer as well:

http://mxr.mozilla.org/seamonkey/source/mail/installer/windows/nsis/branding.nsi

Comment 21

[Reed Loden [:reed]]

Checking in mail/app/profile/all-thunderbird.js;
/cvsroot/mozilla/mail/app/profile/all-thunderbird.js,v  <--  all-thunderbird.js
new revision: 1.119; previous revision: 1.118
done
Checking in other-licenses/branding/thunderbird/branding.nsi;
/cvsroot/mozilla/other-licenses/branding/thunderbird/branding.nsi,v  <--  branding.nsi
new revision: 1.4; previous revision: 1.3
done