432409 - Folder drop down in Bookmark Contextual Dialog doesn't use special icons (bookmarks toolbar, bookmarks menu, unsorted bookmarks)

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Normal icons for special folders in folder drop down

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre ID:2008050506

With bug 424286 we have different icons for all special folders which already show up within the folder list of the Bookmarks Contextual Dialog. But if you open the folder drop down you can see that the icons for normal folders are used. They should also be changed to show up the new icons.

Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or shall I file a new bug?

Comment 1

[Stephen Horlander [:shorlander]]

(In reply to comment #0)
> Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or
> shall I file a new bug?
> 

That bug is pretty specific and already checked-in. A new bug would probably be best.

Comment 2

[Stephen Horlander [:shorlander]]

(In reply to comment #1)
> (In reply to comment #0)
> > Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or
> > shall I file a new bug?
> > 
> 
> That bug is pretty specific and already checked-in. A new bug would probably be
> best.
> 
Actually do we need separate bugs? The same rules should work for every platform.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Perhaps not blocking but wanted1.9?

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

We'd take a safe patch, but yeah, this doesn't block.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Update dropdown to use relevant icons

This should update all platforms to use the relevant icons. Depends on the Tango checkin of bug 424286 though.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319698 [details] [diff] [review]
Update dropdown to use relevant icons

a1.9=beltzner

Comment 7

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.217; previous revision: 1.216
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.155; previous revision: 1.154
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.218; previous revision: 1.217
done

Comment 8

[Luke Iliffe (Harlequin99)]

Although the special icons are in the drop down list now, if you select any of them the generic folder icon remains in the Folder select box. When you first press ctrl+D to initially bring up the dialog the bookmarks menu is automatically selected and this too still has the generic folder icon. 

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> Although the special icons are in the drop down list now, if you select any of
> them the generic folder icon remains in the Folder select box. When you first
> press ctrl+D to initially bring up the dialog the bookmarks menu is
> automatically selected and this too still has the generic folder icon.

Luke, can you file a new bug on that?

Comment 10

[Luke Iliffe (Harlequin99)]

I have filed bug 432848 and made it depend on this one. If someone feels that is not appropriate then please remove. 

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In general this was the topic of my bug. So no idea why we need one more bug. But now it's filed. Lets move it to the depends list.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking Verified the first half of this issue. Bug 432848 is still to be done.