Closed Bug 432409 Opened 14 years ago Closed 14 years ago

Folder drop down in Bookmark Contextual Dialog doesn't use special icons (bookmarks toolbar, bookmarks menu, unsorted bookmarks)

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: whimboo, Assigned: shorlander)

References

Details

Attachments

(2 files)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050506 Minefield/3.0pre ID:2008050506

With bug 424286 we have different icons for all special folders which already show up within the folder list of the Bookmarks Contextual Dialog. But if you open the folder drop down you can see that the icons for normal folders are used. They should also be changed to show up the new icons.

Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or shall I file a new bug?
(In reply to comment #0)
> Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or
> shall I file a new bug?
> 

That bug is pretty specific and already checked-in. A new bug would probably be best.
(In reply to comment #1)
> (In reply to comment #0)
> > Kevin or Stephen, could the remaining work for OS X be covered in bug 430693 or
> > shall I file a new bug?
> > 
> 
> That bug is pretty specific and already checked-in. A new bug would probably be
> best.
> 
Actually do we need separate bugs? The same rules should work for every platform.

Perhaps not blocking but wanted1.9?
Flags: blocking-firefox3?
We'd take a safe patch, but yeah, this doesn't block.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
This should update all platforms to use the relevant icons. Depends on the Tango checkin of bug 424286 though.
Attachment #319698 - Flags: ui-review?(beltzner)
Attachment #319698 - Flags: review?
Assignee: nobody → stephen
Status: NEW → ASSIGNED
Attachment #319698 - Flags: ui-review?(beltzner)
Attachment #319698 - Flags: ui-review+
Attachment #319698 - Flags: review?(rflint)
Attachment #319698 - Flags: review?
Attachment #319698 - Flags: review?(rflint) → review+
Comment on attachment 319698 [details] [diff] [review]
Update dropdown to use relevant icons

a1.9=beltzner
Attachment #319698 - Flags: approval1.9+
Keywords: checkin-needed
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.217; previous revision: 1.216
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.155; previous revision: 1.154
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.218; previous revision: 1.217
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Although the special icons are in the drop down list now, if you select any of them the generic folder icon remains in the Folder select box. When you first press ctrl+D to initially bring up the dialog the bookmarks menu is automatically selected and this too still has the generic folder icon. 
(In reply to comment #8)
> Although the special icons are in the drop down list now, if you select any of
> them the generic folder icon remains in the Folder select box. When you first
> press ctrl+D to initially bring up the dialog the bookmarks menu is
> automatically selected and this too still has the generic folder icon.

Luke, can you file a new bug on that?
Blocks: 432848
I have filed bug 432848 and made it depend on this one. If someone feels that is not appropriate then please remove. 
In general this was the topic of my bug. So no idea why we need one more bug. But now it's filed. Lets move it to the depends list.
No longer blocks: 432848
Depends on: 432848
Marking Verified the first half of this issue. Bug 432848 is still to be done.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.