424286 - Use different icons for all special folders (all bookmarks, bookmark menu, bookmark sidebar, tags, history, unsorted bookmarks)

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The latest windows icon drop includes several new places icons:

/browser/themes/winstripe/browser/places/bookmarksMenu.png
/browser/themes/winstripe/browser/places/bookmarksToolbar.png
/browser/themes/winstripe/browser/places/history.png
/browser/themes/winstripe/browser/places/importAndBackup.png
/browser/themes/winstripe/browser/places/organize.png
/browser/themes/winstripe/browser/places/view.png

I'll attach mockups of where these icons should be used, let me know if you want me to split this off into individual bugs.

I'm cc'ing the linux and OS X themers since ideally we should use the same icon names across the different themes.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Mockup of where to use the new places icons

Here is a mockup of where to use the new places icons.  This mockup also includes the use of some existing icons, like tag.png

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Library window on OS X

Example of how these three files could appear on OS X without any accompanying text.

/browser/themes/winstripe/browser/places/importAndBackup.png
/browser/themes/winstripe/browser/places/organize.png
/browser/themes/winstripe/browser/places/view.png

Comment 3

[Michael Ventnor]

Linux is already alright for the importAndBackup, organize and view images.

Question though: what CSS would we need to separate the different types of folders or queries?

Comment 4

[Michael Monreal [:micmon]]

Alex, some time ago we had an agreement not to use icons for view, organize and importAndBackup.. did this change?

Michael: if those icons are meant not to be removed on Linux, we will need new ones. None of the current stock icons does fit here.

bookmarksMenu.png and bookmarksToolbar.png should be in by now, see bug 418868

Comment 5

[Michael Monreal [:micmon]]

Attachment: history.png for linux

history.png is ready but not yet checked in

Comment 6

[Reed Loden [:reed]]

(In reply to comment #5)
> history.png is ready but not yet checked in

It's actually in gnomestripe as a part of Toolbar.png and Toolbar-small.png, so we can just reuse it there. No need to add a file with the same icon we already have and can use.

Comment 7

[Michael Ventnor]

IMO I find that the stock icons fit in the functions very well (I was very careful to select the stock icons when I first themed the Organizer), and the fact that they are stock icons and thus change with the theme is a big plus.

Comment 8

[Michael Monreal [:micmon]]

(In reply to comment #7)
> IMO I find that the stock icons fit in the functions very well (I was very
> careful to select the stock icons when I first themed the Organizer), and the
> fact that they are stock icons and thus change with the theme is a big plus.
> 

Organize = gtk-properties: normally used for properties of a file
Views = gtk-sort-descending: normally used for sorting Z to A
Import and Backup = gtk-revert-to-saved-ltr: normally used to undo all changes since the last save

I don't see how any of those icons fits in well. The gtk-properties (the easiest to replace...) is perhaps generic enough to not do much harm but the other two have a totally different meaning. The make things worse, "gtk-revert-to-saved-ltr" is also used for "import" where it fits even less.

So, Alex, do we want icons there now?

Comment 9

[Michael Ventnor]

(In reply to comment #8)
> (In reply to comment #7)
> > IMO I find that the stock icons fit in the functions very well (I was very
> > careful to select the stock icons when I first themed the Organizer), and the
> > fact that they are stock icons and thus change with the theme is a big plus.
> > 
> 
> Organize = gtk-properties: normally used for properties of a file
> Views = gtk-sort-descending: normally used for sorting Z to A
> Import and Backup = gtk-revert-to-saved-ltr: normally used to undo all changes
> since the last save
> 
> I don't see how any of those icons fits in well. The gtk-properties (the
> easiest to replace...) is perhaps generic enough to not do much harm but the
> other two have a totally different meaning.

gtk-sort-descending is to do with sorting, which is precisely what the views menu does. gtk-revert-to-saved is related to getting back what you had saved, one of the main functions of _Import_ and Backup.

I don't think this anywhere near outweighs the benefits of stock icon use.

Comment 10

[Michael Monreal [:micmon]]

Problem is they are all stock _action_ icons so they where not meant as generic icons for roughly related tasks or as category icons.

Comment 11

[Wesley Johnston (:wesj)]

Just a note that this is either a dup of the Windows Bug 420551, or that this has already been split off.

Comment 12

[Andreas Nilsson (:andreasn)]

I have to agree with Michael Monreal. The current icons used feels a bit confusing because they are commonly used for completely different things.
I was also under the impression that we wouldn't be using icons there on Linux.

Comment 14

[AKIHIRO Misaki (a.k.a Kuden)]

Please use CSS. 
Please do not Hard-coded chrome URI of icons. 
This is really difficult to do theming. 

example (good):
#bookmarksToolbarFolderMenu
treechildren::-moz-tree-image(title, container, bookmarksToolbar)
treechildren::-moz-tree-image(title, container, bookmarksMenu)
treechildren::-moz-tree-image(title, container, historyContainer)

example (bad):
<menu id="bookmarksToolbarFolderMenu"
image="chrome://browser/skin/places/bookmarksToolbar.png"/>
#define BOOKMARKS_MENU_ICON_URI "chrome://browser/skin/places/bookmarksMenu.png"
#define BOOKMARKS_TOOLBAR_ICON_URI "chrome://browser/skin/places/bookmarksToolbar.png"
#define HISTORY_CONTAINER_ICON_URI "chrome://browser/skin/places/history.png"

Comment 15

[Stephen Horlander [:shorlander]]

Are the icons for Bookmarks Toolbar, History, Bookmarks Menu, etc. hooked up? I can't find where to set them unless I am just overlooking it.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

On Windows we should *not* be including the icon for the Bookmark Toolbar in the drop-down menu. We don't include any icons there for things that aren't bookmarks.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #16)
> On Windows we should *not* be including the icon for the Bookmark Toolbar in
> the drop-down menu. We don't include any icons there for things that aren't
> bookmarks.

Uh, ignore comment 16. Consider it an involuntary spasm. We've had icons there for a while now, and nobody's died. My bad.

Comment 18

[Mike Connor [:mconnor]]

Alex, please drive this with the various themes.

Comment 19

[Alex Faaborg [:faaborg] (Firefox UX)]

>Alex, some time ago we had an agreement not to use icons for view, organize and
>importAndBackup.. did this change?

Deciding what icons you want to use (or if you want to use icons) for the toolbar buttons is totally your call, based on what you think makes the most sense given the surrounding platform.  Similarly on OS X Stephen and Kevin can decide what icons make the most sense (as a suggestion icons out of the finder seem to fit well https://bugzilla.mozilla.org/attachment.cgi?id=310928) 

However for the icons in the tree view, side bar and menus, I think it would be best if all the platforms used reasonably consistent images.

Comment 20

[Alex Faaborg [:faaborg] (Firefox UX)]

>Are the icons for Bookmarks Toolbar, History, Bookmarks Menu, etc. hooked up? I
>can't find where to set them unless I am just overlooking it.

They are checked in on winstripe so we can use consistent file names with pinstripe and gnomestripe, however I don't think the files have been added to a chrome manifest yet on any platform. 

Comment 21

[Reed Loden [:reed]]

(In reply to comment #20)
> They are checked in on winstripe so we can use consistent file names with
> pinstripe and gnomestripe, however I don't think the files have been added to a
> chrome manifest yet on any platform. 

The icons are already in the chrome manifests for winstripe.

Comment 22

[Stephen Horlander [:shorlander]]

Attachment: OS X Library Window

(In reply to comment #19)
> However for the icons in the tree view, side bar and menus, I think it would be
> best if all the platforms used reasonably consistent images.
> 

Here is what I have currently implemented for OS X.

I would say they are fairly consistent. Although I didn't put a full fledged book on the toolbar folder since the working area was so small. I thought a blue star on a toolbar worked well enough.

Comment 23

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #22)
> Here is what I have currently implemented for OS X.

Stephen, Were you able to apply those icons to the live Library (and if so how did you do it), or is that a mock-up?

Comment 24

[mcdavis941 (sporadically reading bugmail)]

Are the tree-cell properties available to select in CSS the cells for these icons in the Library sidebar and main browser sidebar?  I spent some time looking through places.js and friends, but must have missed it if it's there.

Comment 25

[Kevin Gerich]

Stephen's organizer toolbar icons were checked in for Mac as part of bug 427555. The sidebar icons are also in there.

Comment 26

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Icon for all bookmarks (XP)

Use this icon for all bookmarks on XP

Comment 27

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Icon for all bookmarks (Vista)

Use this icon for all bookmarks on Vista

Comment 28

[Alex Faaborg [:faaborg] (Firefox UX)]

Um, perhaps I should clarify that I meant to say the icon is for the single item "All Bookmarks" in the left pane, and not actually all of the bookmarks :)

Comment 29

[mcdavis941 (sporadically reading bugmail)]

It looks like dirlisting/remote.png and dirlisting/local.png are represented as data: URIs in nsIndexedToHTML.cpp:

http://tinyurl.com/4x35c8
http://tinyurl.com/5xu7h5

Comment 30

[mcdavis941 (sporadically reading bugmail)]

Whoops wrong bug, meant Bug 424877.

Comment 31

[Asaf Romano (gone)]

Attachment: os x part

Comment 32

[Asaf Romano (gone)]

Attachment: both

Comment 33

[Alex Faaborg [:faaborg] (Firefox UX)]

Do we need to update gnomestripe?

Comment 34

[Reed Loden [:reed]]

(In reply to comment #33)
> Do we need to update gnomestripe?

Yes.

Comment 35

[Asaf Romano (gone)]

Do these icons fit there (both folders and toolbar images?)?

Comment 36

[Michael Monreal [:micmon]]

Gnomestripe todo:

- Icons for bookmarks menu/toolbar can be found here: https://bugzilla.mozilla.org/attachment.cgi?id=304998

- The history icon also needs to be replaced in gnomestripe (icon already in the Toolbar-small stripe)

- organize, view, importAndBackup: as the tango artists all agree that there should be no icons I don't see anyone redoing those... So we need a patch to disable them.

Comment 37

[Dietrich Ayala (:dietrich)]

Comment on attachment 314439 [details] [diff] [review]
both

removing review request. need gnomestripe changes, per previous comments.

Comment 38

[Alex Faaborg [:faaborg] (Firefox UX)]

Also I might have missed this when looking at the patch quickly, but are we giving live mark items in the right pane the livemark item icon? http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/livemark-item.png

Comment 39

[Asaf Romano (gone)]

> - organize, view, importAndBackup: as the tango artists all agree that there
> should be no icons I don't see anyone redoing those... So we need a patch to
> disable them.

As in, should I remove the current rules? They seem to use relevant stock icons.

Comment 40

[Alex Faaborg [:faaborg] (Firefox UX)]

>They seem to use relevant stock icons.


My understanding is that the stock icons are not semantically correct.  Also, the icon used for import and backup doesn't really match any of the other stock icons (perhaps it wasn't updated in someone else's visual refresh).  There has been some debate back and forth on what to do, but I'm going to side with the tango artists and ask that we remove the three stock icons.

Comment 41

[Michael Ventnor]

(In reply to comment #40)
> >They seem to use relevant stock icons.
> 
> 
> My understanding is that the stock icons are not semantically correct.  Also,
> the icon used for import and backup doesn't really match any of the other stock
> icons (perhaps it wasn't updated in someone else's visual refresh).  There has
> been some debate back and forth on what to do, but I'm going to side with the
> tango artists and ask that we remove the three stock icons.
> 

The stock icons are not semantically correct *in your theme*. In my theme (the much more common GNOME icon theme) the icon uses a sheet of paper instead of a floppy, has much nicer colours, and seems to fit things nicer.

I'm not sure why we should change it when some people would expect that style of icon due to the use of their theme.

Comment 42

[Alex Faaborg [:faaborg] (Firefox UX)]

It would appear that the icons are correct in terms of meaning (comment #9), but not in terms of use (specific single action vs. a group of related action).  I agree with monreal and Nilsson's position that we should remove the icons.  Also this is basically a Vista UI, so removing the icons will make it feel a little more native on Linux, more like a menu and less like a toolbar-ish thing.

Comment 43

[Asaf Romano (gone)]

Attachment: patch

Comment 44

[Dietrich Ayala (:dietrich)]

Comment on attachment 314453 [details] [diff] [review]
patch


>-    // For consistency, we always return a favicon for non-containers,
>-    // even if it is just the default one.
>-    var icon = node.icon || PlacesUtils.favicons.defaultFavicon;
>-    return icon ? icon.spec : "";
>+    var icon = node.icon;
>+    if (icon)
>+      return icon.spec;
>+    return "";
>   },

you removed the default favicon from regular items from all platforms here, but only re-added it via css to winstripe and pinstripe. was it intentional to leave out gnomestripe?

r=me otherwise

Comment 45

[Dietrich Ayala (:dietrich)]

nm previous comment, it's there.

Comment 46

[Asaf Romano (gone)]

mozilla/browser/components/places/content/treeView.js 1.62
mozilla/browser/themes/gnomestripe/browser/browser.css, 1.206
mozilla/browser/themes/gnomestripe/browser/places/organizer.css 1.13
mozilla/browser/themes/gnomestripe/browser/places/places.css 1.31
mozilla/browser/themes/pinstripe/browser/browser.css 1.141
mozilla/browser/themes/pinstripe/browser/places/places.css 1.22
mozilla/browser/themes/winstripe/browser/browser.css 1.195
mozilla/browser/themes/winstripe/browser/jar.mn 1.86
mozilla/browser/themes/winstripe/browser/places/allBookmarks-aero.png initial revision: 1.1
mozilla/browser/themes/winstripe/browser/places/allBookmarks.png initial revision: 1.1
mozilla/browser/themes/winstripe/browser/places/organizer.css 1.8
mozilla/browser/themes/winstripe/browser/places/places.css 1.23

Comment 47

[pal-moz]

"Tags" folder icon is not changed ?

Comment 48

[Darren Kalck [:D-Kalck]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre
The Bookmarks toolbar icon is not displayed in the bookmarks menu.

Comment 49

[Darren Kalck [:D-Kalck]]

(In reply to comment #47)
> "Tags" folder icon is not changed ?
> 

I think it should be changed and the unfiled bookmarks too.

Comment 51

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Checked with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040904 Minefield/3.0pre and everything looks fine.

So there are remaining issues on Windows and perhaps Linux?

Comment 52

[Ed Hume]

Remaining issues on Windows/Linux:

The "Recently Bookmarked" and "Recent Tags" menuitems are identical 

.bookmark-item[query="true"][container="true"]

They do not have separate ID's so they can take different icons.

My Aeon themes have separate icons for queries and tags. I would like to use them here to continue the metaphors already existing in the Library.

You work on this bug is not done. These items need separate ID's.

Comment 53

[Ed Hume]

Ditto the "most visited" menuitem.

Comment 54

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alex, shouldn't we reopen the bug until all issues are getting fixed?

Comment 55

[Alex Faaborg [:faaborg] (Firefox UX)]

Was there a ui-review for the patch?

Comment 56

[Ed Hume]

Another issue: the History item in the Places Library left panel shares the same icon as queries. But History is not really a query. Themers should be able to skin these icons differently from each other.

Nice icons in the default theme.

Comment 57

[Darren Kalck [:D-Kalck]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre

History and Queries icons are different to me in the left panel of the library window.

Comment 58

[Ed Hume]

Re- Comment #57.

You are so right. Sorry for that.

Should we have another bug for ui cleanup?

For example, the Most Visited item on the Bookmarks Toolbar is a folder icon. In the Places tree - sidebar and library - it is a query icon.

Comment 59

[Darren Kalck [:D-Kalck]]

Same for me here.

Comment 60

[Wesley Johnston (:wesj)]

> 
> For example, the Most Visited item on the Bookmarks Toolbar is a folder icon.
> In the Places tree - sidebar and library - it is a query icon.
> 
Thats Bug 428098.

Comment 61

[Alex Faaborg [:faaborg] (Firefox UX)]

Reopening for adding an icon for unsorted bookmarks, I'll try to get the icon soon.

Comment 62

[Asaf Romano (gone)]

Alex: note the missing "all bookmarks" icon on mac as well. Also, what should we style the Tags folder with?

Comment 63

[Alex Faaborg [:faaborg] (Firefox UX)]

Tags folder should be /browser/places/tag.png

I emailed Stephen and Kevin about the all bookmarks folder for pinstripe.

Comment 64

[Ed Hume]

Attachment: Bookmarks submenu showing query icons for tab containers.

Default theme, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041206 Minefield/3.0pre - Build ID: 2008041206

Comment 65

[Ed Hume]

Attachment: Tag containers in Library have tag icons

Default theme, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041206 Minefield/3.0pre - Build ID: 2008041206

Comment 66

[Ed Hume]

Another inconsistency:

Bookmarks > Recent Tags > [list of tags containers]

The list of tag containers are query icons (see Attachment #315304 [details])

Library > Tags folder > tag containers

The tag containers have tag icons ((see Attachment #315305 [details])

Shouldn't the containers under "Recent Tags" have tag icons?

Comment 67

[Alex Faaborg [:faaborg] (Firefox UX)]

>Shouldn't the containers under "Recent Tags" have tag icons?

yeah, they should

Comment 68

[Marco Bonardo [:mak]]

please, see also bug 428648 for work on tag containers (and adding of dayContainer, hostContainer attributes)
comment #66 is almost certainly on an old profile, different icons are due to the fact that tag patch actually applies only to new profiles (see bug 425161).

Comment 69

[Alex Faaborg [:faaborg] (Firefox UX)]

Icons for unsorted bookmarks are now in:

http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/places/unsortedBookmarks.png

http://mxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/places/unsortedBookmarks-aero.png

Other things that still need to be updated are:

Library window and sidebars:
    -use tag icon for "Tags" in the left pane
    -use live bookmark folder icon for live bookmarks

Bookmark contextual dialog:
    -use correct icons for menu, toolbar and unsorted in the drop down

I think that is everything, am I missing anything?

Stephen: any update on the OS X places icons?

Comment 70

[Michael Ventnor]

faaborg or monreal: does Linux have the unsorted bookmarks icon yet? I haven't been following nightlies closely lately...

Any other icons still needed for the Linux theme?

Comment 71

[Stephen Horlander [:shorlander]]

Attachment: OS X Places Icons

> Stephen: any update on the OS X places icons?
> 
I believe we have everything. Except I think the Tags folder should be showing as a tag.

Comment 72

[Michael Monreal [:micmon]]

(In reply to comment #70)
> faaborg or monreal: does Linux have the unsorted bookmarks icon yet? I haven't
> been following nightlies closely lately...
Not yet.

> Any other icons still needed for the Linux theme?
If we remove the importAndBackup, organize and view icons I think we are done. Besides that, the Error/Warning/Info icons are still not replaced with stpck icon usage, so they currently use the windows look.

Comment 73

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we get a status update here?

Comment 74

[Stephen Horlander [:shorlander]]

(In reply to comment #73)
> Can we get a status update here?
> 
Once Bug #430693 is taken care of OS X should be complete in this area.

Comment 75

[Stephen Horlander [:shorlander]]

Oops, forgot to say that the patch and the icon are ready and should be checked in tonight.

Comment 76

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano, as per comment 69, it looks like we need to:

 - hook up the unsorted bookmarks icon
 - fix up usage in library window and sidebars
 - fix up usage in add bookmark drop-down dialog

Comment 77

[Mike Beltzner [:beltzner, not reading bugmail]]

We'd take a patch here, but the issues from comment 76 don't block on their own. This change is CSS only, and could even be taken on branch.

Comment 78

[Gabriele Best [:Gabri]]

Latest Headlines and all RSS objects haven't the right icon on library under Windows.
They should be these http://mxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/livemark-item.png or http://mxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/livemark-folder.png

Comment 79

[Asaf Romano (gone)]

Attachment: patch

Comment 80

[Asaf Romano (gone)]

mozilla/browser/themes/gnomestripe/browser/places/places.css 1.34;
mozilla/browser/themes/pinstripe/browser/places/places.css 1.26
mozilla/browser/themes/winstripe/browser/places/places.css 1.26

Comment 81

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot

{Build ID: 2008050200}
I feel that treechildren::-moz-tree-image(container, OrganizerQuery_Tags) not works...

Comment 82

[Michael Ventnor]

Also, this should probably not be fixed until Linux gets the unsorted bookmarks icon. faaborg, any updates on that?

Comment 83

[Marco Bonardo [:mak]]

(In reply to comment #81)
> Created an attachment (id=318992) [details]
> Screenshot
> 
> {Build ID: 2008050200}
> I feel that treechildren::-moz-tree-image(container, OrganizerQuery_Tags) not
> works...
> 

most probably due to bug 431817

Comment 85

[Michael Monreal [:micmon]]

Attachment: Unfiled bookmarks icon (Tango)

My take on the still missing "unfiled bookmarks" icon for linux.

Comment 86

[Michael Ventnor]

Attachment: Tango patch

Integrates that icon into Gnomestripe.

Comment 87

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For tracking purposes please let us reopen this bug until the remaining work for Linux is done.

Comment 88

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319253 [details] [diff] [review]
Tango patch

a1.9=beltzner

Comment 89

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alex, the folder drop down inside the bookmarks contextual dialog doesn't support the new icons at all. Shall I file a new bug about that issue or is there no intention to show special icons at this place?

Comment 90

[Alex Faaborg [:faaborg] (Firefox UX)]

>Alex, the folder drop down inside the bookmarks contextual dialog doesn't
>support the new icons at all. Shall I file a new bug about that issue or is
>there no intention to show special icons at this place?

let's file a follow up bug on that.  Ideally the three special folders in that drop down (menu, toolbar, and unsorted) would get the right icons.

Comment 91

[Alex Faaborg [:faaborg] (Firefox UX)]

If winstripe and pinstripe were updated on 5/1, why do we still have the smart folder for Tags in the 2008050506 builds?

Comment 92

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #90)
> let's file a follow up bug on that.  Ideally the three special folders in that
> drop down (menu, toolbar, and unsorted) would get the right icons.

Filed bug 432409.

> If winstripe and pinstripe were updated on 5/1, why do we still have the smart
> folder for Tags in the 2008050506 builds?

You mean "Smart Bookmarks"? It is not automatically removed and has to be done manually. Only beta users will be affected from this folder.

Comment 93

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.79; previous revision: 1.78
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.35; previous revision: 1.34
done
RCS file: /cvsroot/mozilla/browser/themes/gnomestripe/browser/places/unsortedBookmarks.png,v
done
Checking in browser/themes/gnomestripe/browser/places/unsortedBookmarks.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/unsortedBookmarks.png,v  <--  unsortedBookmarks.png
initial revision: 1.1
done