432568 - Thunderbird should use unified toolbar styling on OS X

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Justin Dolske [:Dolske]]

Bug 303110 added core support for unifying the menu bar, and bug 431831 added Firefox theme changes for inactive unified toolbars. Thunderbird should do something similar to fit in better on OS X.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

This adds unified styling to mail/themes/pinstripe/.

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 319709 [details] [diff] [review]
Patch v.1

Updating review flags per dmose.

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 319709 [details] [diff] [review]
Patch v.1

>+    /* background: url("chrome://browser/skin/radio-selected-bg.png") repeat-x * center center; */

Ahem.

Comment 4

[Justin Dolske [:Dolske]]

Oops, forgot to deal with that as I was cutting and pasting from the Firefox CSS. It's usable without that image, but it should just be packaged up in Thunderbird too.

Comment 5

[Phil Ringnalda (:philor)]

There's probably minor polish I haven't spotted (and we could certainly use a whole new icon set that expects a darker background), but the only other really glaring thing I see is that toggling the contacts sidebar in the compose window looks really, really evil.

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 319709 [details] [diff] [review]
Patch v.1

I still haven't made sure I'm right in thinking that getting the contacts sidebar button to look right is going to take a new image, but either way I'm happy to take this much (once the prefs image actually exists, instead of being commented out) and have that be a separate followup bug.

Comment 7

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Uncomments the CSS to the pref window and adds referenced image.

Yeah, the sidebar should be handled separately. It doesn't look any different with/without the unified toolbar, but definitely should be styled to be more Maclike (like the FF sidebar).

Comment 8

[Phil Ringnalda (:philor)]

Attachment: What I'm talkin' about, Willis

I didn't explain myself well enough: what I meant was not the sidebar itself, but the <toolbarbutton type="checkbox"> you can add by customizing the toolbar of the compose window.

Because Fx uses different images with a dark background for the "checked" state of its Bookmarks and History buttons, it doesn't override the "dark grey left and right borders, light grey background" default appearance for checked buttons, only unsets it for those two. That leaves any extension using a type="checkbox" button looking like crap, so even if we decide to do the Contacts button like Fx, with a separate image for the checked state, we still need to make a default appearance for extensions that's less horrifying, and we should do it here, since it's a part of switching to unified (which just happens to not be something we can port from Fx, since they dropped the ball).

Sadly, since native Icon Buttons don't have any toggled appearance, we'll have to make something up, just like the old appearance was made up.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 323335 [details] [diff] [review]
Patch v.2

Okay, you wore me down with your incessant pleading: I filed bug 437909 on the type="checkbox" button part, and r=me and thank you for doing the work on this part.

Comment 10

[Justin Dolske [:Dolske]]

At last, my plan comes together!

Now we begin the staredown over the not-yet-checked-in patch.

Comment 11

[Justin Dolske [:Dolske]]

I am weak and envious of the shiny.

Checking in mail/themes/pinstripe/mail/jar.mn;
  new revision: 1.18; previous revision: 1.17
Checking in mail/themes/pinstripe/mail/messenger.css;
  new revision: 1.8; previous revision: 1.7
Checking in mail/themes/pinstripe/mail/primaryToolbar.css;
  new revision: 1.16; previous revision: 1.15
Checking in mail/themes/pinstripe/mail/addrbook/addressbook.css;
  new revision: 1.7; previous revision: 1.6
Checking in mail/themes/pinstripe/mail/compose/messengercompose.css;
  new revision: 1.10; previous revision: 1.9
Checking in mail/themes/pinstripe/mail/preferences/preferences.css;
  new revision: 1.11; previous revision: 1.10
Checking in mail/themes/pinstripe/mail/preferences/radio-selected-bg.png;
  initial revision: 1.1