437909 - Pinstripe needs a way to handle toolbarbutton type="checkbox" with unified toolbars (Contacts button and quick filter toggle are too light)

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

The default styling for a <toolbarbutton type="checkbox"> (like the Contacts button than can be added to the compose window toolbar) from toolkit's Pinstripe is dark grey left and right borders, light grey background. That worked fine with light grey toolbars that had top and bottom borders and that didn't change color when the window was inactive, but now it looks glaringly wrong - the borders disappear for active windows, and the light grey looks totally out of place (though it looks okayish for inactive windows).

We need something else, but what is a hard problem. There's no native thing to imitate since Icon Buttons don't have a checked state. People imitating it with native buttons usually do something like change the image, which Firefox did for their sidebar toggling buttons, and which we could do for our one instance, but extension developers can't be expected to do for just one platform that they may not even have to test. Whatever we do probably has to work against both a dark and a light background, since unless I'm missing something, a button in an arbitrary location is going to need expensive CSS to find out whether or not the window is active.

Comment 1

[David Ascher (:davida)]

Retriaging according to new policy for flags.  

https://wiki.mozilla.org/Thunderbird:Release_Driving