43280 - No Plugin Downloader Plugin!

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[staublis]

when i visit the url above, i got this message:

No Plugin Downloader Plugin!
Netscape cannot find the Plugin Downloader Plugin. Without the Plugin Downloader
Plugin, you cannot automatically download and install plugins.
Please visit http://www.netscape.com/ to install de Plugin Downloader Plugin.

the message has the questionmark "?" icon and an only an OK button !

i use latest build. (there was an error durring "complete" installation, may be
that's a problem)

what a error message ! dummy users are lost...

Comment 1

[Andreas Franke (gone)]

*** Bug 43281 has been marked as a duplicate of this bug. ***

Comment 2

[Doron Rosenberg (IBM)]

url is 404 error.

i have the suspicion this was a ns4 error.

Comment 3

[Asa Dotzler [:asa]]

actaully I've seen this in mozilla.  re-opening.  Reporter, can you point us to
a URL that works.

Comment 4

[Doron Rosenberg (IBM)]

confirmed. I see this when the page has java in it. adding workign url!

Comment 5

[staublis]

this is the original url, which gives me the err msg:
http://www.pilatusnet.ch/info/chat/chat.htm

Comment 6

[Zach Lipton [:zach]]

I can confirm this with 2000062608 on Mac OS 9. However, it seems to me that
this is a feature for Netscape?s use and that they will provide the plug-in. 

Comment 7

[Doron Rosenberg (IBM)]

cc: ed burns, who put in this code (http://bonsai.mozilla.org/cvsblame.cgi?file=
mozilla/xpfe/components/xfer/resources/locale/en-US/downloadProgress.properties).

asa, ed burns - should this be in mozilla or be a netscape only thing?
If it is in mozilla, then the text should change to "mozilla could not find..."

Comment 8

[edburns]

How are we working localization things with respect to mozilla and netscape.  
For the commercial Netscape product we should use Netscape, for mozilla, we 
should use mozilla.  

Please note that this dialog is supposed to be annoying.  It's not supposed to 
pop up, because everyone is supposed to have a "Default Plugin" in their 
plugins directory after install.  

Comment 9

[Asa Dotzler [:asa]]

cc:'ing Ben Goodger for his input.

Comment 10

[Peter "jag" Annema]

"Please note that this dialog is supposed to be annoying.  It's not supposed to 
pop up, because everyone is supposed to have a "Default Plugin" in their 
plugins directory after install."

That's nice, but could this code be turned off then, or have a "don't show 
again" option until the default plugin is included/works?

It's really annoying clicking that dialog away on a page with multiple applets 
(click, click, click, click, ...)

Comment 11

[edburns]

Good idea Peter.

I'll see what Eric Krock thinks about me modifying the code so that we have 
a "don't show this again" feature on this.

Ed

Comment 12

[ckritzer (gone)]

This affects all platforms (see this on 2000-06-28-xx commercial builds).

Also, this blocks automation testing of applets, some objects, and some parnode
testcases. 

Comment 13

[ckritzer (gone)]

updated status whiteboard

Comment 14

[R.K.Aa.]

*** Bug 44416 has been marked as a duplicate of this bug. ***

Comment 15

[Asa Dotzler [:asa]]

edburns, do you want to take this bug off of my plate.  

Comment 16

[leger]

Nominating for dogfood, blocking QA automation.

Comment 17

[edburns]

I can own this.  

As Eric Krock suggested earlier, I can make the dialog have a "don't show this 
message again" button.  The persistent state of this button will be saved by a 
pref.  We can have the dialog not show be default in the in the daily builds 
and have it show be default in the production builds, like PR2.

How does that sound?

Comment 18

[edburns]

I'll take this.

Comment 19

[Peter "jag" Annema]

Sounds good :-)

Comment 20

[Jay Patel [:jay]]

Putting on [dogfood+] radar. 

Comment 21

[edburns]

As this isn't nsbeta2+ I'm not going to be looking at this right away.  Also, 
since the default plugin now gets installed in every possible scenario, it's 
more a problem on platforms for which there is no default plugin.

Comment 22

[edburns]

Changing target milestone.

Comment 23

[Doron Rosenberg (IBM)]

I'm not getting this on 2000071108 anymore, but rather, the behaviour is liek
4.x, where the area where the plugin is embedded gets a iframe-like thing with
the text "click here to get plugin".

Comment 24

[edburns]

Is this still dogfood+?  

Comment 25

[Doron Rosenberg (IBM)]

It's gone nope (the pop-up), so I think this fixed? 

Comment 26

[Peter "jag" Annema]

Could you specify for which platform you're not getting the popup anymore?

On linux, build ID 2000071720, I'm still getting the popup.

On Windows 95 the default plugin is now available and packaged into the 
nightlies, so there you'll get a "Click here to download the plugin" where the 
plugin would be. Seeing this on build ID 2000071810, but it's been there for a 
while now.

So, this bug still isn't fixed, though we may not see it for much longer as 
hopefully default plugins are written and made available for other platforms.

Comment 27

[ckritzer (gone)]

This bug still exists on:
- MacOS9 2000-07-18-10-M17 Commercial
- Linux6 2000-07-19-10-M17 Commercial

But seems to be working fine on:
- Win98  2000-07-19-11-M17 Commercial


Can't test with the latest build of ns6.  Will check again against today's 
builds.

Comment 28

[edburns]

This all started with bug 41197.

Comment 29

[edburns]

Attachment: Fix for this bug, first iteration

Comment 30

[ckritzer (gone)]

Changing component from Browser-General to Plugins.

Comment 31

[av (gone)]

The patch looks good to me. ar=av

Couple of things. Can we make just a single appearence of this dialog on a page 
with more than one plugins with the same mime type. I don't believe this is good 
idea to show several identical dialog boxes. This also applies to the actual 
default plugin but I am going to fix it there.

Checkbox title. It seems mmm... a little cumbersome to me. And how did we come 
up with 'Plugin Downloader Plugin' wording? Is this a new 'official' term for 
the default plugin? All this is not important at all I am just curious.

Comment 32

[edburns]

Attachment: Fix for this bug, second iteration.

Comment 33

[edburns]

I now only show the dialog once per mime-type per session.  I use an 
nsHashTable with nsStringKey(mimeType) to do this.

As for the names, I made them up.  I was hoping someone with editorial control 
would come by and fix all the .properties files anyway.

Comment 34

[av (gone)]

OK, I was thinking of limiting showing the dialog per page not per session but I 
cannot quickly weigh advantages and disadvantages for either solution. So 
one-per-session thing is fine to me. r=av.

Comment 35

[edburns]

Marking fixed.

Comment 36

[Doron Rosenberg (IBM)]

can a linux and a mac person verify this? adding verifyme keyword

Comment 37

[Peter "jag" Annema]

Linux, build ID 2000072020

This seems to work. Dialog pops up, click OK and it's gone for the rest of the 
session. Next time you start Mozilla it pops up again, mark the checkbox, and 
it's gone 'forever'.

Verifying fixed for Linux.

Comment 38

[Doron Rosenberg (IBM)]

cc: asa

can you verify this on a mac? thanks!

Comment 39

[leger]

ckritzer, please verify.  All well on automation front? :-)

Comment 40

[ckritzer (gone)]

This no longer blocks automation for Mac.
MacOS9 2000-07-25-11-M17 Commercial

Linux and Windows builds from the same day run as well, so marking this bug 
VERIFIED FIXED.

Comment 41

[Lythande]

Am I the only one seeing this return?