432840 - [mac] Include symbolic link to Applications folder

Status: RESOLVED FIXED

(Thunderbird :: Installer, enhancement, P2)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Thunderbird equivalent of bug 320155.

We can improve the usability of the Thunderbird installer by creating a symbolic link to the Applications folder.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Occurred on 10.4 Tiger, while testing Shredder Alpha 1 build 1, with build ID version 3.0a1 (2008050714). I'm sure Leopard is affected as well.

Comment 2

[Neil]

Needs [mac] tag.

Comment 4

[Magnus Melin [:mkmelin]]

An takers on porting the fix from bug 320155?

Comment 5

[Mark Banner (:standard8)]

Attachment: Makefile fix

Well this includes a symlink in the dmg, but I think we're going to need some artwork updates and probably a DSStore update - I'll attach a screenshot in a moment.

Comment 6

[Mark Banner (:standard8)]

Attachment: The current look

Comment 7

[Mark Banner (:standard8)]

Attachment: Putting the icon in the "right" place

Comment 8

[Mark Banner (:standard8)]

Attachment: Without the icon

Comment 9

[Mark Banner (:standard8)]

Attachment: How Firefox does it

This one was slightly unexpected, this is how Firefox does their mac symlink.

If we want to fix this, I could probably have a go at creating a new dsstore file, but I'd want someone else to help with the graphics side.

Comment 10

[David Ascher (:davida)]

faaborg: any chance you can assist with the graphics?  The PSD or whatever master file was used for Fx, and/or a lead on a graphic designer who'd be up for it?

Comment 11

[David Ascher (:davida)]

I think there's no reason we shouldn't land this for tb3. Marking as blocking

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

The Firefox 3 dmg image was created by Sean Martell, I'll follow up in private email with his contact information.

Comment 13

[Mark Banner (:standard8)]

Attachment: [checked in] Fix for non-branded builds

Now we're doing non-branded builds by default, I think we should fix this - there is no background artwork on non-branded builds, so we are fine just to add this shortcut, and do a dsstore update - I'll attach the new (binary) file in a mo.

Comment 14

[Mark Banner (:standard8)]

Attachment: [checked in] New dsstore file for non-branded builds

Comment 15

[David Ascher (:davida)]

Attachment: Background for branded build

I've got the PSD, and will make a Shredder version as soon as we pick an icon, which will influence the color scheme.  Thanks to Sean Martell for the graphic!

Comment 16

[Mark Banner (:standard8)]

Attachment: [checked in] Add symlink to localised unbranded packages.

I just noticed that localised builds don't have a symlink in them. This fixes it for them as well.

Comment 17

[Mark Banner (:standard8)]

I'm going to take driving this into the build, seeing as I'll need to get rid of the ifndef for bug 443351. I may not do it straight away, but I'll make sure it gets in in time for beta which I think will be officially branded.

Comment 18

[David :Bienvenu]

Comment on attachment 330199 [details] [diff] [review]
[checked in] Add symlink to localised unbranded packages.

I don't really understand the trailing space, but it's done elsewhere that way :-)

Comment 19

[Mark Banner (:standard8)]

Retriaging according to new policy for flags.
https://wiki.mozilla.org/Thunderbird:Release_Driving

(Note: although taking off blocking, I'll try and drive this in for b1).

Comment 20

[(not currently active) Ted Mielczarek]

(In reply to comment #18)
> (From update of attachment 330199 [details] [diff] [review])
> I don't really understand the trailing space, but it's done elsewhere that way
> :-)

"For Firefox, the name will be ' ', so as to
not be displayed and therefore not have any localization impact."

From bug 320155 comment 53. The space is the actual name for the symlink.

Comment 21

[Mark Banner (:standard8)]

Attachment: [checked in] Add new background for official branding.

This adds the new background (from attachment 328082 [details]) to the officially branded mac bundles (all locales), and adds the symlink as well. I'll attach an image of it in a moment.

Comment 22

[Mark Banner (:standard8)]

Attachment: The new official branding package.

Comment 23

[Mark Banner (:standard8)]

Comment on attachment 338183 [details] [diff] [review]
[checked in] Add new background for official branding.

Checked in, changeset id: 318:28daa79edfa1

Comment 24

[Mark Banner (:standard8)]

We now have symlinks for both unofficial and official branding, so this is now fixed.