Tools -> Import -> Filters -> Eudora doesn't work.

RESOLVED WONTFIX

Status

Thunderbird
Migration
P2
normal
RESOLVED WONTFIX
10 years ago
2 years ago

People

(Reporter: gkw, Assigned: Jeff Beckley)

Tracking

({regression})

Trunk
Thunderbird 3.0a3
regression
Bug Flags:
wanted-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Occurred on 10.4 Tiger, while testing Shredder Alpha 1 build 1, with build ID version 3.0a1 (2008050714).

1: Go to Tools -> Import -> select Filters, then click "next".
2: "Eudora" is the only option, so click "next" again.

The select file dialog doesn't come up, and the "back" and "next" buttons are greyed out. I can only press "cancel" to get out of the dialog.

Not sure if this affects Intel Macs as well. CC'ing Jeff Beckley as this involves Eudora but I don't know if it's a Eudora issue.
Flags: wanted-thunderbird3?
(Reporter)

Comment 1

10 years ago
A possibly related problem would be to go to Tools -> Import -> Address book -> "next" -> select Eudora -> "next" -> cancel the Select file dialog.

Both the "back" and "next" buttons will get deselected. This issue doesn't occur if the "Text file" option is selected, only affects the "Eudora" option.
(Assignee)

Comment 2

10 years ago
It's not working for the latest dev builds of Eudora either.  There must have been a regression in the latest TB trunk code that broke it.  I'll have to check this out in more detail to see what's going on.
I'm assuming you'll take this bug on Jeff?
Assignee: nobody → beckley
(Assignee)

Comment 4

10 years ago
Yes, I will.
Status: NEW → ASSIGNED
(Reporter)

Updated

10 years ago
Keywords: qawanted
OS: Mac OS X → All
Hardware: Macintosh → All

Updated

10 years ago
Flags: wanted-thunderbird3? → wanted-thunderbird3+
Keywords: regression

Comment 5

10 years ago
Keeping wanted‑thunderbird3+. 
Jeff: I assume you're on this regression, still? Something we can get in for beta1? If not, please push it out to when you approximate to get to it.
Priority: -- → P2
Target Milestone: --- → Thunderbird 3.0b1
(Assignee)

Comment 6

10 years ago
Yes, I will make some time to fit this in before b1.
(Assignee)

Comment 7

10 years ago
Created attachment 337401 [details] [diff] [review]
Fix for Eudora filter import bug

This fixes a problem with importing filters from Classic Eudora when there is an action involving a transfer/copy to a mailbox.

Gary, can you check this out to make sure this was the problem that you were having?  It certainly was the issue that stopped my filter importing from working.
Attachment #337401 - Flags: superreview?(bienvenu)
Attachment #337401 - Flags: review?(nth10sd)
(Reporter)

Updated

10 years ago
Attachment #337401 - Flags: review?(nth10sd) → review?(bienvenu)
(Reporter)

Comment 8

10 years ago
Comment on attachment 337401 [details] [diff] [review]
Fix for Eudora filter import bug

Jeff, sorry I'm not (yet?) good enough to review patches. :|

When I have the time to build Thunderbird, I will test out the patch though.

moving review request over to bienvenu..

Comment 9

10 years ago
Comment on attachment 337401 [details] [diff] [review]
Fix for Eudora filter import bug

+  // We've already grabbed the pointer on incoming, so now ensure
+  // *ppFolder is null on outgoing if there is an error
+  NS_IF_RELEASE(*ppFolder);
+  

this is an odd thing to do - is there any reason folder has to be a comptr? Could it be a plain pointer?  Then you could just say *ppFolder = nsnull;
(Assignee)

Comment 10

10 years ago
Seems weird to have just a plain ptr to an object, and not do ref counting.  And I suppose in some situations could actually produce bad results.  If we get the object and don't AddRef it, then it could potentially be destroyed when exiting out of the function and the caller will get a deleted object (doesn't happen to occur in this situation because the object is already being kept alive by something else).

What exactly is the best way to handle an in/out parameter to a ref-counted object?  Maybe it would be better to split them out as separate parameters?

Comment 11

10 years ago
How about making GetMailboxFolder take a ref to the comptr as an argument? Would that simplify things?
(Assignee)

Comment 12

10 years ago
I think I'm leaning toward the simplification you originally suggested.  The callers of the function will only use that as an out parameter, and only the recursive calls use it as an in parameter as well.  If it's just viewed as a plain out parameter, then it only has to be AddRefed once, not at each recursive step.  The recursive nature of the calls ensure that the ref counts keep the objects alive, and only one final AddRef is necessary to return the object.
(Assignee)

Comment 13

10 years ago
Created attachment 337502 [details] [diff] [review]
Better solution

OK, here's a new way to solve the problem.  Instead of AddRef/Release at each level of recursion, now just AddRef once we get the actual nsIMsgFolder we want to return.
Attachment #337401 - Attachment is obsolete: true
Attachment #337502 - Flags: superreview?(bienvenu)
Attachment #337502 - Flags: review?(bienvenu)
Attachment #337401 - Flags: superreview?(bienvenu)
Attachment #337401 - Flags: review?(bienvenu)

Updated

10 years ago
Attachment #337502 - Flags: superreview?(bienvenu)
Attachment #337502 - Flags: superreview+
Attachment #337502 - Flags: review?(bienvenu)
Attachment #337502 - Flags: review+

Comment 14

10 years ago
Comment on attachment 337502 [details] [diff] [review]
Better solution

thx, that's better.
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checked in, changeset id: 294:b19fc26a5e4a
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Reporter)

Comment 16

10 years ago
Just tested, doesn't work, reopening. Debug build has build ID Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080910155414 Shredder/3.0b1pre

Error message in console is:

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIImportFilters.Import]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/importDialog.js :: ImportFilters :: line 952"  data: no]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 17

10 years ago
Gary, how did you test this, do you do a build on your own?  I'm wondering if maybe the changes for this didn't get in to your build.

I went and downloaded the nightly from 2008-09-08, and the problem was in that build.  But then I downloaded 2008-09-10 (which has my checked-in changes), and the problem is fixed in it.  Here's the build ID:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080910025452 Shredder/3.0b1pre

Maybe you could try downloading the latest nightly to see if it works for you?
(Reporter)

Comment 18

10 years ago
Created attachment 338029 [details]
immediately after pressing "next"

I just tested on:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080910025452 Shredder/3.0b1pre

and it _still_ doesn't work. Not with my existing profile, nor with a fresh profile. :(

(Note: I'm on 10.5.4, Leopard)

Comment 19

9 years ago
This bug (tools->import->filters->eudora nothing happens) is occurring for me with beta 7 freshly installed (have created an account via wizard, haven't logged in yet, imported mail, imported address book, import settings failed, then import filters. tried closing and reopening eudora still fails. This is on windows 7 x64 very freshly installed

Comment 20

8 years ago
Also happen on OpenSolaris, TB version 3.0.1

tools->import->filters->

Then nothing to select to operate with.
(Reporter)

Comment 21

8 years ago
Yes, still occurs with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a2pre) Gecko/20100222 Shredder/3.2a1pre

Comment 22

8 years ago
Jeff, since Gary can reproduce, is there something he might do in a debug build to get to the bottom of this?

bff in comment #19
> This bug (tools->import->filters->eudora nothing happens) is occurring for me
> with beta 7 freshly installed (have created an account via wizard, haven't
> logged in yet, imported mail, imported address book, import settings failed,

bbf, does bug 368363 adequately cover the settings issue? Or is a new bug needed
(Assignee)

Comment 23

8 years ago
(In reply to comment #22)
> Jeff, since Gary can reproduce, is there something he might do in a debug build
> to get to the bottom of this?

Gary, if you can run this under Venkman and/or the XCode debugger you might be able to step through the code to see where its hanging.  Since the previous fix didn't help, I don't know if the problem you're seeing is in JS or C++ code.
(Reporter)

Comment 24

8 years ago
(In reply to comment #23)
> (In reply to comment #22)
> > Jeff, since Gary can reproduce, is there something he might do in a debug build
> > to get to the bottom of this?
> 
> Gary, if you can run this under Venkman and/or the XCode debugger you might be
> able to step through the code to see where its hanging.  Since the previous fix
> didn't help, I don't know if the problem you're seeing is in JS or C++ code.

It doesn't hang. It just gives the screen in comment 18 (i.e., after clicking next, no dialog box appears, the next button gets unselectable, all I can click is cancel.)
(Assignee)

Comment 25

8 years ago
(In reply to comment #24)
> It doesn't hang. It just gives the screen in comment 18 (i.e., after clicking
> next, no dialog box appears, the next button gets unselectable, all I can click
> is cancel.)

Maybe "hang" was the wrong word choice, and "spin" would be better.  I was thinking a developer being able to step through the problem as it happens would be very helpful.  I can't get it to happen at all.
(Reporter)

Comment 26

8 years ago
(In reply to comment #25)
> (In reply to comment #24)
> > It doesn't hang. It just gives the screen in comment 18 (i.e., after clicking
> > next, no dialog box appears, the next button gets unselectable, all I can click
> > is cancel.)
> 
> Maybe "hang" was the wrong word choice, and "spin" would be better.  I was
> thinking a developer being able to step through the problem as it happens would
> be very helpful.  I can't get it to happen at all.

Nope, doesn't spin, TB proceeds to continue working properly after that. Ludo, does this occur for you?
(In reply to comment #26)
> (In reply to comment #25)
> > (In reply to comment #24)
> > > It doesn't hang. It just gives the screen in comment 18 (i.e., after clicking
> > > next, no dialog box appears, the next button gets unselectable, all I can click
> > > is cancel.)
> > 
> > Maybe "hang" was the wrong word choice, and "spin" would be better.  I was
> > thinking a developer being able to step through the problem as it happens would
> > be very helpful.  I can't get it to happen at all.
> 
> Nope, doesn't spin, TB proceeds to continue working properly after that. Ludo,
> does this occur for you?

Haven't tried. So you're saying it works ?
(Reporter)

Comment 28

8 years ago
(In reply to comment #27)
> (In reply to comment #26)
> > (In reply to comment #25)
> > > (In reply to comment #24)
> > > > It doesn't hang. It just gives the screen in comment 18 (i.e., after clicking
> > > > next, no dialog box appears, the next button gets unselectable, all I can click
> > > > is cancel.)
> > > 
> > > Maybe "hang" was the wrong word choice, and "spin" would be better.  I was
> > > thinking a developer being able to step through the problem as it happens would
> > > be very helpful.  I can't get it to happen at all.
> > 
> > Nope, doesn't spin, TB proceeds to continue working properly after that. Ludo,
> > does this occur for you?
> 
> Haven't tried. So you're saying it works ?

Nope. Doesn't work in Miramar 3.3 Alpha 1. It's still as described in comment 19 and comment 20.

Comment 29

2 years ago
Importing from Eudora was removed from Thunderbird in bug 1243498.
Please see http://kb.mozillazine.org/Importing_from_Eudora_-_Thunderbird on how you can still import from Eudora if you need that.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.