User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9) Gecko/2008051202 Firefox/3.0 Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9) Gecko/2008051202 Firefox/3.0 Looks like fix for bug 406730 breaks some of the fixes for bug 364536: When the window is unfocused, the active tab looks "broken". Reproducible: Always Steps to Reproduce: 1. Open at least 2 tabs on Mac OS X with RTL chrome (e.g. Hebrew version) 2. Switch the current application, so that Firefox is in the background 3. Look at the right and left borders of the selected tab Actual Results: The right and left borders of the selected tab look "broken" Expected Results: The right and left borders of the selected tab should match the middle part of the part See attached screenshot
Keven and Steven, it seems that there was something forgotten. Could one of you have a look at the patch?
Hardware: Macintosh → All
Version: unspecified → Trunk
Yehuda, was this really raised by bug 406730? I can't really imagine because it looks like a really different issue.
Attachment #321510 - Flags: review? → review?(gavin.sharp)
(In reply to comment #4) > Yehuda, was this really raised by bug 406730? I can't really imagine because it > looks like a really different issue. > Yes, as far as I can tell. You can see that my patch is over the lines that were added to browser.css in https://bugzilla.mozilla.org/attachment.cgi?id=318989
Henry, just to clarify on comment #5: It is not an issue of two unsynched checkins. Rather that the fix for bug 406730 introduced a new situation that requires RTL treatment
Yeah, I can see now. Looks like that Gavin is the right one to review your patch.
Comment on attachment 321510 [details] [diff] [review] css patch We should take this for RC2, it's a safe RTL-only theme fix.
Attachment #321510 - Flags: review?(gavin.sharp) → review+
Not going to block here, RTL on Mac wasn't even a blocker, and this is relatively minor. We'll get it for 3.0.1 for sure, or RC2 if we need to do that.
Comment on attachment 321510 [details] [diff] [review] css patch a=beltzner, please land asap on cvsroot
Attachment #321510 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Mike and Gavin, Thanks for approving and landing this for RC2.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; he; rv:1.9) Gecko/2008052903 Firefox/3.0 Confirmed fix for RC2. I'll attach a pic.
This is in 10.5 using RC2.
(In reply to comment #14) > Created an attachment (id=323622) [details] > Bug Fixed > > This is in 10.5 using RC2. > the image is corrupt.
Attachment #323622 - Attachment mime type: image/png → image/tiff
(In reply to comment #15) > the image is corrupt. Fixed.
Thanks Tomer. :)
You need to log in before you can comment on or make changes to this bug.