434360 - Mac OS X: Active tab is broken in RTL when window is unfocused

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Yehuda]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9) Gecko/2008051202 Firefox/3.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; he; rv:1.9) Gecko/2008051202 Firefox/3.0

Looks like fix for bug 406730 breaks some of the fixes for bug 364536: 
When the window is unfocused, the active tab looks "broken". 



Reproducible: Always

Steps to Reproduce:
1. Open at least 2 tabs on Mac OS X with RTL chrome (e.g. Hebrew version)
2. Switch the current application, so that Firefox is in the background
3. Look at the right and left borders of the selected tab
Actual Results:  
The right and left borders of the selected tab look "broken"

Expected Results:  
The right and left borders of the selected tab should match the middle part of the part

See attached screenshot

Comment 1

[Yehuda]

Attachment: broken behavior of selected tab when browser window is unfocused

Comment 2

[Yehuda]

Attachment: css patch

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Keven and Steven, it seems that there was something forgotten. Could one of you have a look at the patch?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yehuda, was this really raised by bug 406730? I can't really imagine because it looks like a really different issue.

Comment 5

[Yehuda]

(In reply to comment #4)
> Yehuda, was this really raised by bug 406730? I can't really imagine because it
> looks like a really different issue.
> 

Yes, as far as I can tell. You can see that my patch is over the lines that were added to browser.css in https://bugzilla.mozilla.org/attachment.cgi?id=318989

Comment 6

[Yehuda]

Henry, just to clarify on comment #5: It is not an issue of two unsynched
checkins. Rather that the fix for bug 406730 introduced a new situation that
requires RTL treatment

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yeah, I can see now. Looks like that Gavin is the right one to review your patch.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 321510 [details] [diff] [review]
css patch 

We should take this for RC2, it's a safe RTL-only theme fix.

Comment 9

[Mike Connor [:mconnor]]

Not going to block here, RTL on Mac wasn't even a blocker, and this is relatively minor.  We'll get it for 3.0.1 for sure, or RC2 if we need to do that.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 321510 [details] [diff] [review]
css patch 

a=beltzner, please land asap on cvsroot

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/pinstripe/browser/browser.css 	1.156

Comment 12

[Yehuda]

Mike and Gavin,
Thanks for approving and landing this for RC2.

Comment 13

[Hasham]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; he; rv:1.9) Gecko/2008052903 Firefox/3.0

Confirmed fix for RC2. I'll attach a pic.

Comment 14

[Hasham]

Attachment: Bug Fixed

This is in 10.5 using RC2.

Comment 15

[Tsahi Asher]

(In reply to comment #14)
> Created an attachment (id=323622) [details]
> Bug Fixed
> 
> This is in 10.5 using RC2.
> 

the image is corrupt.

Comment 16

[Tomer Cohen :tomer]

(In reply to comment #15)
> the image is corrupt.
Fixed.

Comment 17

[Hasham]

Thanks Tomer. :)