439058 - Move <mail-folder-bindings.xml> from <mail/> to <mailnews/>

Status: VERIFIED FIXED

(mozilla.org :: CVS: Copy, task)

Description

[Serge Gautherie (:sgautherie)]

From
<http://mxr.mozilla.org/mozilla/source/mail/base/content/mail-folder-bindings.xml>
To
??

Dan, Karsten,
Can you write where to move it exactly ?
Then confirm the bug.

Comment 1

[Reed Loden [:reed]]

Require reviewed cvscopy file for this.

Comment 2

[Dave Miller [:justdave]]

Reopen this when you have specific directions for us and module owner approval for the destination module.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

How about mailnews/base/resources/content?

Comment 4

[Karsten Düsterloh]

Yes, that's where our shared mailWidgets.xml are located as well.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <mail-folder-bindings.xml>

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Do we need to coordinate this move with packaging changes?

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Do we need to coordinate this move with packaging changes?

"Yes (+/-)": see my Av1-TB patch in bug 438647 ;-)

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 325856 [details]
(Av1) <mail-folder-bindings.xml>

r=dmose

Comment 9

[Serge Gautherie (:sgautherie)]

Reed,
any ETA for this move ?

Comment 10

[[e-mail]]

Sorry for not noticing this bug before, but how did this file get to be called mail-folder-widgets.xml in the first place? This does not seem to be typical mailnews style, except for some exceptions:
* Suite pref panels have a pref- prefix
* Suite sidebar panels have a -panel suffix
* Account manager panes have an am- prefix
* Account wizard scripts have an aw- prefix
* mail-offline.js

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

A fair point.  msgFolderWidgets.xml, perhaps?

Comment 12

[Karsten Düsterloh]

We've 

/mailnews/base/search/resources/content/searchWidgets.xml
/mailnews/base/resources/content/mailWidgets.xml

so how about just folderWidgets.xml?

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Sounds reasonable to me.

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <folderWidgets.xml> [Checkin: Comment 22]

Av1, with comment 12 suggestion(s).

Comment 15

[Reed Loden [:reed]]

(In reply to comment #9)
> Reed,
> any ETA for this move ?

Sorry, bug got lost in bugmail... Do you want me to do the first move now, or wait until the second one has been reviewed and do them together?

Comment 16

[Serge Gautherie (:sgautherie)]

(In reply to comment #15)
> Sorry, bug got lost in bugmail... Do you want me to do the first move now, or

It seems it was for the better, this time ;->

> wait until the second one has been reviewed and do them together?

Let's wait for the new reviews.

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 327047 [details] [diff] [review]
(Av2) <folderWidgets.xml>
[Checkin: Comment 22]

r=dmose

Comment 18

[Aravind Gottipati [:aravind]]

Is this ready for us to push?

Comment 19

[Reed Loden [:reed]]

(In reply to comment #18)
> Is this ready for us to push?

Yep.

Comment 20

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)
> (In reply to comment #18)
> > Is this ready for us to push?
> 
> Yep.

If you can, (preemptively) check in bug 438647 Av1a-TB patch too. Thanks.

Comment 21

[Serge Gautherie (:sgautherie)]

Ping, for checkin(s) ?

Comment 22

[Aravind Gottipati [:aravind]]

# /opt/cvsmgmt/bulk-copy.pl </opt/cvsmgmt/439058.script
Copying mozilla/mail/base/content/mail-folder-bindings.xml -> mozilla/mailnews/base/resources/content/folderWidgets.xml ...
branchlist = 

Comment 23

[Serge Gautherie (:sgautherie)]

V.Fixed

Comment 24

[Karsten Düsterloh]

We need to CVS remove mail-folder-bindings.xml once bug 438647 is completely fixed for a few days. Whoever does that then should note it here as well.

Comment 25

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Hg-remove old file [Moved to bug 450044]

Per comment 24,
actually remove the old file, after comment 22 copy to new location.

Comment 26

[Reed Loden [:reed]]

(In reply to comment #25)
> Created an attachment (id=332031) [details]
> (Bv1) Hg-remove old file
> 
> Per comment 24,
> actually remove the old file, after comment 22 copy to new location.

Open a new bug under the appropriate product for this and make sure you get appropriate reviews.

Comment 27

[Serge Gautherie (:sgautherie)]

(In reply to comment #26)

I filed bug 450044.