438647 - In <am-copies.js>, "Error: document.getElementById(accountPickerId).selectedItem is null"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

1. Open Properties for 'Local Folders'. (for example)
2. Select 'Copies & Folders' tree-item.
3. Select another tree-item.
3r.
{{
Error: document.getElementById(accountPickerId).selectedItem is null
Source File: chrome://messenger/content/am-copies.js
Line: 270
}}

Account Manager (seems to) works fine, except for this item.

Workaround: close AM then reopen it...

Comment 1

[Joey Minta]

What about if you select a different Folder before switching to another pane?

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> 1. Open Properties for 'Local Folders'. (for example)
> 2. Select 'Copies & Folders' tree-item.

Actually, any mail/news account, other than LF which has no C&F tree-item ;->

*****

(In reply to comment #1)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

I can't select another folder in that pane:
the boxes all display 'Local Folders' (or 'Sent' or 'Drafts');
and the (3+) drop-down list(s) is empty when it opens. [<-- root cause !!?]

***

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008061203 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

No problem with TB.

Comment 3

[Joey Minta]

OK, that seems much more like what I expected.  SeaMonkey doesn't ship mail-folder-binding.xml, so it just ends up with an empty menulist.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> SeaMonkey doesn't ship mail-folder-binding.xml

<http://mxr.mozilla.org/mozilla/source/mail/base/content/mail-folder-bindings.xml>
added by "Bug 413781 XBLify folder-selection menus".

Is there a way to unbrake SM, until we port that bug ?

Comment 5

[Joey Minta]

The only way to unbreak SM, without porting that bug would be to (1) restore the removed portions of msgFolderPickerOverlay.xul (2) #ifdef inclusion of that overlay and (3) #ifdef the js changes to am-copies.

Given that the porting steps are (1) move mail-folder-bindings.xml to from mail/ to mailnews (2) add mail-folder-bindings.xml to SM's jar.mn, and (3) add http://mxr.mozilla.org/seamonkey/source/mail/base/content/messenger.css#262 to SM's messenger.css, that actually seems like the simpler solution to me.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Given that the porting steps are (1) move mail-folder-bindings.xml to from
> mail/ to mailnews

Could you/someone do that (cvs copy/move, etc) ?

Comment 7

[Joey Minta]

cvs moves require coordination with mozilla IT.  Given the limited history/blame for the file, my vote would be to just cvs remove/add it in a standard patch.  That's a decision for the peers though.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

jminta's suggested solution in comment 5 sounds right to me.  Coordination with IT just means "filing a bug", I think, so I guess I'd vote for that, assuming the turnaround on that sort of bug isn't too long.  I could live with the cvs remove/add plan too.

Comment 9

[Karsten Düsterloh]

Yes, we should strive /
for comment 5.

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-TB) <jar.mn> update after bug 439058

Comment 11

[Karsten Düsterloh]

> (Av1-TB) <jar.mn> update after bug 439058

You need to change SeaMonkey's respective jar.mn as well.

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-SM) <mailnews/*> Port to SM

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008061902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Per comment 5 suggestion.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 325859 [details] [diff] [review]
(Av1-TB) <jar.mn> update after bug 439058

r=dmose

Comment 14

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a-TB) <base/*/*> update after bug 439058 [Checkin: Comment 19]

Av1-TB, updated with new/future file name.

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 327434 [details] [diff] [review]
(Av1a-TB) <base/*/*> update after bug 439058
[Checkin: Comment 19]

r=dmose

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 327434 [details] [diff] [review]
(Av1a-TB) <base/*/*> update after bug 439058
[Checkin: Comment 19]

Phil,
I'm looking for a confirmation of previous DanM's r+.
(DanM is not around at the moment.)

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 327434 [details] [diff] [review]
(Av1a-TB) <base/*/*> update after bug 439058
[Checkin: Comment 19]

Argh, silent bugzilla collision:
{{
[e-mail]  	2008-07-10 14:34:32 PDT  	  Attachment #327434 [details] [diff]  Flag  	review?([e-mail])  	review+
}}

Comment 18

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1a-SM) <mailnews/*> Port to SM

Bv1-SM, updated with new file name.

Comment 19

[Karsten Düsterloh]

Comment on attachment 327434 [details] [diff] [review]
(Av1a-TB) <base/*/*> update after bug 439058
[Checkin: Comment 19]

Landed this on CVS trunk aka 1.9.0. Leaving bug open until SM patch is in also.

Comment 20

[[e-mail]]

Comment on attachment 329096 [details] [diff] [review]
(Bv1a-SM) <mailnews/*> Port to SM

>+    content/messenger/folderWidgets.xml)                                       (base/resources/content/folderWidgets.xml)
                                         ^ Spurious close bracket.
r+sr=me with that fixed.

Comment 21

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b-SM) <mailnews/*> Port to SM [Checkin: Comment 22]

Bv1a-SM, with comment 20 suggestion(s).

Comment 22

[Karsten Düsterloh]

Comment on attachment 329166 [details] [diff] [review]
(Bv1b-SM) <mailnews/*> Port to SM
[Checkin: Comment 22]

Landed this on CVS trunk aka 1.9.0.

Comment 24

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.2pre) Gecko/2008071202 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

It fixed a third case (= Junk Settings) too:
{{
Error: document.getElementById("actionAccountPopup").selectFolder is not a function
Source File: chrome://messenger/content/am-junk.js
Line: 60
}}

V.Fixed