Closed Bug 439373 Opened 16 years ago Closed 16 years ago

Remove front end users of nsIMsgRDFDatasource

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: jminta, Assigned: jminta)

References

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
nsIMsgRDFDatasource just wraps a normal rdfdatasource with a window property that can be used for providing feedback.  There's a grand total of one instance where someone even tries to use that window, and it's in a function that's never called.
http://mxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgFolderDataSource.cpp#742
We can't remove the entire interface yet, because it provides a common prototype for the account and folder datasources that's too much work to move over.  The actual interface/impl will just disappear when those datasources do.
Attachment #325210 - Flags: review?(mkmelin+mozilla)
Target Milestone: --- → Thunderbird 3
Comment on attachment 325210 [details] [diff] [review]
patch v1

Sure, r=mkmelin
Attachment #325210 - Flags: review?(mkmelin+mozilla) → review+
Patch checked in.

cvs commit: Examining mail/base/content
Checking in mail/base/content/commandglue.js;
/cvsroot/mozilla/mail/base/content/commandglue.js,v  <--  commandglue.js
new revision: 1.95; previous revision: 1.94
done
Checking in mail/base/content/mailWindow.js;
/cvsroot/mozilla/mail/base/content/mailWindow.js,v  <--  mailWindow.js
new revision: 1.64; previous revision: 1.63
done
Checking in mail/base/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v  <--  msgMail3PaneWindow.js
new revision: 1.156; previous revision: 1.155
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 657607
No longer blocks: 657607
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: