Closed
Bug 440334
Opened 16 years ago
Closed 16 years ago
Focus does not jump to "Find" toolbar when a form button/checkbox is focused
Categories
(Toolkit :: Find Toolbar, defect, P2)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: bugzilla.mozilla.org, Assigned: Gavin)
References
Details
(Keywords: regression, testcase)
Attachments
(1 file, 1 obsolete file)
8.14 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0 Normally, when one pressed Ctrl+F to search inside the page, the input field on the Find toolbar gets focus and one can begin typing. However, when a button on a form is currently focused, the focus is NOT moved to the Find input box. It does not make any difference if the Find toolbar is already opened or not. Quick Find works fine, but the normal Find does not focus. Reproducible: Always Steps to Reproduce: 1. Go to a webpage containing a form. 2. Using the Tab key, put focus on one of the form buttons. 3. Press Ctrl+F to start searching. 4. If the Find toolbar was not visible, it will be displayed. But it will not receive focus. Actual Results: The form button stays focused. Expected Results: The input field on the Find toolbar should receive focus.
Comment 1•16 years ago
|
||
Good catch! I see this on Linux too. It occurs for data:text/html,<input type=button value="Hi"> but not data:text/html,<button>Hi</button>
Status: UNCONFIRMED → NEW
Component: Find Toolbar / FastFind → Layout: Form Controls
Ever confirmed: true
Keywords: regression,
testcase
OS: Windows XP → All
Product: Firefox → Core
QA Contact: fast.find → layout.form-controls
Version: unspecified → 1.9.0 Branch
Comment 2•16 years ago
|
||
Is this a regression from Firefox 2 (Gecko 1.8.1)?
Comment 3•16 years ago
|
||
Yes, the regression window is: 2007-02-10-04 -- 2007-02-11-04 http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-10+03%3A00&maxdate=2007-02-11+05%3A00&cvsroot=%2Fcvsroot It seems bug 250910 is the culprit - the bug goes away if I set accessibility.typeaheadfind.prefillwithselection = false
Blocks: 250910
Assignee | ||
Updated•16 years ago
|
Component: Layout: Form Controls → Find Toolbar / FastFind
Product: Core → Firefox
QA Contact: layout.form-controls → fast.find
Version: 1.9.0 Branch → Trunk
Assignee | ||
Comment 4•16 years ago
|
||
Form buttons are nsIDOMNSEditableElements but have null editors, apparently. I'll write a test for this.
Attachment #326943 -
Flags: review?(mano)
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → gavin.sharp
Assignee | ||
Updated•16 years ago
|
Priority: -- → P2
Target Milestone: --- → Firefox 3.1a1
Comment 5•16 years ago
|
||
All <input>s have to be nsIDOMNSEditableElement, since you can always change the 'type' attribute.
Comment 6•16 years ago
|
||
Comment on attachment 326943 [details] [diff] [review] patch r=mano
Attachment #326943 -
Flags: review?(mano) → review+
Assignee | ||
Comment 8•16 years ago
|
||
Includes tests for bug 250910 (the tests there never landed apparently.)
Attachment #326943 -
Attachment is obsolete: true
Attachment #328239 -
Flags: review?(mano)
Comment 9•16 years ago
|
||
Comment on attachment 328239 [details] [diff] [review] with test r=mano
Attachment #328239 -
Flags: review?(mano) → review+
Assignee | ||
Updated•16 years ago
|
Summary: Focus does not jump to "Find" toolbar when a form button is focused → Focus does not jump to "Find" toolbar when a form button/checkbox is focused
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 11•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/index.cgi/rev/5a805f937512
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Hardware: PC → All
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Firefox → Toolkit
Comment 12•16 years ago
|
||
This bug is still present in Firefox 3.0.3 for input buttons, radio buttons, and checkboxes. I do not believe this bug existed in the 2.x line, because I use this feature a LOT, and I only noticed it in 3.0. I have received automatic updates up to current, 3.0.3, but it is still broken.
Comment 14•16 years ago
|
||
Jason: this bug has been fixed on trunk (the current development branch) and won't appear in Firefox releases until 3.1 comes out.
You need to log in
before you can comment on or make changes to this bug.
Description
•