align on one repository for graph server code

RESOLVED FIXED in 0.3

Status

Webtools Graveyard
Graph Server
P2
normal
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: alice, Assigned: alice)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

10 years ago
Currently the old code is in cvs and the new in hg and we run a mix of cvs/hg code on graphs.m.o and graphs-stage.m.o.  We need to line up on a single code base.
Alice, can you split this out into smaller bugs so others can help?
Assignee: nobody → anodelman
Target Milestone: --- → 0.3
(Assignee)

Updated

10 years ago
Depends on: 388685
(Assignee)

Updated

10 years ago
Depends on: 435113
(Assignee)

Updated

10 years ago
Priority: -- → P2
(Assignee)

Updated

10 years ago
Depends on: 441651
(Assignee)

Updated

10 years ago
Depends on: 441653
I'm curious what the eta is on this. I think myself and others are blocked until either all code is in 1 repo or there's documentation on how to get it up and running. Thanks!
(Assignee)

Comment 3

10 years ago
All new code should be in hg, and we should only be doing fixes on the new front end (which is the one already in hg).  The current state is a little confusing, but as long as you aren't touching server code (collect.cgi/getdata.cgi/bulk.cgi) then everything that you need is in hg.

The list of blockers might not be quite correct - since I've mixed together bugs having to do with aligning on a single repository along with bugs having to do with only hosting a single front end.

For the single repository, we should be able to get to a stable state pretty easily by applying the few patches that are cvs only to the hg version.
(Assignee)

Comment 4

10 years ago
For those looking for the hg repository it's here: http://hg.mozilla.org/index.cgi/graphs/
I think this is finished -- is there anything left to do here?
Blocks: 445555
(Assignee)

Comment 6

10 years ago
Created attachment 330120 [details] [diff] [review]
fix path to getdata.cgi in hg repository

The hg repository has the server code in a directory called 'server' - this is just making the link to getdata.cgi match with that.
Attachment #330120 - Flags: review?(rdoherty)
Comment on attachment 330120 [details] [diff] [review]
fix path to getdata.cgi in hg repository

Pretty sure we can just use /server/getdata.cgi. This would remove the need to change it locally on stage.
Attachment #330120 - Flags: review?(rdoherty) → review-
(Assignee)

Comment 8

10 years ago
Created attachment 330123 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 2)

Same as before, but will work on both graphs-stage.m.o and graphs.m.o without local changes.
Attachment #330120 - Attachment is obsolete: true
Attachment #330123 - Flags: review?(rdoherty)
(Assignee)

Comment 9

10 years ago
Created attachment 330124 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 3)

Sorry for the spam, just realized that I broke getdatacgi_local with the previous patch.

I swear that I'll get this two line change right eventually.
Attachment #330123 - Attachment is obsolete: true
Attachment #330124 - Flags: review?(rdoherty)
Attachment #330123 - Flags: review?(rdoherty)
Comment on attachment 330123 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 2)

You need to remove lines 42 & 43, I get a js error on my local dev machine:

getdatacgi_local is not defined
getdatacgi = getdatacgi_local;
Attachment #330123 - Flags: review-
Comment on attachment 330124 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 3)

I don't think we need any localhost detection if all links are relative.
Attachment #330124 - Flags: review?(rdoherty) → review-
(Assignee)

Comment 12

10 years ago
Created attachment 330133 [details] [diff] [review]
[Checked in]fix path to getdata.cgi in hg repository (take 4)

I can't believe that I'm giving this a fourth try.
Attachment #330124 - Attachment is obsolete: true
Attachment #330133 - Flags: review?(rdoherty)
Comment on attachment 330133 [details] [diff] [review]
[Checked in]fix path to getdata.cgi in hg repository (take 4)

Yay, 4th time's the charm!
Attachment #330133 - Flags: review?(rdoherty) → review+
(Assignee)

Comment 14

10 years ago
Comment on attachment 330133 [details] [diff] [review]
[Checked in]fix path to getdata.cgi in hg repository (take 4)

changeset:   96:5a51eecc9288
Attachment #330133 - Attachment description: fix path to getdata.cgi in hg repository (take 4) → [Checked in]fix path to getdata.cgi in hg repository (take 4)
(Assignee)

Comment 15

10 years ago
All done here.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.