440788 - align on one repository for graph server code

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect, P2)

Description

[alice nodelman [:alice] [:anode]]

Currently the old code is in cvs and the new in hg and we run a mix of cvs/hg code on graphs.m.o and graphs-stage.m.o.  We need to line up on a single code base.

Comment 1

[Michael Morgan [:morgamic]]

Alice, can you split this out into smaller bugs so others can help?

Comment 2

[Ryan Doherty (:rdoherty)]

I'm curious what the eta is on this. I think myself and others are blocked until either all code is in 1 repo or there's documentation on how to get it up and running. Thanks!

Comment 3

[alice nodelman [:alice] [:anode]]

All new code should be in hg, and we should only be doing fixes on the new front end (which is the one already in hg).  The current state is a little confusing, but as long as you aren't touching server code (collect.cgi/getdata.cgi/bulk.cgi) then everything that you need is in hg.

The list of blockers might not be quite correct - since I've mixed together bugs having to do with aligning on a single repository along with bugs having to do with only hosting a single front end.

For the single repository, we should be able to get to a stable state pretty easily by applying the few patches that are cvs only to the hg version.

Comment 4

[alice nodelman [:alice] [:anode]]

For those looking for the hg repository it's here: http://hg.mozilla.org/index.cgi/graphs/

Comment 5

[Michael Morgan [:morgamic]]

I think this is finished -- is there anything left to do here?

Comment 6

[alice nodelman [:alice] [:anode]]

Attachment: fix path to getdata.cgi in hg repository

The hg repository has the server code in a directory called 'server' - this is just making the link to getdata.cgi match with that.

Comment 7

[Ryan Doherty (:rdoherty)]

Comment on attachment 330120 [details] [diff] [review]
fix path to getdata.cgi in hg repository

Pretty sure we can just use /server/getdata.cgi. This would remove the need to change it locally on stage.

Comment 8

[alice nodelman [:alice] [:anode]]

Attachment: fix path to getdata.cgi in hg repository (take 2)

Same as before, but will work on both graphs-stage.m.o and graphs.m.o without local changes.

Comment 9

[alice nodelman [:alice] [:anode]]

Attachment: fix path to getdata.cgi in hg repository (take 3)

Sorry for the spam, just realized that I broke getdatacgi_local with the previous patch.

I swear that I'll get this two line change right eventually.

Comment 10

[Ryan Doherty (:rdoherty)]

Comment on attachment 330123 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 2)

You need to remove lines 42 & 43, I get a js error on my local dev machine:

getdatacgi_local is not defined
getdatacgi = getdatacgi_local;

Comment 11

[Ryan Doherty (:rdoherty)]

Comment on attachment 330124 [details] [diff] [review]
fix path to getdata.cgi in hg repository (take 3)

I don't think we need any localhost detection if all links are relative.

Comment 12

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]fix path to getdata.cgi in hg repository (take 4)

I can't believe that I'm giving this a fourth try.

Comment 13

[Ryan Doherty (:rdoherty)]

Comment on attachment 330133 [details] [diff] [review]
[Checked in]fix path to getdata.cgi in hg repository (take 4)

Yay, 4th time's the charm!

Comment 14

[alice nodelman [:alice] [:anode]]

Comment on attachment 330133 [details] [diff] [review]
[Checked in]fix path to getdata.cgi in hg repository (take 4)

changeset:   96:5a51eecc9288

Comment 15

[alice nodelman [:alice] [:anode]]

All done here.