441705 - SetUpServerMenu is no longer used

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Joey Minta]

This is a followup to bug 439486.  Now that we've replaced the folder-picker there, the SetUpServerMenu function always hits the catch() block.  It should just be removed.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Removed SetUpServerMenu() from subscribe.js.

As per comment #1, removed all occurrences of SetUpServerMenu() (including
functional definition) from subscribe.js.  Replaced the call to SetUpServerMenu()
with SetServerTypeSpecificTextValues() as per comment #6 from bug# 439486.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Removed SetUpServerMenu() from subscribe.js.

Previous patch contained a tabbed line instead of a spaced line.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 432992 [details] [diff] [review]
Removed SetUpServerMenu() from subscribe.js.

I've just done some investigations into this. Somehow, comment 0 is wrong or no longer true.

We don't hit the exception case. However digging into what TB does there is code in SubscribeOnLoad that sets the initial selection for us, one is serverMenu.menupopup.selectFolder and the second (fallback) is serverMenu.selectedIndex = 0;

That's what makes SetUpServerMenu redundant.

Following on, it appears that the SeaMonkey code may still required because they are still using RDF form of the menu.

Therefore, please drop the suite/ changes from this patch and just make this mail/ only. I think then we can get this landed.

Comment 4

[Edmund Wong (:ewong)]

Attachment: Same as previous patch but minus the diff for the suite/ version

Removed the suite/ section as suggested by Comment 3.

Comment 5

[David :Bienvenu]

Comment on attachment 434497 [details] [diff] [review]
Same as previous patch but minus the diff for the suite/ version

since this is a front end change only, you don't need sr, just someone to check it in.

We can't easily do a test for this since mozmill doesn't support imap or nntp (and the change is straightforward)

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/c8f797723ad3