442222 - Update About > Credits for Thunderbird3

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mark Banner (:standard8)]

The credits will need updating for Thunderbird 3 (goto help -> about, click on credits), we should update those at some stage.

The relevant file is: http://mxr.mozilla.org/seamonkey/source/mail/base/content/credits.xhtml

I'm not expecting us to do anything straight away. Just filing so it doesn't get forgotten.

Comment 1

[Mark Banner (:standard8)]

Note, we may want to try fix bug 269800 at the same time.

Comment 2

[Phil Ringnalda (:philor)]

Unless you decide to flaunt mconnor's lessons-learned-the-hard-way traditions for these bugs for Firefox, of the project lead owning this, and taking nominations by email rather than in the bug, where it'll be very publicly embarrassing if you decide that someone doesn't really belong, here: this is yours.

(Might want to flaunt the tradition of always screwing up the spelling of a couple of names, and screwing up encoding for non-ASCII names, though.)

Comment 3

[David Ascher (:davida)]

After talking to mconnor and others, I'm planning to use a web form to collect the nominations.  See https://david.dabbledb.com/page/tb3credits/NyomUtuq for a draft.

Input on that form is greatly welcome here.

(yes, it's interesting that the web browser folks use email, and the email folks use the browser.  we're hip, what can i say)

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Input on that form is greatly welcome here.

I think the form works well. I've tended to use Other contributions as general comments about what they've done and why we should add them.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Once you've got a list that you think is mostly complete, it's probably worth posting to thunderbird-drivers to ensure that no one has been inadvertently left out.

Comment 6

[Mark Banner (:standard8)]

Although the final version of this can be targeted at rc1, I'd like to target an initial update landing before b4 so that we have plenty of time to iterate on updates.

Comment 7

[David Ascher (:davida)]

Wayne, any status update on this?

Comment 8

[Wayne Mery (:wsmwk)]

First thoughts below to level set - for your comments. After comments, next pass will be to add the "easy" names. Third pass will be to use information from the web form and other sources. (which I expect will be post-b4)

Web form https://david.dabbledb.com/page/tb3credits/NyomUtuq looks good to me - doesn't look like changes are needed. The web form's definition of contributor seems solid
  "the contributor has made significant contributions (more than trivial 
  fixes or bug reporting) to this specific release (Thunderbird 3). 
  Contributions can range in kind from dev to bug triage to QA to marketing 
  and more."

We currently have the following categories.
 Engineering Leads
 Build and Release
 Quality Assurance
 Special Thanks To [individuals]
 Theme Design
 Special Thanks To [groups]

Please comment on the questions I have posed below, and whether the following needs adjustment :

1. For this first pass (b4) there will be no new categories nor renamed categories. But feel free to comment if you feel such changes are needed in the future.

2. Engineering and Build - 
2a the names of the present Thunderbird "team" will replace what's there. 
  Engineering Leads - momo employees. anyone else?
  Build and Release - Gozer.  anyone else?
2b For historical purposes, do we move some or all of the names currently there (i.e. the thunderbird 2 names) to "Special Thanks To" [individuals]??  Or, do we start with a clean slate for "Special Thanks To"??  I think the later - clean slate (although there are obvious candidates).  Agree/disagree?

3. Quality Assurance - Ludo, Roland, plus other major contributors, plus individuals nominated from the web form. Will comb some names from Litmus.

4. Special Thanks To [individuals] - will be individuals nominated from the web form.  Will also comb some names from bugzilla

5. Theme Design (currently Arvid Axelsson, Kevin Gerich, Stephen Horlander) - Version 3 people are _________ ??

6. Special Thanks To [groups] (currently MozillaZine Community, MozillaZine,  MozDev) - open to suggestions, and of course will take ideas from web form

7 Additional items
7a Where to put Rebron?
7b (another bug?) update the thunderbird graphic of About Shredder?\
7c (another bug?) something better than/different from "Thunderbird Are Go!"
7d (another bug?) when credits scrolling is done, "Shredder is...licensing[link]..." isn't visible (and therefore not clickable)
7e There is an unused &credit.translation - for the final RC, do we want to utilize this category? Exposing a localizer category increases visibility of that important group, but it does add complexity.

Comment 9

[Wayne Mery (:wsmwk)]

cc: clarkbw for UI review on the webform at https://david.dabbledb.com/page/tb3credits/NyomUtuq

Comment 10

[Magnus Melin [:mkmelin]]

(In reply to comment #8)
> 1. For this first pass (b4) there will be no new categories nor renamed
> categories. But feel free to comment if you feel such changes are needed in the
> future.

The flat list that firefox uses sounds a lot more scalable. Certainly would save you a lot of thinking about who belongs where, especially as people often do more than one thing.

> 7e There is an unused &credit.translation - for the final RC, do we want to
> utilize this category? Exposing a localizer category increases visibility of
> that important group, but it does add complexity.

I'd definitely let the localizers add them selves to the list for the localization in question.

Comment 11

[Wayne Mery (:wsmwk)]

There is a consensus to do this as a flat file (see firefox's about:credits) and not use the categories listed in comment 8. If we do that, there is less reason to treat translators differently. If that is agreed, then for 3.0b4 all names will be listed under "Special Thanks To".  And for 3.0 final we'll get the string changes in for removing the categories and list everyone as just contributors.

Any peers and employees missing from the list below?  (more names to follow of course, but want to get this list squared first)

David Ascher
Mark Banner
David Bienvenu
Emre Birol
Philippe Chiasson
Bryan Clark
Joshua Cranmer
Rafael Ebron
Ludovic Hirlimann
Gary Kwong
Scott MacGregor
Magnus Melin
Dan Mosedale
Andreas Nisess
Phil Ringnalda
Andrew Sutherland
Roland Tanglao

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #11)
> Andreas Nisess

Andreas Nilsson

small nit.  will get back to my ui-review now

Comment 13

[Wayne Mery (:wsmwk)]

FWIW, from Gerv ...

Credit policy, as worked out in mozilla.governance in June 2007:
- about:credits will be a historical record of anyone who has made a sufficient qualifying contribution to the project; About box credits will be regenerated every major release by the owner of that product.
- The criteria for about:credits will be: "people who made a significant investment of time, with useful results, into Mozilla project-governed activities".

- The criteria for About boxes will be "people who made a significant contribution to making that particular release of that software happen".
- Both about:credits and the About box introductory text will be reviewed to make sure they reflect this distinction.
- People who get into the About box who also qualify for about:credits (which will not be all of them) may have their names copied across without seeking their permission.
- People may nominate themselves, or module owners and respected project contributors can nominate people, for about:credits; the about:credits maintainer does not have to seek the confirmation of the person concerned.
- About box credits will be regenerated by a process defined by the product owner.

So, for about:credits, this means: "hackers, QA, documenters, triagers, localisers, bug filers are in; addons authors, external website owners and evangelists are out - or rather, have other credits mechanisms for their work (NYT ad etc.)."

So "About box credits will be regenerated by a process defined by the product owner."

----------------------------------------

Comment 14

[Wayne Mery (:wsmwk)]

Attachment: TB3 credits patch v1

Can someone determine if v1 patch with commented out headings will work fine in a localized build?  v1 removes v2 names, adds some v3 names and comments out headings for leads, qa, build.  There should be no string changes.

for v2, more names to be added and comment out themes heading

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to comment #14)
> Created an attachment (id=400129) [details]
> TB3 credits patch v1
> 
> Can someone determine if v1 patch with commented out headings will work fine in
> a localized build?  

for the record, standard8 previously indicated that commenting out (headings) with <!-- --> should not impact locales.  

also it looks like translators credit themselves in their own version of C:\comm-central\mail\locales\<local>\chrome\messenger\credits.dtd - so we don't need to add that category.  Correct?


> v1 removes v2 names, adds some v3 names and comments out
> headings for leads, qa, build.  There should be no string changes.

that was sucky wording - better is ... patch v1 removes TB2 names, adds some TB3 names ...

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #9)
> cc: clarkbw for UI review on the webform at
> https://david.dabbledb.com/page/tb3credits/NyomUtuq

Everything looks pretty good, here are some comments:

* The "*" should be color: red; so they stand out
** You could be fancy and use all CSS to do this
*** e.g.: .dabblePageFormItemRequired > dabblePageFormLabel > label:after { content: "*"; color: red; }
* It'd be nice to have a larger font, is it just me or is the font a little small and hard to read?

Comment 17

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 400129 [details] [diff] [review]
TB3 credits patch v1

Thanks for putting this together, Wayne.  Looks good!  I've got a few review nits that I'll mention, which I'll fix and then land the patch.

>         <div class="creditsGroup">
>-          <h3>&credit.leads;</h3>
>-          <div class="credit">David Bienvenu</div>
>-          <div class="credit">Scott MacGregor</div>
>+          <!-- <h3>&credit.leads;</h3> -->
>         </div>

No need to leave an empty group and commented out markup here; we can always use Mercurial to find older versions if need be.  I'll remove.

In general, tabs complicate things, so we avoid them as much as possible in the Mozilla tree.  Typically, this requires messing around with an editor setting.  I've fixed this.


>-            <li>Dan Veditz</li>

I'm actually gone skip this removal.  Dan's already been a _huge_ help on security architecture related stuff for Tb3, and the bug list is unlikely to reflect that.

>+	    <li>This list is by no means complete - More To Be Announced</li>

I tightened up the wording here and moved this to the top of the list, so that folks who just look for the name and don't wait for the end of the list will be more likely to have seen it and avoid feeling hurt.

r=dmose

Comment 18

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch v2, updated to address review comments

Comment 19

[Dan Mosedale (:dmosedale, :dmose)]

I made one more string tweak, and checked in: 

<http://build.mozillamessaging.com/mercurial/comm-central/rev/3658f2ddfa81>

Comment 20

[Wayne Mery (:wsmwk)]

Attachment: credits round 2 v1 - names only

round 2 patch adds ~17 names who are significant patch contributors, and begins to add our top 10 testers.  I used a floor/bar of 6 bugs fixed since 2007-07-01 [1], excluding sev=trival, which encompasses most of the people called out in v1 patch. (I checked a list going back to 2007-02-01, and the top people didn't change afaict.)

The approximate bar used by Firefox is 10 bugs, with some names added from below that bar as judged appropriate to the contribution. Mconnor is using the idea of "did this person make a significant contribution?" Fx about list is 150-300 names (I stopped counting at 150).

[1] https://bugzilla.mozilla.org/report.cgi?y_axis_field=assigned_to&query_format=report-table&product=MailNews+Core&product=Thunderbird&resolution=FIXED&bug_severity=blocker&bug_severity=critical&bug_severity=major&bug_severity=normal&bug_severity=minor&bug_severity=enhancement&chfieldfrom=2007-07-01&chfieldto=Now&chfield=resolution&chfieldvalue=fixed&format=table&action=wrap

-----

Thanks for the previous checkin and cleanup. I had left the empty groups in out of concern that removing them would affect localizers.  Perhaps the tab got copied from something previous.

Comment 21

[David Ascher (:davida)]

Comment on attachment 400572 [details] [diff] [review]
credits round 2 v1 - names only

The criteria seem fine, except that I'm not sure I trust the "triviality" of some changes.  Do you get significantly more names without the restriction against "trivial" patches?

Comment 22

[Phil Ringnalda (:philor)]

The file is UTF-8, and the names you're adding are in ISO-8859-1 - we already have plenty of broken versions of Håkan's name, we really don't need more.

Comment 23

[Phil Ringnalda (:philor)]

And you've got tabs again, and Soref isn't timeless' first name, it's his last.

Comment 24

[Wayne Mery (:wsmwk)]

(In reply to comment #21)
> The criteria seem fine, except that I'm not sure I trust the "triviality" of
> some changes.  Do you get significantly more names without the restriction
> against "trivial" patches?

hope one of these answers your question 
a) magnus and serge account for >1/4 of the 78 trivial bugs, so in short no.  b) If you mean some sev=minor or normal bugs may have trivial patches that don't warrant much merit, that certainly can be (and is) true. But for most of the individuals whose names are new to us, the range of their fixes either include non-trivial bugs or, when looked at in total, a non-trivial set of contributions. 

On the other hand, there may be people below the 6 bugs bar that have made significant contributions that we'll need to rely on the nomination process to identify.  There are ~20 names with 4+5 bugs fixed, and ~40 names with 2+3 bugs fixed. Most of the address I don't recognize and these are too many for one person to screen. Though a couple names are already in the credits for other reasons.

I forgot to mention there are 189 bugs with assignee=nobody. I looked at the first 30 and most don't have patches - i.e. fixed by backout or other bugs and such.

improved, hopefully spotless patch coming up.

Comment 25

[Wayne Mery (:wsmwk)]

Attachment: credits round 2 v2 - names only [checked in]

Phil, thanks for the catch. I had noted your earlier comment and hoped I wouldn't commit the foul - but an unfamiliar editor ...

v2 patch hopefully fixes the issues, adds more names per davida and standard8, put ludo's name in it's proper order.

Comment 26

[David Ascher (:davida)]

Comment on attachment 400600 [details] [diff] [review]
credits round 2 v2 - names only [checked in]

looks good, even non-ascii chars =)

Comment 27

[Wayne Mery (:wsmwk)]

thanks. will need someone to check this in for me please.

Comment 28

[Phil Ringnalda (:philor)]

Comment on attachment 400600 [details] [diff] [review]
credits round 2 v2 - names only [checked in]

http://hg.mozilla.org/comm-central/rev/0137ac3ddf5e

Comment 29

[Wayne Mery (:wsmwk)]

I've updated https://david.dabbledb.com/page/tb3credits/NyomUtuq 

Revised and added text. Used bold in lieu of increasing font. But it doesn't appear to be taking any css. Field labels are autogenerated, so leaving the rest as is. * fields generate error if not completed.

Comment 30

[Reed Loden [:reed]]

Quick drive-by comment...

The "something like this" link on https://david.dabbledb.com/page/tb3credits/NyomUtuq should be changed to http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/credits/index.html?view=log. Thanks.

Comment 31

[Philippe M. Chiasson (:gozer)]

Attachment: Smal nit in my name

Awesome to find my name in there, thanks guys! One small nit about how I always spell my name, see the patch.

Comment 32

[Wayne Mery (:wsmwk)]

(In reply to comment #30)
> Quick drive-by comment...
> 
> The "something like this" link on
> https://david.dabbledb.com/page/tb3credits/NyomUtuq should be changed to
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.org/trunk/credits/index.html?view=log.
> Thanks.

thanks reed. fixed. changed from http://bonsai-www.mozilla.org/cvslog.cgi?file=mozilla-org/html/credits/index.html&rev=&root=/www/

Comment 33

[David Ascher (:davida)]

There are some third-party projects that we may want to thank explicitly in, somehow.  I'm thinking of:

 - Protovis
 - jQuery
 - sqlite

Thoughts?

Comment 34

[Wayne Mery (:wsmwk)]

possibilities: project, community or contributors

 - Protovis Community
 - jQuery Community
 - SQLite Community

Comment 35

[Wayne Mery (:wsmwk)]

Attachment: credits round 3 v1 - remove &credit.theme add names [Checkin: Comment 38]

remove &credit.theme
add names - mainly testers and triage

Comment 36

[Wayne Mery (:wsmwk)]

Comment on attachment 400947 [details] [diff] [review]
Smal nit in my name

my round 3 patch obsoleted this patch, but I hadn't intended to

Comment 37

[Wayne Mery (:wsmwk)]

(In reply to comment #35)
> Created an attachment (id=402097) [details]
> credits round 3 v1 - remove &credit.theme add names

needs checkin

Comment 38

[Serge Gautherie (:sgautherie)]

Comment on attachment 402097 [details] [diff] [review]
credits round 3 v1 - remove &credit.theme add names
[Checkin: Comment 38]


http://hg.mozilla.org/comm-central/rev/b48f9f075fe8

Comment 39

[Nikolay Shopik]

FIXED Per comment #38

Comment 40

[Wayne Mery (:wsmwk)]

no guys, this bug is not finished. please leave open

Comment 42

[Wayne Mery (:wsmwk)]

Web form https://david.dabbledb.com/page/tb3credits/NyomUtuq announced in mozilla.dev.apps.thunderbird  http://groups.google.com/group/mozilla.dev.apps.thunderbird/browse_thread/thread/a6199f2fa9b02b44# 

If you have a suggestion, please use the form, after you check the credits list first :)

Comment 43

[Wayne Mery (:wsmwk)]

Attachment: update credits.dtd to match heading removals of qa, build, theme, leads [checked in]

string changes attached

Notes: 
1. credit.memory appears to be unused in credits.dtd. IOW  "In Fond Memory Of"  remains (and it exists in Firefox also), but it is not referenced in credits.xhtml
2. sipaq, is the following existing information sufficient guidance to localizers regarding adding their names to credits?

<!-- localization credits look like this: -->
<!--
<!ENTITY credit.translation
  "<h3>Translators</h3><ul><li>Name Here</li></ul>">
-->

2a. for example we could modify to  "<h3>Translators</h3><ul><li>Name Here</li><li>Name Here</li></ul>">
2b. is this properly placed

Comment 44

[Wayne Mery (:wsmwk)]

Comment on attachment 403276 [details] [diff] [review]
update credits.dtd to match heading removals of qa, build, theme, leads [checked in]

sipaq, you are now the  sole reviewer for this credits.dtd

Comment 45

[Phil Ringnalda (:philor)]

credit.memory exists for when I kill someone between the string freeze and shipping, and we need to dedicate the release to them without breaking the string freeze. One of these days I'll get sufficiently tired of typing this comment, and I'll add a l10n note saying that, both to ours and to Firefox's.

Comment 46

[Simon Paquet [:sipaq]]

Comment on attachment 403276 [details] [diff] [review]
update credits.dtd to match heading removals of qa, build, theme, leads [checked in]

r=sipaq

Comment 47

[Phil Ringnalda (:philor)]

Comment on attachment 403276 [details] [diff] [review]
update credits.dtd to match heading removals of qa, build, theme, leads [checked in]

http://hg.mozilla.org/comm-central/rev/23a43c358a47

Comment 48

[Dan Mosedale (:dmosedale, :dmose)]

Wayne, can you update the status whiteboard to explain what work remains here?  Thanks!

Comment 49

[Wayne Mery (:wsmwk)]

There are more names to be added for RC1, but I anticipate no changes other than names.  At least one set this week, sadly none of them via https://david.dabbledb.com/page/tb3credits/NyomUtuq

This need not be on blocking list if standard8 will accept patches for approval.

Comment 50

[Dan Mosedale (:dmosedale, :dmose)]

Well, we want the list to be "right" for some value of "right" for RC1, and that does block, so I think this should stay blocking until we're satisfied.

Comment 51

[Wayne Mery (:wsmwk)]

Attachment: [checked in] credits round 4 v1 - remove "WIP", add names

Most additions are from:
* litmus top 10 testers
* bug 518635 persons with >200 bug comments (sharp drop below 200)
* bug 518635 most bug closures (of which only few weren't already listed in credits)
Plus a few nominated via the dabble database.

1 person declined to be listed.
~3 did not return two contact attempts.

We're done, sans checkin.

Comment 52

[Mark Banner (:standard8)]

Comment on attachment 409309 [details] [diff] [review]
[checked in] credits round 4 v1 - remove "WIP", add names

Checked in:
http://hg.mozilla.org/comm-central/rev/0c9f0ab1b69f
http://hg.mozilla.org/releases/comm-1.9.1/rev/75e98b03e81c

Comment 53

[Mark Banner (:standard8)]

We now believe we've got all the people we need to credit. If there are others we've somehow missed, we can pick them up in separate bugs/patches.

Comment 54

[Alex Ihrig [:Thunderbird_Mail_DE]]

The last checkin added 2 times "Ronald Killmer".

Comment 55

[Mark Banner (:standard8)]

(In reply to comment #54)
> The last checkin added 2 times "Ronald Killmer".

Thanks for catching that, fixed:
http://hg.mozilla.org/comm-central/rev/1a3e00fffea3
http://hg.mozilla.org/releases/comm-1.9.1/rev/04005457f7d8