Assigning a theme parameter overrides modules viewing permissions

VERIFIED FIXED in 0.6

Status

--
major
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: brian, Assigned: nkoth)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tiki_test (see comment 4))

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
When you assign a theme parameter to a module that has special permissions, it overrides these permissions.

Example (what I did to discover this):
Assign Contributors module to Contributors group with parameter "theme=mozkb.css"
(Reporter)

Updated

11 years ago
No longer blocks: 441658
(Reporter)

Updated

11 years ago
Blocks: 441658
(Assignee)

Updated

11 years ago
Assignee: nobody → nelson
(Assignee)

Comment 1

11 years ago
Created attachment 327552 [details] [diff] [review]
module filters should consistently use "AND" logic rather than "OR" logic

Good catch Brian. I think this makes sense, since if you wanted to use OR logic, you can always create multiple modules.
Attachment #327552 - Flags: review?(laura)
(Assignee)

Updated

11 years ago
Blocks: 442267

Comment 2

11 years ago
Comment on attachment 327552 [details] [diff] [review]
module filters should consistently use "AND" logic rather than "OR" logic

I'm not really sure about the logic here (no familiarity with the module stuff)...it looks ok to me but you might want review from Jason or somebody a bit deeper in Tiki.

Comment 3

11 years ago
Comment on attachment 327552 [details] [diff] [review]
module filters should consistently use "AND" logic rather than "OR" logic

Oh, and from my perspective r+.
Attachment #327552 - Flags: review?(laura) → review+
(Assignee)

Comment 4

11 years ago
should be right - there was discussion about this in TikiWiki before and I think this is the right solution.

In r16595 (trunk) and r16596 (production).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

10 years ago
I set the module to only appear on mozkb and it doesn't show when logged out...seems to have worked, will wait for QA to confirm.

Nelson: I only set the module to mozkb, if you want it on others just duplicate it I guess.  Thanks!!
Verified FIXED, since both bug 441658 and bug 442267, which depended on this, are verified fixed.
Status: RESOLVED → VERIFIED

Updated

9 years ago
Whiteboard: tiki_triage (see comment 4)

Updated

9 years ago
Whiteboard: tiki_triage (see comment 4) → tiki_test (see comment 4)
You need to log in before you can comment on or make changes to this bug.