442981 - Weave FirstRun Account Verification Step interacts badly with Master Password dialog

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Daniel Holbert [:dholbert]]

I ran into this bug when upgrading from v0.1.34 to v0.2.0 today, though you can reproduce it using only v0.2.0, as described below.

Steps to reproduce:
 1. Add a master password to your Firefox 3 profile.
 2. Install Weave 0.2.0, making sure to tell it to...
      - save your username & password & passphrase
      - NOT automatically login
 3. Restart Firefox, to lock your master password.  From this point on, cancel any Master Password dialogs that appear.  (there shouldn't be any until step 9)
 4. Click Weave icon in status bar, and select Preferences
 5. Click "Create Account"
 6. Click through the license agreement
 7. Click "Set up Another Computer"
 8. Type in your username
 9. Type one character into either the password or the passphrase field.
    --> Spawns a "Master Password Dialog". (cancel it, for now)
 10. Type in one more character.
    --> Spawns another "Master Password Dialog". (cancel it, for now)
 11. Type in your full password and passphrase. (Ignoring & canceling the dialogs as best you can)
    --> Shows "Invalid username and password" and "Invalid passphrase", when in fact they're correct
 12. Retype the last character of your password, to trigger another master password dialog.  This time, enter your master password.
    --> Password message changes to "Username and Password Verified", but passphrase message changes to "Verifying passphrase", and it never changes.
 13.  Retype the last character of your passphrase.  (*now* the passphrase actually verifies, and I can click "next")

A few more notes:
  - I'm guessing that Weave needs my master password here is so it can *store* my username/password/passphrase.  (It doesn't seem to be using it to look anything up -- it doesn't auto-fill any of the fields when I enter it.)

EXPECTED BEHAVIOR:
  IMHO, a master password dialog should only appear until *after* I've successfully verified my passwords, probably when I click "Next".  At this point, the passwords would be actually saved in my password database. (If I get the master password wrong or cancel the dialog at that point, Weave should handle this gracefully as well, with a warning and/or a repeated prompt.)

VERSION INFO:
 * Weave 0.2.0
 * Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1pre) Gecko/2008061804
GranParadiso/3.0.1pre
 * Ubuntu Linux 8.04

Comment 1

[Daniel Holbert [:dholbert]]

This bug's behavior is probably largely dependent on bug 442985.

Comment 2

[Dan Mills [:thunder]]

-> 0.3, P2.

Comment 3

[Dan Mills [:thunder]]

The wizard attempts to check the password as it is typed (with a delay, iirc), so we can give the user immediate feedback.  I believe we don't activate the 'next' button until the account is verified.

Either the wizard is calling Weave.Service.login(), or Weave.Service.verifyLogin() is incorrectly saving the credentials.

Comment 5

[Dan Mills [:thunder]]

This is fixed by about:weave (bug 507430)