445321 - remove --enable-glitz and related defines

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[(not currently active) Ted Mielczarek]

Given the wontfixes in bug 376083 and bug 356899, we should remove --enable-glitz so people stop trying to use it.

Comment 1

[Arpad Borsos [:Swatinem]]

Well according to bug #356899 comment #4 glitz is dead so I believe glitz should be completely removed from code and not just from the configures and makefiles.

I have a patch ready to do that, I just need to verify that it still builds (on linux at least)

Comment 2

[Arpad Borsos [:Swatinem]]

Attachment: completely remove glitz

This completely removes glitz, including the glitz source in gfx/cairo/glitz, all the ifdefs in gfx and widget and the UseGlitz() code in thebes gfxPlatform.
What I haven't touched is the Glitz stuff in cairo.
Compiles and works fine on Linux, I couldn't test on Windows or Mac though.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 333397 [details] [diff] [review]
completely remove glitz

r=me on the build bits

Comment 4

[Arpad Borsos [:Swatinem]]

Attachment: update for PlatformGtk changes

Fix the patch to apply again after the recent PlatformGtk changes.
Build parts haven't changed.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 334510 [details] [diff] [review]
update for PlatformGtk changes

Removing it sounds good to me; need to kick off a try server build just to make sure that nothing broke on win32/mac, though.

Comment 6

[Arpad Borsos [:Swatinem]]

(In reply to comment #5)
> need to kick off a try server build just to make
> sure that nothing broke on win32/mac, though.

Could you do that please? I don't have push rights.

Comment 7

[Arpad Borsos [:Swatinem]]

Attachment: unbitrot

The patch bitrots quite often. This is updated to a recent mozilla-central and also includes additional build fixes (removing the glitz makefiles from toolkit-makefiles)
Would be good to get this patch tested on the other 2 major platforms and landed some time soon so it does not bitrot any more.

Comment 8

[(not currently active) Ted Mielczarek]

I pushed this to the tryserver and it built fine on Linux/Mac (still waiting on Win32). I don't think you need review again just to unbitrot the patch. I'll push it to mozilla-central when the tree opens again.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 340742 [details] [diff] [review]
unbitrot

Clearing review requests. I'll land this when the tree goes green.

Comment 10

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/7c61aba7c47d

Thanks for the patch!