Closed
Bug 445321
Opened 17 years ago
Closed 17 years ago
remove --enable-glitz and related defines
Categories
(Core Graveyard :: GFX, defect)
Core Graveyard
GFX
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: Swatinem)
References
Details
Attachments
(1 file, 2 obsolete files)
678.53 KB,
patch
|
Details | Diff | Splinter Review |
Given the wontfixes in bug 376083 and bug 356899, we should remove --enable-glitz so people stop trying to use it.
Assignee | ||
Comment 1•17 years ago
|
||
Well according to bug #356899 comment #4 glitz is dead so I believe glitz should be completely removed from code and not just from the configures and makefiles.
I have a patch ready to do that, I just need to verify that it still builds (on linux at least)
Assignee | ||
Comment 2•17 years ago
|
||
This completely removes glitz, including the glitz source in gfx/cairo/glitz, all the ifdefs in gfx and widget and the UseGlitz() code in thebes gfxPlatform.
What I haven't touched is the Glitz stuff in cairo.
Compiles and works fine on Linux, I couldn't test on Windows or Mac though.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #333397 -
Flags: superreview?(vladimir)
Attachment #333397 -
Flags: review?(vladimir)
Attachment #333397 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 3•17 years ago
|
||
Comment on attachment 333397 [details] [diff] [review]
completely remove glitz
r=me on the build bits
Attachment #333397 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Fix the patch to apply again after the recent PlatformGtk changes.
Build parts haven't changed.
Attachment #333397 -
Attachment is obsolete: true
Attachment #334510 -
Flags: superreview?(vladimir)
Attachment #334510 -
Flags: review?(vladimir)
Attachment #333397 -
Flags: superreview?(vladimir)
Attachment #333397 -
Flags: review?(vladimir)
Comment on attachment 334510 [details] [diff] [review]
update for PlatformGtk changes
Removing it sounds good to me; need to kick off a try server build just to make sure that nothing broke on win32/mac, though.
Attachment #334510 -
Flags: superreview?(vladimir)
Attachment #334510 -
Flags: superreview+
Attachment #334510 -
Flags: review?(vladimir)
Attachment #334510 -
Flags: review+
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #5)
> need to kick off a try server build just to make
> sure that nothing broke on win32/mac, though.
Could you do that please? I don't have push rights.
Assignee | ||
Comment 7•17 years ago
|
||
The patch bitrots quite often. This is updated to a recent mozilla-central and also includes additional build fixes (removing the glitz makefiles from toolkit-makefiles)
Would be good to get this patch tested on the other 2 major platforms and landed some time soon so it does not bitrot any more.
Attachment #334510 -
Attachment is obsolete: true
Attachment #340742 -
Flags: superreview?(vladimir)
Attachment #340742 -
Flags: review?(vladimir)
Attachment #340742 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 8•17 years ago
|
||
I pushed this to the tryserver and it built fine on Linux/Mac (still waiting on Win32). I don't think you need review again just to unbitrot the patch. I'll push it to mozilla-central when the tree opens again.
Reporter | ||
Updated•17 years ago
|
Attachment #340742 -
Flags: superreview?(vladimir)
Attachment #340742 -
Flags: review?(vladimir)
Attachment #340742 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 9•17 years ago
|
||
Comment on attachment 340742 [details] [diff] [review]
unbitrot
Clearing review requests. I'll land this when the tree goes green.
Reporter | ||
Comment 10•17 years ago
|
||
Pushed:
http://hg.mozilla.org/mozilla-central/rev/7c61aba7c47d
Thanks for the patch!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•