Closed Bug 445321 Opened 13 years ago Closed 13 years ago
remove --enable-glitz and related defines
Given the wontfixes in bug 376083 and bug 356899, we should remove --enable-glitz so people stop trying to use it.
Well according to bug #356899 comment #4 glitz is dead so I believe glitz should be completely removed from code and not just from the configures and makefiles. I have a patch ready to do that, I just need to verify that it still builds (on linux at least)
This completely removes glitz, including the glitz source in gfx/cairo/glitz, all the ifdefs in gfx and widget and the UseGlitz() code in thebes gfxPlatform. What I haven't touched is the Glitz stuff in cairo. Compiles and works fine on Linux, I couldn't test on Windows or Mac though.
Comment on attachment 333397 [details] [diff] [review] completely remove glitz r=me on the build bits
Attachment #333397 - Flags: review?(ted.mielczarek) → review+
Fix the patch to apply again after the recent PlatformGtk changes. Build parts haven't changed.
Comment on attachment 334510 [details] [diff] [review] update for PlatformGtk changes Removing it sounds good to me; need to kick off a try server build just to make sure that nothing broke on win32/mac, though.
(In reply to comment #5) > need to kick off a try server build just to make > sure that nothing broke on win32/mac, though. Could you do that please? I don't have push rights.
The patch bitrots quite often. This is updated to a recent mozilla-central and also includes additional build fixes (removing the glitz makefiles from toolkit-makefiles) Would be good to get this patch tested on the other 2 major platforms and landed some time soon so it does not bitrot any more.
I pushed this to the tryserver and it built fine on Linux/Mac (still waiting on Win32). I don't think you need review again just to unbitrot the patch. I'll push it to mozilla-central when the tree opens again.
Comment on attachment 340742 [details] [diff] [review] unbitrot Clearing review requests. I'll land this when the tree goes green.
Pushed: http://hg.mozilla.org/mozilla-central/rev/7c61aba7c47d Thanks for the patch!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.