445573 - Ctrl+Tab: Holding tab should bring up tab-switching panel and repeat

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a1pre) Gecko/2008071602 Minefield/3.1a1pre

Steps to reproduce:
1. Make sure you have at least 3 tabs open.
2. Start holding Ctrl, then start holding Tab.
3. Wait a few seconds
4. release Tab and then Ctrl.

Result: Nothing happens until you release tab.

Expected: Key-repeat should kick in and cycle through tab in the panel quickly (for consistency with Cmd+Tab on Tiger).

Comment 1

[Daniel Holbert [:dholbert]]

Same actual & desired behavior on Ubuntu Linux.  (for consistency with alt-tab behavior)

OS & Platform --> All.

Comment 2

[Marcia Knous [:marcia]]

I crashed shortly after following Jesse's STR using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a1pre) Gecko/2008071602 Minefield/3.1a1pre. I have not been able to reproduce. My Breakpad report is still processing: http://crash-stats.mozilla.com/report/index/33fba8c0-5374-11dd-a995-001a4bd43ef6

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

this applies on top of the patch in bug 445369

Comment 4

[Dão Gottwald [:dao]]

Note that this already works as expected on Windows. For some reason, the keydown event is repeated on Windows but not on other platforms.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

updated to trunk

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/23a09bfad7ca

Comment 7

[Marcia Knous [:marcia]]

Dao: using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1a2pre) Gecko/20080812022114 Minefield/3.1a2pre and following Jesse's STR, I am not able to cycle through tabs. This seems to work fine using the equivalent build on 10.5 - if I hold the tab key down I can cycle quickly through the tabs.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Dao: using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US;
> rv:1.9.1a2pre) Gecko/20080812022114 Minefield/3.1a2pre and following Jesse's
> STR, I am not able to cycle through tabs.

This is due to the way bug 374076 has been fixed -- see bug 374076 comment 33.