Empty email address in user edit form should throw error

VERIFIED FIXED in 3.4.6

Status

addons.mozilla.org Graveyard
Public Pages
--
minor
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: baz, Assigned: wenzel)

Tracking

unspecified
3.4.6

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
- Go to your My Account page and remove your email address
- Click "Save"
- AMO responds with "Profile Updated"

Expected behavior is that this field should not be blank
(Assignee)

Comment 1

10 years ago
Created attachment 330085 [details] [diff] [review]
Display error on empty email field in user edit form

While I don't think this has caused bug 434540, good catch anyway, Basil.

Before, an empty email address was simply ignored, but it's a better experience if this is actually pointed out to the user as an error.
Assignee: nobody → fwenzel
Status: NEW → ASSIGNED
Attachment #330085 - Flags: review?(bkrausz)
(Assignee)

Updated

10 years ago
Target Milestone: --- → 3.4.6
(Assignee)

Updated

10 years ago
Summary: Removing one's email address and saving → Empty email address in user edit form should throw error

Comment 2

10 years ago
Comment on attachment 330085 [details] [diff] [review]
Display error on empty email field in user edit form

Looks good to me :)
Attachment #330085 - Flags: review?(bkrausz) → review+
(Assignee)

Comment 3

10 years ago
Thanks. Committed to r17167.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
I now correctly get "There are errors in this form. Please correct them and resubmit." above the login form, and below the "Email address" textfield, "This field must not be empty."  Validation of a bogus email address still works too: "s" yields, "This is not a valid email address."

Verified FIXED
Status: RESOLVED → VERIFIED
(Assignee)

Updated

10 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.