445664 - Empty email address in user edit form should throw error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Basil Hashem [:baz]]

- Go to your My Account page and remove your email address
- Click "Save"
- AMO responds with "Profile Updated"

Expected behavior is that this field should not be blank

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Display error on empty email field in user edit form

While I don't think this has caused bug 434540, good catch anyway, Basil.

Before, an empty email address was simply ignored, but it's a better experience if this is actually pointed out to the user as an error.

Comment 2

[Brian Krausz]

Comment on attachment 330085 [details] [diff] [review]
Display error on empty email field in user edit form

Looks good to me :)

Comment 3

[Fred Wenzel [:wenzel]]

Thanks. Committed to r17167.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

I now correctly get "There are errors in this form. Please correct them and resubmit." above the login form, and below the "Email address" textfield, "This field must not be empty."  Validation of a bogus email address still works too: "s" yields, "This is not a valid email address."

Verified FIXED