434540 - Submitting an empty login form leads to bogus error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Fred Wenzel [:wenzel]]

Submitting a completely empty login form on AMO leads to a page stating "Please confirm your user account first with the code you received by email.".

That of course makes little sense and we should tell the user to fill in the blanks correctly, instead.

Comment 1

[Fred Wenzel [:wenzel]]

Btw. we already have a "this field must not be empty" string, so we don't even need new l10n for this. Woot.

Comment 2

[Ryan Doherty (:rdoherty)]

We're getting this error because someone, somehow, entered no email address when registering. ??

I'll create the sql query to remove it and file an IT bug.

Comment 3

[Basil Hashem [:baz]]

Hmmm..I was curious if maybe our user edit form allows users to somehow delete their email address...trying to remove one's address from https://addons.mozilla.org/en-US/firefox/users/edit then clicking save replies with "Profile Updated" but then clicking "My Account" takes you back and fills in the value. We should probably warn about that. Created bug 445664 to cover that.

Changing the value will generate a change-of-address confirmation email.

Comment 4

[Fred Wenzel [:wenzel]]

"Wrong username or password!" -> FIXED

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Since this isn't fixed, does bug 446360 cover it?  If so, we should just mark this a dup of that bug.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

NM, this is really that "preview's DB isn't updated" bug that I always gets tripped up on, sigh.  I'll verify this in production, then?

Comment 8

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> I'll verify this in production, then?

Yes, please.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I get the "Wrong username or password!" text on https://addons.mozilla.org/en-US/firefox/users/login